2019-05-31 01:25:58

by Gen Zhang

Subject: [PATCH] mdesc: fix a missing-check bug in get_vdev_port_node_info()

In get_vdev_port_node_info(), 'node_info->vdev_port.name' is allcoated
by kstrdup_const(), and it returns NULL when fails. So
'node_info->vdev_port.name' should be checked.

Signed-off-by: Gen Zhang <[email protected]>
---
diff --git a/arch/sparc/kernel/mdesc.c b/arch/sparc/kernel/mdesc.c
index 9a26b44..8e645dd 100644
--- a/arch/sparc/kernel/mdesc.c
+++ b/arch/sparc/kernel/mdesc.c
@@ -356,6 +356,8 @@ static int get_vdev_port_node_info(struct mdesc_handle *md, u64 node,

node_info->vdev_port.id = *idp;
node_info->vdev_port.name = kstrdup_const(name, GFP_KERNEL);
+ if (!node_info->vdev_port.name)
+ return -1;
node_info->vdev_port.parent_cfg_hdl = *parent_cfg_hdlp;

return 0;
---

2019-06-03 05:17:47

by David Miller

Subject: Re: [PATCH] mdesc: fix a missing-check bug in get_vdev_port_node_info()

From: Gen Zhang <[email protected]>
Date: Fri, 31 May 2019 09:24:18 +0800

> In get_vdev_port_node_info(), 'node_info->vdev_port.name' is allcoated
> by kstrdup_const(), and it returns NULL when fails. So
> 'node_info->vdev_port.name' should be checked.
>
> Signed-off-by: Gen Zhang <[email protected]>

Applied, thanks.