2019-06-01 08:08:14

by Yue Haibing

Subject: [PATCH net-next] qed: Fix build error without CONFIG_DEVLINK

Fix gcc build error while CONFIG_DEVLINK is not set

drivers/net/ethernet/qlogic/qed/qed_main.o: In function `qed_remove':
qed_main.c:(.text+0x1eb4): undefined reference to `devlink_unregister'

Select DEVLINK to fix this.

Reported-by: Hulk Robot <[email protected]>
Fixes: 24e04879abdd ("qed: Add qed devlink parameters table")
Signed-off-by: YueHaibing <[email protected]>
---
drivers/net/ethernet/qlogic/Kconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/qlogic/Kconfig b/drivers/net/ethernet/qlogic/Kconfig
index fdbb3ce..a391cf6 100644
--- a/drivers/net/ethernet/qlogic/Kconfig
+++ b/drivers/net/ethernet/qlogic/Kconfig
@@ -87,6 +87,7 @@ config QED
depends on PCI
select ZLIB_INFLATE
select CRC8
+ select NET_DEVLINK
---help---
This enables the support for ...

--
2.7.4

2019-06-02 07:52:40

by Michal Kalderon

Subject: RE: [PATCH net-next] qed: Fix build error without CONFIG_DEVLINK

> From: [email protected] <[email protected]>
> On Behalf Of YueHaibing
>
> Fix gcc build error while CONFIG_DEVLINK is not set
>
> drivers/net/ethernet/qlogic/qed/qed_main.o: In function `qed_remove':
> qed_main.c:(.text+0x1eb4): undefined reference to `devlink_unregister'
>
> Select DEVLINK to fix this.
>
> Reported-by: Hulk Robot <[email protected]>
> Fixes: 24e04879abdd ("qed: Add qed devlink parameters table")
> Signed-off-by: YueHaibing <[email protected]>
> ---
> drivers/net/ethernet/qlogic/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ethernet/qlogic/Kconfig
> b/drivers/net/ethernet/qlogic/Kconfig
> index fdbb3ce..a391cf6 100644
> --- a/drivers/net/ethernet/qlogic/Kconfig
> +++ b/drivers/net/ethernet/qlogic/Kconfig
> @@ -87,6 +87,7 @@ config QED
> depends on PCI
> select ZLIB_INFLATE
> select CRC8
> + select NET_DEVLINK
> ---help---
> This enables the support for ...
>
> --
> 2.7.4
>

Thanks,?

Acked-by: Michal Kalderon?<[email protected]>

2019-06-03 22:14:21

by David Miller

Subject: Re: [PATCH net-next] qed: Fix build error without CONFIG_DEVLINK

From: YueHaibing <[email protected]>
Date: Sat, 1 Jun 2019 16:06:05 +0800

> Fix gcc build error while CONFIG_DEVLINK is not set
>
> drivers/net/ethernet/qlogic/qed/qed_main.o: In function `qed_remove':
> qed_main.c:(.text+0x1eb4): undefined reference to `devlink_unregister'
>
> Select DEVLINK to fix this.
>
> Reported-by: Hulk Robot <[email protected]>
> Fixes: 24e04879abdd ("qed: Add qed devlink parameters table")
> Signed-off-by: YueHaibing <[email protected]>

Applied.