2019-06-04 08:24:20

by Colin King

Subject: [PATCH][next][V2] bpf: remove redundant assignment to err

From: Colin Ian King <[email protected]>

The variable err is assigned with the value -EINVAL that is never
read and it is re-assigned a new value later on. The assignment is
redundant and can be removed.

Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <[email protected]>

---

V2: reorder variables as recommended by Jakub Kicinski to keep in
the networking code style.

---
kernel/bpf/devmap.c | 2 +-
kernel/bpf/xskmap.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/kernel/bpf/devmap.c b/kernel/bpf/devmap.c
index 5ae7cce5ef16..b58a33ca8a27 100644
--- a/kernel/bpf/devmap.c
+++ b/kernel/bpf/devmap.c
@@ -88,8 +88,8 @@ static u64 dev_map_bitmap_size(const union bpf_attr *attr)
static struct bpf_map *dev_map_alloc(union bpf_attr *attr)
{
struct bpf_dtab *dtab;
- int err = -EINVAL;
u64 cost;
+ int err;

if (!capable(CAP_NET_ADMIN))
return ERR_PTR(-EPERM);
diff --git a/kernel/bpf/xskmap.c b/kernel/bpf/xskmap.c
index 22066c28ba61..413d75f4fc72 100644
--- a/kernel/bpf/xskmap.c
+++ b/kernel/bpf/xskmap.c
@@ -17,8 +17,8 @@ struct xsk_map {

static struct bpf_map *xsk_map_alloc(union bpf_attr *attr)
{
- int cpu, err = -EINVAL;
struct xsk_map *m;
+ int cpu, err;
u64 cost;

if (!capable(CAP_NET_ADMIN))
--
2.20.1

2019-06-04 12:00:50

by Jesper Dangaard Brouer

Subject: Re: [PATCH][next][V2] bpf: remove redundant assignment to err

On Tue, 4 Jun 2019 09:21:46 +0100
Colin King <[email protected]> wrote:

> From: Colin Ian King <[email protected]>
>
> The variable err is assigned with the value -EINVAL that is never
> read and it is re-assigned a new value later on. The assignment is
> redundant and can be removed.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <[email protected]>
>
> ---
>
> V2: reorder variables as recommended by Jakub Kicinski to keep in
> the networking code style.

Thank you for following the networking coding style.

Acked-by: Jesper Dangaard Brouer <[email protected]>

--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Principal Kernel Engineer at Red Hat
LinkedIn: http://www.linkedin.com/in/brouer

2019-06-04 15:08:20

by Daniel Borkmann

Subject: Re: [PATCH][next][V2] bpf: remove redundant assignment to err

On 06/04/2019 10:21 AM, Colin King wrote:
> From: Colin Ian King <[email protected]>
>
> The variable err is assigned with the value -EINVAL that is never
> read and it is re-assigned a new value later on. The assignment is
> redundant and can be removed.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <[email protected]>

Applied, thanks!