2019-06-05 13:55:36

by Valerio G

Subject: [PATCH] staging: isdn: hysdn: fix symbol 'hysdn_proc_entry' was not declared.

This was reported by sparse:
drivers/staging/isdn/hysdn/hysdn_procconf.c:352:23: warning: symbol 'hysdn_proc_entry' was not declared. Should it be static?

Signed-off-by: Valerio Genovese <[email protected]>
---
drivers/staging/isdn/hysdn/hysdn_defs.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/isdn/hysdn/hysdn_defs.h b/drivers/staging/isdn/hysdn/hysdn_defs.h
index cdac46a21692..a651686b1787 100644
--- a/drivers/staging/isdn/hysdn/hysdn_defs.h
+++ b/drivers/staging/isdn/hysdn/hysdn_defs.h
@@ -221,7 +221,7 @@ typedef struct hycapictrl_info hycapictrl_info;
/* exported vars */
/*****************/
extern hysdn_card *card_root; /* pointer to first card */
-
+extern struct proc_dir_entry *hysdn_proc_entry; /* hysdn subdir in /proc/net


/*************************/
--
2.17.1

2019-06-05 14:23:13

by Greg Kroah-Hartman

Subject: Re: [PATCH] staging: isdn: hysdn: fix symbol 'hysdn_proc_entry' was not declared.

On Wed, Jun 05, 2019 at 03:53:49PM +0200, Valerio Genovese wrote:
> This was reported by sparse:
> drivers/staging/isdn/hysdn/hysdn_procconf.c:352:23: warning: symbol 'hysdn_proc_entry' was not declared. Should it be static?
>
> Signed-off-by: Valerio Genovese <[email protected]>
> ---
> drivers/staging/isdn/hysdn/hysdn_defs.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/isdn/hysdn/hysdn_defs.h b/drivers/staging/isdn/hysdn/hysdn_defs.h
> index cdac46a21692..a651686b1787 100644
> --- a/drivers/staging/isdn/hysdn/hysdn_defs.h
> +++ b/drivers/staging/isdn/hysdn/hysdn_defs.h
> @@ -221,7 +221,7 @@ typedef struct hycapictrl_info hycapictrl_info;
> /* exported vars */
> /*****************/
> extern hysdn_card *card_root; /* pointer to first card */
> -
> +extern struct proc_dir_entry *hysdn_proc_entry; /* hysdn subdir in /proc/net
>
>
> /*************************/

Shouldn't you also remove it from the place it was devlared as extern?

Also, this is code on its way out of the kernel, not a big deal to leave
it alone for now.

thanks,

greg k-h

2019-06-09 11:01:02

by Greg Kroah-Hartman

Subject: Re: [PATCH] staging: isdn: hysdn: fix symbol 'hysdn_proc_entry' was not declared.

On Wed, Jun 05, 2019 at 03:53:49PM +0200, Valerio Genovese wrote:
> This was reported by sparse:
> drivers/staging/isdn/hysdn/hysdn_procconf.c:352:23: warning: symbol 'hysdn_proc_entry' was not declared. Should it be static?
>
> Signed-off-by: Valerio Genovese <[email protected]>
> ---
> drivers/staging/isdn/hysdn/hysdn_defs.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/isdn/hysdn/hysdn_defs.h b/drivers/staging/isdn/hysdn/hysdn_defs.h
> index cdac46a21692..a651686b1787 100644
> --- a/drivers/staging/isdn/hysdn/hysdn_defs.h
> +++ b/drivers/staging/isdn/hysdn/hysdn_defs.h
> @@ -221,7 +221,7 @@ typedef struct hycapictrl_info hycapictrl_info;
> /* exported vars */
> /*****************/
> extern hysdn_card *card_root; /* pointer to first card */
> -
> +extern struct proc_dir_entry *hysdn_proc_entry; /* hysdn subdir in /proc/net

I can not take drivers/staging/isdn patches until 5.3-rc1.

thanks,

greg k-h