2019-06-14 07:42:13

by Eiichi Tsukata

Subject: [PATCH 2/2] tracing/uprobe: Fix obsolete comment on trace_uprobe_create()

Commit 0597c49c69d5 ("tracing/uprobes: Use dyn_event framework for
uprobe events") cleaned up the usage of trace_uprobe_create(), and the
function has been no longer used for removing uprobe/uretprobe.

Signed-off-by: Eiichi Tsukata <[email protected]>
---
kernel/trace/trace_uprobe.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/kernel/trace/trace_uprobe.c b/kernel/trace/trace_uprobe.c
index 7dc8ee55cf84..7860e3f59fad 100644
--- a/kernel/trace/trace_uprobe.c
+++ b/kernel/trace/trace_uprobe.c
@@ -426,8 +426,6 @@ static int register_trace_uprobe(struct trace_uprobe *tu)
/*
* Argument syntax:
* - Add uprobe: p|r[:[GRP/]EVENT] PATH:OFFSET [FETCHARGS]
- *
- * - Remove uprobe: -:[GRP/]EVENT
*/
static int trace_uprobe_create(int argc, const char **argv)
{
--
2.21.0

2019-06-14 12:33:27

by Srikar Dronamraju

Subject: Re: [PATCH 2/2] tracing/uprobe: Fix obsolete comment on trace_uprobe_create()

* Eiichi Tsukata <[email protected]> [2019-06-14 16:40:26]:

> Commit 0597c49c69d5 ("tracing/uprobes: Use dyn_event framework for
> uprobe events") cleaned up the usage of trace_uprobe_create(), and the
> function has been no longer used for removing uprobe/uretprobe.
>

Agree

Reviewed-by: Srikar Dronamraju <[email protected]>

> Signed-off-by: Eiichi Tsukata <[email protected]>
> ---
> kernel/trace/trace_uprobe.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/kernel/trace/trace_uprobe.c b/kernel/trace/trace_uprobe.c
> index 7dc8ee55cf84..7860e3f59fad 100644
> --- a/kernel/trace/trace_uprobe.c
> +++ b/kernel/trace/trace_uprobe.c
> @@ -426,8 +426,6 @@ static int register_trace_uprobe(struct trace_uprobe *tu)
> /*
> * Argument syntax:
> * - Add uprobe: p|r[:[GRP/]EVENT] PATH:OFFSET [FETCHARGS]
> - *
> - * - Remove uprobe: -:[GRP/]EVENT
> */
> static int trace_uprobe_create(int argc, const char **argv)
> {
> --
> 2.21.0
>

--
Thanks and Regards
Srikar Dronamraju