2019-06-26 03:31:43

by Yue Hu

Subject: [PATCH RESEND] staging: erofs: return the error value if fill_inline_data() fails

From: Yue Hu <[email protected]>

We should consider the error returned by fill_inline_data() when filling
last page in fill_inode(). If not getting inode will be successful even
though last page is bad. That is illogical. Also change -EAGAIN to 0 in
fill_inline_data() to stand for successful filling.

Signed-off-by: Yue Hu <[email protected]>
---
drivers/staging/erofs/inode.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/erofs/inode.c b/drivers/staging/erofs/inode.c
index d6e1e16..1433f25 100644
--- a/drivers/staging/erofs/inode.c
+++ b/drivers/staging/erofs/inode.c
@@ -156,7 +156,7 @@ static int fill_inline_data(struct inode *inode, void *data,
inode->i_link = lnk;
set_inode_fast_symlink(inode);
}
- return -EAGAIN;
+ return 0;
}

static int fill_inode(struct inode *inode, int isdir)
@@ -223,7 +223,7 @@ static int fill_inode(struct inode *inode, int isdir)
inode->i_mapping->a_ops = &erofs_raw_access_aops;

/* fill last page if inline data is available */
- fill_inline_data(inode, data, ofs);
+ err = fill_inline_data(inode, data, ofs);
}

out_unlock:
--
1.9.1

2019-06-26 07:16:29

by Chao Yu

Subject: Re: [PATCH RESEND] staging: erofs: return the error value if fill_inline_data() fails

On 2019/6/26 11:30, Yue Hu wrote:
> From: Yue Hu <[email protected]>
>
> We should consider the error returned by fill_inline_data() when filling
> last page in fill_inode(). If not getting inode will be successful even
> though last page is bad. That is illogical. Also change -EAGAIN to 0 in
> fill_inline_data() to stand for successful filling.
>
> Signed-off-by: Yue Hu <[email protected]>

Reviewed-by: Chao Yu <[email protected]>

Thanks,

2019-06-26 09:05:31

by Gao Xiang

Subject: Re: [PATCH RESEND] staging: erofs: return the error value if fill_inline_data() fails

Hi Yue,

On 2019/6/26 11:30, Yue Hu wrote:
> From: Yue Hu <[email protected]>
>
> We should consider the error returned by fill_inline_data() when filling
> last page in fill_inode(). If not getting inode will be successful even
> though last page is bad. That is illogical. Also change -EAGAIN to 0 in
> fill_inline_data() to stand for successful filling.
>
> Signed-off-by: Yue Hu <[email protected]>

ditto, add the tags from other guyes.

Thanks,
Gao Xiang

> ---
> drivers/staging/erofs/inode.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/erofs/inode.c b/drivers/staging/erofs/inode.c
> index d6e1e16..1433f25 100644
> --- a/drivers/staging/erofs/inode.c
> +++ b/drivers/staging/erofs/inode.c
> @@ -156,7 +156,7 @@ static int fill_inline_data(struct inode *inode, void *data,
> inode->i_link = lnk;
> set_inode_fast_symlink(inode);
> }
> - return -EAGAIN;
> + return 0;
> }
>
> static int fill_inode(struct inode *inode, int isdir)
> @@ -223,7 +223,7 @@ static int fill_inode(struct inode *inode, int isdir)
> inode->i_mapping->a_ops = &erofs_raw_access_aops;
>
> /* fill last page if inline data is available */
> - fill_inline_data(inode, data, ofs);
> + err = fill_inline_data(inode, data, ofs);
> }
>
> out_unlock:
>