2019-07-10 02:41:58

by Hariprasad Kelam

Subject: [PATCH] sound: ppc: snd_ps3: Remove Unneeded variable: "ret"

This patch fixes below issue reported by coccicheck
sound/ppc/snd_ps3.c:631:5-8: Unneeded variable: "ret". Return "0" on
line 668

We cannot change return type of snd_ps3_pcm_trigger as it is registered
with snd_pcm_ops->trigger

Signed-off-by: Hariprasad Kelam <[email protected]>
---
sound/ppc/snd_ps3.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/sound/ppc/snd_ps3.c b/sound/ppc/snd_ps3.c
index 71b7fd3..c213eb7 100644
--- a/sound/ppc/snd_ps3.c
+++ b/sound/ppc/snd_ps3.c
@@ -628,7 +628,6 @@ static int snd_ps3_pcm_trigger(struct snd_pcm_substream *substream,
int cmd)
{
struct snd_ps3_card_info *card = snd_pcm_substream_chip(substream);
- int ret = 0;

switch (cmd) {
case SNDRV_PCM_TRIGGER_START:
@@ -665,7 +664,7 @@ static int snd_ps3_pcm_trigger(struct snd_pcm_substream *substream,

}

- return ret;
+ return 0;
};

/*
--
2.7.4

2019-07-10 10:10:42

by Takashi Iwai

Subject: Re: [PATCH] sound: ppc: snd_ps3: Remove Unneeded variable: "ret"

On Wed, 10 Jul 2019 04:39:46 +0200,
Hariprasad Kelam wrote:
>
> This patch fixes below issue reported by coccicheck
> sound/ppc/snd_ps3.c:631:5-8: Unneeded variable: "ret". Return "0" on
> line 668
>
> We cannot change return type of snd_ps3_pcm_trigger as it is registered
> with snd_pcm_ops->trigger
>
> Signed-off-by: Hariprasad Kelam <[email protected]>

Applied (with the correction of the description again).


thanks,

Takashi