2019-07-30 16:43:18

by Guenter Roeck

[permalink] [raw]
Subject: Re: [PATCH] h8300: Add missing symbol "BOOT_LINK_OFFSET"

On Wed, Jul 17, 2019 at 10:55:00PM +0900, Yoshinori Sato wrote:
> Signed-off-by: Yoshinori Sato <[email protected]>
> ---
> arch/h8300/Kconfig | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/arch/h8300/Kconfig b/arch/h8300/Kconfig
> index ecfc4b4b6373..6974513b1ae9 100644
> --- a/arch/h8300/Kconfig
> +++ b/arch/h8300/Kconfig
> @@ -45,4 +45,7 @@ config NR_CPUS
> int
> default 1
>
> +config BOOT_LINK_OFFSET
> + hex "zImage link offset"
> +

"hex" requires a default value. The above declaration generates
"CONFIG_BOOT_LINK_OFFSET=" in the configuration file, which is invalid
and can not be fixed with "make ARCH=h8300 olddefconfig". This in turn
results in "make" requesting a value when it encounters the symbol,
meaning that automated builds of h8300 images are no longer possible,
at least not without workarounds.

Guenter


2019-08-13 10:22:55

by Yoshinori Sato

[permalink] [raw]
Subject: Re: [PATCH] h8300: Add missing symbol "BOOT_LINK_OFFSET"

On Wed, 31 Jul 2019 00:49:06 +0900,
Guenter Roeck wrote:
>
> On Wed, Jul 17, 2019 at 10:55:00PM +0900, Yoshinori Sato wrote:
> > Signed-off-by: Yoshinori Sato <[email protected]>
> > ---
> > arch/h8300/Kconfig | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/arch/h8300/Kconfig b/arch/h8300/Kconfig
> > index ecfc4b4b6373..6974513b1ae9 100644
> > --- a/arch/h8300/Kconfig
> > +++ b/arch/h8300/Kconfig
> > @@ -45,4 +45,7 @@ config NR_CPUS
> > int
> > default 1
> >
> > +config BOOT_LINK_OFFSET
> > + hex "zImage link offset"
> > +
>
> "hex" requires a default value. The above declaration generates
> "CONFIG_BOOT_LINK_OFFSET=" in the configuration file, which is invalid
> and can not be fixed with "make ARCH=h8300 olddefconfig". This in turn
> results in "make" requesting a value when it encounters the symbol,
> meaning that automated builds of h8300 images are no longer possible,
> at least not without workarounds.
>
> Guenter

Sorry too late reply.
OK fixed it.

Thanks your comment.

--
Yosinori Sato