2019-07-31 05:59:46

by John Hubbard

Subject: [PATCH v2 0/1] x86/boot: save fields explicitly, zero out everything else

From: John Hubbard <[email protected]>

Hi,

This uses the "save each field explicitly" approach that we discussed
during the first review [1]. As in [1], this is motivated by a desire
to clear the compiler warnings when building with gcc 9.

This is difficult to properly test. I've done a basic boot test, but
if there are actually errors in which items get zeroed or not, I don't
have a good test to uncover that.

[1] https://lore.kernel.org/r/[email protected]

John Hubbard (1):
x86/boot: save fields explicitly, zero out everything else

arch/x86/include/asm/bootparam_utils.h | 62 +++++++++++++++++++-------
1 file changed, 47 insertions(+), 15 deletions(-)

--
2.22.0

2019-08-05 20:28:59

by John Hubbard

Subject: Re: [PATCH v2 0/1] x86/boot: save fields explicitly, zero out everything else

On 7/30/19 10:46 PM, [email protected] wrote:
> From: John Hubbard <[email protected]>
>
> Hi,
>
> This uses the "save each field explicitly" approach that we discussed
> during the first review [1]. As in [1], this is motivated by a desire
> to clear the compiler warnings when building with gcc 9.
>
> This is difficult to properly test. I've done a basic boot test, but
> if there are actually errors in which items get zeroed or not, I don't
> have a good test to uncover that.


Also, if anyone has advice about any extra testing I could run on this,
please send it my way.

thanks,
--
John Hubbard
NVIDIA

>
> [1] https://lore.kernel.org/r/[email protected]
>
> John Hubbard (1):
> x86/boot: save fields explicitly, zero out everything else
>
> arch/x86/include/asm/bootparam_utils.h | 62 +++++++++++++++++++-------
> 1 file changed, 47 insertions(+), 15 deletions(-)
>