2019-08-02 02:31:43

by John Hubbard

Subject: [PATCH] fs/ceph: don't return a value from void function

From: John Hubbard <[email protected]>

This fixes a build warning to that effect.

Signed-off-by: John Hubbard <[email protected]>
---

Hi,

I ran into this while working on unrelated changes, to
convert ceph over to put_user_page().

This patch is against the latest linux.git.

thanks,
John Hubbard
NVIDIA


fs/ceph/debugfs.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/fs/ceph/debugfs.c b/fs/ceph/debugfs.c
index 2eb88ed22993..facb387c2735 100644
--- a/fs/ceph/debugfs.c
+++ b/fs/ceph/debugfs.c
@@ -294,7 +294,6 @@ void ceph_fs_debugfs_init(struct ceph_fs_client *fsc)

void ceph_fs_debugfs_init(struct ceph_fs_client *fsc)
{
- return 0;
}

void ceph_fs_debugfs_cleanup(struct ceph_fs_client *fsc)
--
2.22.0

2019-08-03 15:26:31

by Jeff Layton

Subject: Re: [PATCH] fs/ceph: don't return a value from void function

On Thu, 2019-08-01 at 18:06 -0700, [email protected] wrote:
> From: John Hubbard <[email protected]>
>
> This fixes a build warning to that effect.
>
> Signed-off-by: John Hubbard <[email protected]>
> ---
>
> Hi,
>
> I ran into this while working on unrelated changes, to
> convert ceph over to put_user_page().
>
> This patch is against the latest linux.git.
>
> thanks,
> John Hubbard
> NVIDIA
>
>
> fs/ceph/debugfs.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/fs/ceph/debugfs.c b/fs/ceph/debugfs.c
> index 2eb88ed22993..facb387c2735 100644
> --- a/fs/ceph/debugfs.c
> +++ b/fs/ceph/debugfs.c
> @@ -294,7 +294,6 @@ void ceph_fs_debugfs_init(struct ceph_fs_client *fsc)
>
> void ceph_fs_debugfs_init(struct ceph_fs_client *fsc)
> {
> - return 0;
> }
>
> void ceph_fs_debugfs_cleanup(struct ceph_fs_client *fsc)

Thanks. Merged into ceph-client/testing branch, we'll see about getting
this to Linus before v5.3 ships.
--
Jeff Layton <[email protected]>