Subject: [PATCH] isdn: hysdn: fix code style error from checkpatch

Fix error bellow from checkpatch.

WARNING: Block comments use * on subsequent lines
+/***********************************************************
+

Signed-off-by: Ricardo Bruno Lopes da Silva <[email protected]>
---
Hi! This is my first patch, I am learning how to contribute to Linux
kernel. Let me know if you have any suggestions.

Thanks,
Ricardo Bruno

drivers/staging/isdn/hysdn/hycapi.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/staging/isdn/hysdn/hycapi.c b/drivers/staging/isdn/hysdn/hycapi.c
index a2c15cd7b..b7ba28d40 100644
--- a/drivers/staging/isdn/hysdn/hycapi.c
+++ b/drivers/staging/isdn/hysdn/hycapi.c
@@ -107,11 +107,8 @@ hycapi_remove_ctr(struct capi_ctr *ctrl)
card->hyctrlinfo = NULL;
}

-/***********************************************************
-
-Queue a CAPI-message to the controller.
+/* Queue a CAPI-message to the controller. */

-***********************************************************/

static void
hycapi_sendmsg_internal(struct capi_ctr *ctrl, struct sk_buff *skb)
--
2.20.1


2019-08-04 03:04:57

by Stephen Hemminger

[permalink] [raw]
Subject: Re: [PATCH] isdn: hysdn: fix code style error from checkpatch

On Fri, 2 Aug 2019 19:50:17 +0000
Ricardo Bruno Lopes da Silva <[email protected]> wrote:

> Fix error bellow from checkpatch.
>
> WARNING: Block comments use * on subsequent lines
> +/***********************************************************
> +
>
> Signed-off-by: Ricardo Bruno Lopes da Silva <[email protected]>

Read the TODO, these drivers are scheduled for removal, so changes
are not helpful at this time.

2019-08-05 18:54:09

by Helen Koike

[permalink] [raw]
Subject: Re: [Lkcamp] [PATCH] isdn: hysdn: fix code style error from checkpatch

Hi,

On Fri, Aug 2, 2019 at 6:55 PM Stephen Hemminger
<[email protected]> wrote:
>
> On Fri, 2 Aug 2019 19:50:17 +0000
> Ricardo Bruno Lopes da Silva <[email protected]> wrote:
>
> > Fix error bellow from checkpatch.
> >
> > WARNING: Block comments use * on subsequent lines
> > +/***********************************************************
> > +
> >
> > Signed-off-by: Ricardo Bruno Lopes da Silva <[email protected]>
>
> Read the TODO, these drivers are scheduled for removal, so changes
> are not helpful at this time.

I'm sorry, it was me who suggested Ricardo to make this change
as his first contribution, I didn't see the TODO file.

Ricardo, it would be great if you could send a patch to another staging driver
to get starting and to learn how the kernel development cycle works.
Feel free to ping me or the lkcamp group if you want some pointers/guidance.

Thanks both for your contribution.
Helen

>
> _______________________________________________
> Lkcamp mailing list
> [email protected]
> https://lists.libreplanetbr.org/mailman/listinfo/lkcamp