2019-08-14 11:17:54

by Anders Roxell

Subject: [PATCH] selftests: livepatch: add missing fragments to config

When generating config with 'make defconfig kselftest-merge' fragment
CONFIG_TEST_LIVEPATCH=m isn't set.

Rework to enable CONFIG_LIVEPATCH and CONFIG_DYNAMIC_DEBUG as well.

Signed-off-by: Anders Roxell <[email protected]>
---
tools/testing/selftests/livepatch/config | 2 ++
1 file changed, 2 insertions(+)

diff --git a/tools/testing/selftests/livepatch/config b/tools/testing/selftests/livepatch/config
index 0dd7700464a8..ad23100cb27c 100644
--- a/tools/testing/selftests/livepatch/config
+++ b/tools/testing/selftests/livepatch/config
@@ -1 +1,3 @@
+CONFIG_LIVEPATCH=y
+CONFIG_DYNAMIC_DEBUG=y
CONFIG_TEST_LIVEPATCH=m
--
2.20.1

2019-08-14 13:22:39

by Joe Lawrence

Subject: Re: [PATCH] selftests: livepatch: add missing fragments to config

On 8/14/19 7:16 AM, Anders Roxell wrote:
> When generating config with 'make defconfig kselftest-merge' fragment
> CONFIG_TEST_LIVEPATCH=m isn't set.
>
> Rework to enable CONFIG_LIVEPATCH and CONFIG_DYNAMIC_DEBUG as well.
>
> Signed-off-by: Anders Roxell <[email protected]>
> ---
> tools/testing/selftests/livepatch/config | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/tools/testing/selftests/livepatch/config b/tools/testing/selftests/livepatch/config
> index 0dd7700464a8..ad23100cb27c 100644
> --- a/tools/testing/selftests/livepatch/config
> +++ b/tools/testing/selftests/livepatch/config
> @@ -1 +1,3 @@
> +CONFIG_LIVEPATCH=y
> +CONFIG_DYNAMIC_DEBUG=y
> CONFIG_TEST_LIVEPATCH=m
>

Cool, I didn't know about that make target when doing commit
bae054372aba ("selftests/livepatch: add DYNAMIC_DEBUG config dependency")

How does kselftest-merge verify dependencies?

CONFIG_LIVEPATCH has its own list of configuration dependencies (see
kernel/livepatch/Kconfig) but we don't list all of those in this config
file. Just curious.

Thanks,

-- Joe