2019-08-27 00:33:28

by Ben Chuang

[permalink] [raw]
Subject: [PATCH V6 0/5] Add Genesys Logic GL975x support

From: Ben Chuang <[email protected]>

The patches modify internal clock setup to match SD Host Controller
Simplified Specifications 4.20 and support Genesys Logic GL9750/GL9755 chipsets.

V6:
- export sdhci_abot_tuning() function symbol
- use C-style comments
- use BIT, FIELD_{GET,PREP} and GENMASK to define bit fields of register
- use host->ops->platform_execute_tuning instead of mmc->ops->execute_tuning
- call sdhci_reset() instead of duplicating the code in sdhci_gl9750_reset
- remove .hw_reset
- use condition define CONFIG_MMC_SDHCI_IO_ACCESSORS for read_l

V5:
- add "change timeout of loop .." to a patch
- fix typo "verndor" to "vendor"

V4:
- change name from sdhci_gli_reset to sdhci_gl9750_reset
- fix sdhci_reset to sdhci_gl9750_reset in sdhci_gl9750_ops
- fix sdhci_gli_reset to sdhci_reset in sdhci_gl9755_ops

V3:
- change usleep_range to udelay
- add Genesys Logic PCI Vendor ID to a patch
- separate the Genesys Logic specific part to a patch

V2:
- change udelay to usleep_range

Ben Chuang (5):
mmc: sdhci: Change timeout of loop for checking internal clock stable
mmc: sdhci: Add PLL Enable support to internal clock setup
PCI: Add Genesys Logic, Inc. Vendor ID
mmc: sdhci: Export sdhci_abort_tuning function symbol
mmc: host: sdhci-pci: Add Genesys Logic GL975x support

drivers/mmc/host/Makefile | 2 +-
drivers/mmc/host/sdhci-pci-core.c | 2 +
drivers/mmc/host/sdhci-pci-gli.c | 354 ++++++++++++++++++++++++++++++
drivers/mmc/host/sdhci-pci.h | 5 +
drivers/mmc/host/sdhci.c | 30 ++-
drivers/mmc/host/sdhci.h | 2 +
include/linux/pci_ids.h | 2 +
7 files changed, 393 insertions(+), 4 deletions(-)
create mode 100644 drivers/mmc/host/sdhci-pci-gli.c

--
2.22.1


2019-08-29 13:35:43

by Ulf Hansson

[permalink] [raw]
Subject: Re: [PATCH V6 0/5] Add Genesys Logic GL975x support

On Tue, 27 Aug 2019 at 02:32, Ben Chuang <[email protected]> wrote:
>
> From: Ben Chuang <[email protected]>
>
> The patches modify internal clock setup to match SD Host Controller
> Simplified Specifications 4.20 and support Genesys Logic GL9750/GL9755 chipsets.
>
> V6:
> - export sdhci_abot_tuning() function symbol
> - use C-style comments
> - use BIT, FIELD_{GET,PREP} and GENMASK to define bit fields of register
> - use host->ops->platform_execute_tuning instead of mmc->ops->execute_tuning
> - call sdhci_reset() instead of duplicating the code in sdhci_gl9750_reset
> - remove .hw_reset
> - use condition define CONFIG_MMC_SDHCI_IO_ACCESSORS for read_l

Applied patch 1-4, deferring patch5 for another version to fix Adrian's comment.

Kind regards
Uffe

2019-08-30 01:26:19

by Ben Chuang

[permalink] [raw]
Subject: Re: [PATCH V6 0/5] Add Genesys Logic GL975x support

On Thu, Aug 29, 2019 at 9:34 PM Ulf Hansson <[email protected]> wrote:
>
> On Tue, 27 Aug 2019 at 02:32, Ben Chuang <[email protected]> wrote:
> >
> > From: Ben Chuang <[email protected]>
> >
> > The patches modify internal clock setup to match SD Host Controller
> > Simplified Specifications 4.20 and support Genesys Logic GL9750/GL9755 chipsets.
> >
> > V6:
> > - export sdhci_abot_tuning() function symbol
> > - use C-style comments
> > - use BIT, FIELD_{GET,PREP} and GENMASK to define bit fields of register
> > - use host->ops->platform_execute_tuning instead of mmc->ops->execute_tuning
> > - call sdhci_reset() instead of duplicating the code in sdhci_gl9750_reset
> > - remove .hw_reset
> > - use condition define CONFIG_MMC_SDHCI_IO_ACCESSORS for read_l
>
> Applied patch 1-4, deferring patch5 for another version to fix Adrian's comment.
>
> Kind regards
> Uffe

Hi, Uffe,

So happy to get the good news.
Thank you and Adrian for reviewing and helping.

Sincerely yours,
Ben Chuang