2019-08-30 13:15:01

by Krzysztof Wilczyński

Subject: [PATCH] unicode: Move static keyword to the front of declarations

Move the static keyword to the front of declarations of nfdi_test_data
and nfdicf_test_data, and resolve the following compiler warnings that
can be seen when building with warnings enabled (W=1):

fs/unicode/utf8-selftest.c:38:1: warning:
‘static’ is not at beginning of declaration [-Wold-style-declaration]

fs/unicode/utf8-selftest.c:92:1: warning:
‘static’ is not at beginning of declaration [-Wold-style-declaration]

Signed-off-by: Krzysztof Wilczynski <[email protected]>
---
Related: https://lore.kernel.org/r/[email protected]

fs/unicode/utf8-selftest.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/fs/unicode/utf8-selftest.c b/fs/unicode/utf8-selftest.c
index 6c1a36bbf6ad..6fe8af7edccb 100644
--- a/fs/unicode/utf8-selftest.c
+++ b/fs/unicode/utf8-selftest.c
@@ -35,7 +35,7 @@ unsigned int total_tests;
#define test_f(cond, fmt, ...) _test(cond, __func__, __LINE__, fmt, ##__VA_ARGS__)
#define test(cond) _test(cond, __func__, __LINE__, "")

-const static struct {
+static const struct {
/* UTF-8 strings in this vector _must_ be NULL-terminated. */
unsigned char str[10];
unsigned char dec[10];
@@ -89,7 +89,7 @@ const static struct {

};

-const static struct {
+static const struct {
/* UTF-8 strings in this vector _must_ be NULL-terminated. */
unsigned char str[30];
unsigned char ncf[30];
--
2.22.1

2019-09-03 19:54:31

by Gabriel Krisman Bertazi

Subject: Re: [PATCH] unicode: Move static keyword to the front of declarations

Krzysztof Wilczynski <[email protected]> writes:

> Move the static keyword to the front of declarations of nfdi_test_data
> and nfdicf_test_data, and resolve the following compiler warnings that
> can be seen when building with warnings enabled (W=1):
>
> fs/unicode/utf8-selftest.c:38:1: warning:
> ‘static’ is not at beginning of declaration [-Wold-style-declaration]
>
> fs/unicode/utf8-selftest.c:92:1: warning:
> ‘static’ is not at beginning of declaration [-Wold-style-declaration]
>

Applied.

Thanks,

--
Gabriel Krisman Bertazi