2019-09-09 18:32:03

by Austin Kim

Subject: [PATCH] scsi: dpt_i2o: drop unnecessary comparison statement

The type of 'chan' is u32 which contain non-negative value.
So 'chan < 0' is statment is always false.

Remove unnecessary comparison statement

Signed-off-by: Austin Kim <[email protected]>
---
drivers/scsi/dpt_i2o.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/dpt_i2o.c b/drivers/scsi/dpt_i2o.c
index abc74fd..df48ef5 100644
--- a/drivers/scsi/dpt_i2o.c
+++ b/drivers/scsi/dpt_i2o.c
@@ -1120,7 +1120,7 @@ static struct adpt_device* adpt_find_device(adpt_hba* pHba, u32 chan, u32 id, u6
{
struct adpt_device* d;

- if(chan < 0 || chan >= MAX_CHANNEL)
+ if(chan >= MAX_CHANNEL)
return NULL;

d = pHba->channel[chan].device[id];
--
2.6.2

2019-09-10 13:00:37

by Austin Kim

Subject: Re: [PATCH] scsi: dpt_i2o: drop unnecessary comparison statement

Hello, Maintainers...
Would you please review this patch and share the feedback?

Thanks,
Austin Kim

2019년 9월 9일 (월) 오후 2:42, Austin Kim <[email protected]>님이 작성:
>
> The type of 'chan' is u32 which contain non-negative value.
> So 'chan < 0' is statment is always false.
>
> Remove unnecessary comparison statement
>
> Signed-off-by: Austin Kim <[email protected]>
> ---
> drivers/scsi/dpt_i2o.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/dpt_i2o.c b/drivers/scsi/dpt_i2o.c
> index abc74fd..df48ef5 100644
> --- a/drivers/scsi/dpt_i2o.c
> +++ b/drivers/scsi/dpt_i2o.c
> @@ -1120,7 +1120,7 @@ static struct adpt_device* adpt_find_device(adpt_hba* pHba, u32 chan, u32 id, u6
> {
> struct adpt_device* d;
>
> - if(chan < 0 || chan >= MAX_CHANNEL)
> + if(chan >= MAX_CHANNEL)
> return NULL;
>
> d = pHba->channel[chan].device[id];
> --
> 2.6.2
>