2019-09-23 19:09:24

by Changbin Du

Subject: [PATCH v2 0/2] perf: add support for logging debug messages to file

When in TUI mode, it is impossible to show all the debug messages to
console. This make it hard to debug perf issues using debug messages.
This patch adds support for logging debug messages to file to resolve
this problem.

v2:
o specific all debug options one time.

Changbin Du (2):
perf: support multiple debug options separated by ','
perf: add support for logging debug messages to file

tools/perf/Documentation/perf.txt | 14 ++--
tools/perf/util/debug.c | 106 ++++++++++++++++++------------
2 files changed, 73 insertions(+), 47 deletions(-)

--
2.20.1

2019-09-29 07:45:55

by Jiri Olsa

Subject: Re: [PATCH v2 0/2] perf: add support for logging debug messages to file

On Sun, Sep 22, 2019 at 10:38:21AM +0800, Changbin Du wrote:
> When in TUI mode, it is impossible to show all the debug messages to
> console. This make it hard to debug perf issues using debug messages.
> This patch adds support for logging debug messages to file to resolve
> this problem.
>
> v2:
> o specific all debug options one time.
>
> Changbin Du (2):
> perf: support multiple debug options separated by ','
> perf: add support for logging debug messages to file

hi,
getting segfault with:

[jolsa@krava perf]$ ./perf --debug verbose=2,file report
build id event received for [kernel.kallsyms]: bf6ca14c03795fd67b4d88113681ba4af2b8c18a
Segmentation fault (core dumped)

jirka

>
> tools/perf/Documentation/perf.txt | 14 ++--
> tools/perf/util/debug.c | 106 ++++++++++++++++++------------
> 2 files changed, 73 insertions(+), 47 deletions(-)
>
> --
> 2.20.1
>

2019-10-04 08:00:42

by Changbin Du

Subject: Re: [PATCH v2 0/2] perf: add support for logging debug messages to file

On Sun, Sep 29, 2019 at 09:44:07AM +0200, Jiri Olsa wrote:
> On Sun, Sep 22, 2019 at 10:38:21AM +0800, Changbin Du wrote:
> > When in TUI mode, it is impossible to show all the debug messages to
> > console. This make it hard to debug perf issues using debug messages.
> > This patch adds support for logging debug messages to file to resolve
> > this problem.
> >
> > v2:
> > o specific all debug options one time.
> >
> > Changbin Du (2):
> > perf: support multiple debug options separated by ','
> > perf: add support for logging debug messages to file
>
> hi,
> getting segfault with:
>
> [jolsa@krava perf]$ ./perf --debug verbose=2,file report
> build id event received for [kernel.kallsyms]: bf6ca14c03795fd67b4d88113681ba4af2b8c18a
> Segmentation fault (core dumped)
>
Hmm, this because the va_list variable cannot be used twice. I resolve this by
making stderr and file options exclusive.

> jirka
>
> >
> > tools/perf/Documentation/perf.txt | 14 ++--
> > tools/perf/util/debug.c | 106 ++++++++++++++++++------------
> > 2 files changed, 73 insertions(+), 47 deletions(-)
> >
> > --
> > 2.20.1
> >

--
Cheers,
Changbin Du