2019-09-26 04:17:00

by Connor Kuehl

Subject: [PATCH] staging: rtl8188eu: remove dead code in do-while conditional step

The local variable 'bcmd_down' is always set to true almost immediately
before the do-while's condition is checked. As a result, !bcmd_down
evaluates to false which short circuits the logical AND operator meaning
that the second operand is never reached and is therefore dead code.

Addresses-Coverity: ("Logically dead code")

Signed-off-by: Connor Kuehl <[email protected]>
---
drivers/staging/rtl8188eu/hal/rtl8188e_cmd.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_cmd.c b/drivers/staging/rtl8188eu/hal/rtl8188e_cmd.c
index 47352f210c0b..a4b317937b23 100644
--- a/drivers/staging/rtl8188eu/hal/rtl8188e_cmd.c
+++ b/drivers/staging/rtl8188eu/hal/rtl8188e_cmd.c
@@ -48,7 +48,6 @@ static u8 _is_fw_read_cmd_down(struct adapter *adapt, u8 msgbox_num)
static s32 FillH2CCmd_88E(struct adapter *adapt, u8 ElementID, u32 CmdLen, u8 *pCmdBuffer)
{
u8 bcmd_down = false;
- s32 retry_cnts = 100;
u8 h2c_box_num;
u32 msgbox_addr;
u32 msgbox_ex_addr;
@@ -103,7 +102,7 @@ static s32 FillH2CCmd_88E(struct adapter *adapt, u8 ElementID, u32 CmdLen, u8 *p
adapt->HalData->LastHMEBoxNum =
(h2c_box_num+1) % RTL88E_MAX_H2C_BOX_NUMS;

- } while ((!bcmd_down) && (retry_cnts--));
+ } while (!bcmd_down);

ret = _SUCCESS;

--
2.17.1

2019-09-26 08:15:00

by Connor Kuehl

Subject: NACK: [PATCH] staging: rtl8188eu: remove dead code in do-while conditional step

I'm sending a V2 with the loop removed.

Thanks,

Connor

2019-09-26 08:17:56

by Dan Carpenter

Subject: Re: NACK: [PATCH] staging: rtl8188eu: remove dead code in do-while conditional step

This email is fine, but I just want to make sure that you don't think
it's required. We all assumed that you would send a v2. I sort of hate
the word NACK as well because it sounds like shouting or ducks and those
are my two pet peeves.

Sometimes people send a v2 patch without any replies to the original
email and we apply the v1 patch that's the only thing to avoid.

regards,
dan carpenter