2019-10-10 08:03:16

by Fuqian Huang

Subject: [PATCH] mtd: maps: l440gx: Avoid print address to dmesg

Avoid print the address of l440gx_map.virt every time l440gx init.

Signed-off-by: Fuqian Huang <[email protected]>
---
drivers/mtd/maps/l440gx.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/mtd/maps/l440gx.c b/drivers/mtd/maps/l440gx.c
index 876f12f40018..e7e40bca82d1 100644
--- a/drivers/mtd/maps/l440gx.c
+++ b/drivers/mtd/maps/l440gx.c
@@ -86,7 +86,6 @@ static int __init init_l440gx(void)
return -ENOMEM;
}
simple_map_init(&l440gx_map);
- printk(KERN_NOTICE "window_addr = 0x%08lx\n", (unsigned long)l440gx_map.virt);

/* Setup the pm iobase resource
* This code should move into some kind of generic bridge
--
2.11.0

2019-10-10 08:28:39

by Miquel Raynal

Subject: Re: [PATCH] mtd: maps: l440gx: Avoid print address to dmesg

Hi Fuqian,

Fuqian Huang <[email protected]> wrote on Thu, 10 Oct 2019
16:01:30 +0800:

> Avoid print the address of l440gx_map.virt every time l440gx init.
>
> Signed-off-by: Fuqian Huang <[email protected]>
> ---
> drivers/mtd/maps/l440gx.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/mtd/maps/l440gx.c b/drivers/mtd/maps/l440gx.c
> index 876f12f40018..e7e40bca82d1 100644
> --- a/drivers/mtd/maps/l440gx.c
> +++ b/drivers/mtd/maps/l440gx.c
> @@ -86,7 +86,6 @@ static int __init init_l440gx(void)
> return -ENOMEM;
> }
> simple_map_init(&l440gx_map);
> - printk(KERN_NOTICE "window_addr = 0x%08lx\n", (unsigned long)l440gx_map.virt);
>
> /* Setup the pm iobase resource
> * This code should move into some kind of generic bridge


It looks more like a debug message, maybe turn it into a KERN_DEBUG?
Usually people do not run their kernels with such a low trace limit.

Thanks,
Miquèl