by Sam Ravnborg

[permalink] [raw]

Subject: Re: [PATCH v7 8/8] drm/panel: support for auo,b101uan08.3 wuxga dsi video mode panel

Hi Jitao.

Looks good.

On Sat, Oct 12, 2019 at 11:07:20AM +0800, Jitao Shi wrote:
> Auo,auo,b101uan08.3's connector is same as boe,tv101wum-nl6.
> The most codes can be reuse.
> So auo,b101uan08.3 and boe,tv101wum-nl6 use one driver file.
> Add the different parts in driver data.
>
> Signed-off-by: Jitao Shi <[email protected]>
Reviewed-by: Sam Ravnborg <[email protected]>

> ---
> .../gpu/drm/panel/panel-boe-tv101wum-nl6.c | 78 +++++++++++++++++++
> 1 file changed, 78 insertions(+)
>
> diff --git a/drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c b/drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c
> index 7b47619675f5..e2496a334ab6 100644
> --- a/drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c
> +++ b/drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c
> @@ -382,6 +382,53 @@ static const struct panel_init_cmd auo_kd101n80_45na_init_cmd[] = {
> {},
> };
>
> +static const struct panel_init_cmd auo_b101uan08_3_init_cmd[] = {
> + _INIT_DELAY_CMD(24),
> + _INIT_DCS_CMD(0xB0, 0x01),
> + _INIT_DCS_CMD(0xC0, 0x48),
> + _INIT_DCS_CMD(0xC1, 0x48),
> + _INIT_DCS_CMD(0xC2, 0x47),
> + _INIT_DCS_CMD(0xC3, 0x47),
> + _INIT_DCS_CMD(0xC4, 0x46),
> + _INIT_DCS_CMD(0xC5, 0x46),
> + _INIT_DCS_CMD(0xC6, 0x45),
> + _INIT_DCS_CMD(0xC7, 0x45),
> + _INIT_DCS_CMD(0xC8, 0x64),
> + _INIT_DCS_CMD(0xC9, 0x64),
> + _INIT_DCS_CMD(0xCA, 0x4F),
> + _INIT_DCS_CMD(0xCB, 0x4F),
> + _INIT_DCS_CMD(0xCC, 0x40),
> + _INIT_DCS_CMD(0xCD, 0x40),
> + _INIT_DCS_CMD(0xCE, 0x66),
> + _INIT_DCS_CMD(0xCF, 0x66),
> + _INIT_DCS_CMD(0xD0, 0x4F),
> + _INIT_DCS_CMD(0xD1, 0x4F),
> + _INIT_DCS_CMD(0xD2, 0x41),
> + _INIT_DCS_CMD(0xD3, 0x41),
> + _INIT_DCS_CMD(0xD4, 0x48),
> + _INIT_DCS_CMD(0xD5, 0x48),
> + _INIT_DCS_CMD(0xD6, 0x47),
> + _INIT_DCS_CMD(0xD7, 0x47),
> + _INIT_DCS_CMD(0xD8, 0x46),
> + _INIT_DCS_CMD(0xD9, 0x46),
> + _INIT_DCS_CMD(0xDA, 0x45),
> + _INIT_DCS_CMD(0xDB, 0x45),
> + _INIT_DCS_CMD(0xDC, 0x64),
> + _INIT_DCS_CMD(0xDD, 0x64),
> + _INIT_DCS_CMD(0xDE, 0x4F),
> + _INIT_DCS_CMD(0xDF, 0x4F),
> + _INIT_DCS_CMD(0xE0, 0x40),
> + _INIT_DCS_CMD(0xE1, 0x40),
> + _INIT_DCS_CMD(0xE2, 0x66),
> + _INIT_DCS_CMD(0xE3, 0x66),
> + _INIT_DCS_CMD(0xE4, 0x4F),
> + _INIT_DCS_CMD(0xE5, 0x4F),
> + _INIT_DCS_CMD(0xE6, 0x41),
> + _INIT_DCS_CMD(0xE7, 0x41),
> + _INIT_DELAY_CMD(150),
> + {},
> +};
> +
> static inline struct boe_panel *to_boe_panel(struct drm_panel *panel)
> {
> return container_of(panel, struct boe_panel, base);
> @@ -652,6 +699,34 @@ static const struct panel_desc boe_tv101wum_n53_desc = {
> .init_cmds = boe_init_cmd,
> };
>
> +static const struct drm_display_mode auo_b101uan08_3_default_mode = {
> + .clock = 159667,
> + .hdisplay = 1200,
> + .hsync_start = 1200 + 60,
> + .hsync_end = 1200 + 60 + 4,
> + .htotal = 1200 + 60 + 4 + 80,
> + .vdisplay = 1920,
> + .vsync_start = 1920 + 34,
> + .vsync_end = 1920 + 34 + 2,
> + .vtotal = 1920 + 34 + 2 + 24,
> + .vrefresh = 60,
> + .type = DRM_MODE_TYPE_DRIVER | DRM_MODE_TYPE_PREFERRED,
> +};
> +
> +static const struct panel_desc auo_b101uan08_3_desc = {
> + .modes = &auo_b101uan08_3_default_mode,
> + .bpc = 8,
> + .size = {
> + .width_mm = 135,
> + .height_mm = 216,
> + },
> + .lanes = 4,
> + .format = MIPI_DSI_FMT_RGB888,
> + .mode_flags = MIPI_DSI_MODE_VIDEO | MIPI_DSI_MODE_VIDEO_SYNC_PULSE |
> + MIPI_DSI_MODE_LPM,
> + .init_cmds = auo_b101uan08_3_init_cmd,
> +};
> +
> static int boe_panel_get_modes(struct drm_panel *panel)
> {
> struct boe_panel *boe = to_boe_panel(panel);
> @@ -782,6 +857,9 @@ static const struct of_device_id boe_of_match[] = {
> { .compatible = "boe,tv101wum-n53",
> .data = &boe_tv101wum_n53_desc
> },
> + { .compatible = "auo,b101uan08.3",
> + .data = &auo_b101uan08_3_desc
> + },
> { /* sentinel */ }
> };
> MODULE_DEVICE_TABLE(of, boe_of_match);
> --
> 2.21.0