2019-10-12 12:46:40

by Nishad Kamdar

[permalink] [raw]
Subject: [PATCH] net: dsa: sja1105: Use the correct style for SPDX License Identifier

This patch corrects the SPDX License Identifier style
in header files related to Distributed Switch Architecture
drivers for NXP SJA1105 series Ethernet switch support.
For C header files Documentation/process/license-rules.rst
mandates C-like comments (opposed to C source files where
C++ style should be used)

Changes made by using a script provided by Joe Perches here:
https://lkml.org/lkml/2019/2/7/46.

Suggested-by: Joe Perches <[email protected]>
Signed-off-by: Nishad Kamdar <[email protected]>
---
drivers/net/dsa/sja1105/sja1105.h | 4 ++--
drivers/net/dsa/sja1105/sja1105_dynamic_config.h | 4 ++--
drivers/net/dsa/sja1105/sja1105_ptp.h | 4 ++--
drivers/net/dsa/sja1105/sja1105_static_config.h | 4 ++--
drivers/net/dsa/sja1105/sja1105_tas.h | 4 ++--
5 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/drivers/net/dsa/sja1105/sja1105.h b/drivers/net/dsa/sja1105/sja1105.h
index 8681ff9d1a76..fb7a6fff643f 100644
--- a/drivers/net/dsa/sja1105/sja1105.h
+++ b/drivers/net/dsa/sja1105/sja1105.h
@@ -1,5 +1,5 @@
-/* SPDX-License-Identifier: GPL-2.0
- * Copyright (c) 2018, Sensor-Technik Wiedemann GmbH
+/* SPDX-License-Identifier: GPL-2.0 */
+/* Copyright (c) 2018, Sensor-Technik Wiedemann GmbH
* Copyright (c) 2018-2019, Vladimir Oltean <[email protected]>
*/
#ifndef _SJA1105_H
diff --git a/drivers/net/dsa/sja1105/sja1105_dynamic_config.h b/drivers/net/dsa/sja1105/sja1105_dynamic_config.h
index 740dadf43f01..4f64adb2d26a 100644
--- a/drivers/net/dsa/sja1105/sja1105_dynamic_config.h
+++ b/drivers/net/dsa/sja1105/sja1105_dynamic_config.h
@@ -1,5 +1,5 @@
-/* SPDX-License-Identifier: GPL-2.0
- * Copyright (c) 2019, Vladimir Oltean <[email protected]>
+/* SPDX-License-Identifier: GPL-2.0 */
+/* Copyright (c) 2019, Vladimir Oltean <[email protected]>
*/
#ifndef _SJA1105_DYNAMIC_CONFIG_H
#define _SJA1105_DYNAMIC_CONFIG_H
diff --git a/drivers/net/dsa/sja1105/sja1105_ptp.h b/drivers/net/dsa/sja1105/sja1105_ptp.h
index af456b0a4d27..c7e598fd1504 100644
--- a/drivers/net/dsa/sja1105/sja1105_ptp.h
+++ b/drivers/net/dsa/sja1105/sja1105_ptp.h
@@ -1,5 +1,5 @@
-/* SPDX-License-Identifier: GPL-2.0
- * Copyright (c) 2019, Vladimir Oltean <[email protected]>
+/* SPDX-License-Identifier: GPL-2.0 */
+/* Copyright (c) 2019, Vladimir Oltean <[email protected]>
*/
#ifndef _SJA1105_PTP_H
#define _SJA1105_PTP_H
diff --git a/drivers/net/dsa/sja1105/sja1105_static_config.h b/drivers/net/dsa/sja1105/sja1105_static_config.h
index 7f87022a2d61..ee66fae6128b 100644
--- a/drivers/net/dsa/sja1105/sja1105_static_config.h
+++ b/drivers/net/dsa/sja1105/sja1105_static_config.h
@@ -1,5 +1,5 @@
-/* SPDX-License-Identifier: BSD-3-Clause
- * Copyright (c) 2016-2018, NXP Semiconductors
+/* SPDX-License-Identifier: BSD-3-Clause */
+/* Copyright (c) 2016-2018, NXP Semiconductors
* Copyright (c) 2018-2019, Vladimir Oltean <[email protected]>
*/
#ifndef _SJA1105_STATIC_CONFIG_H
diff --git a/drivers/net/dsa/sja1105/sja1105_tas.h b/drivers/net/dsa/sja1105/sja1105_tas.h
index 0b803c30e640..c3ea7be52b9c 100644
--- a/drivers/net/dsa/sja1105/sja1105_tas.h
+++ b/drivers/net/dsa/sja1105/sja1105_tas.h
@@ -1,5 +1,5 @@
-/* SPDX-License-Identifier: GPL-2.0
- * Copyright (c) 2019, Vladimir Oltean <[email protected]>
+/* SPDX-License-Identifier: GPL-2.0 */
+/* Copyright (c) 2019, Vladimir Oltean <[email protected]>
*/
#ifndef _SJA1105_TAS_H
#define _SJA1105_TAS_H
--
2.17.1


2019-10-14 10:47:38

by Vladimir Oltean

[permalink] [raw]
Subject: Re: [PATCH] net: dsa: sja1105: Use the correct style for SPDX License Identifier

Hi Nishad,

On Sat, 12 Oct 2019 at 15:39, Nishad Kamdar <[email protected]> wrote:
>
> This patch corrects the SPDX License Identifier style
> in header files related to Distributed Switch Architecture
> drivers for NXP SJA1105 series Ethernet switch support.
> For C header files Documentation/process/license-rules.rst
> mandates C-like comments (opposed to C source files where
> C++ style should be used)
>
> Changes made by using a script provided by Joe Perches here:
> https://lkml.org/lkml/2019/2/7/46.
>
> Suggested-by: Joe Perches <[email protected]>
> Signed-off-by: Nishad Kamdar <[email protected]>
> ---

Your commit message has nothing to do with what you're fixing, but
whatever. The SPDX identifiers _are_ using C-like comments.

Acked-by: Vladimir Oltean <[email protected]>

> drivers/net/dsa/sja1105/sja1105.h | 4 ++--
> drivers/net/dsa/sja1105/sja1105_dynamic_config.h | 4 ++--
> drivers/net/dsa/sja1105/sja1105_ptp.h | 4 ++--
> drivers/net/dsa/sja1105/sja1105_static_config.h | 4 ++--
> drivers/net/dsa/sja1105/sja1105_tas.h | 4 ++--
> 5 files changed, 10 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/net/dsa/sja1105/sja1105.h b/drivers/net/dsa/sja1105/sja1105.h
> index 8681ff9d1a76..fb7a6fff643f 100644
> --- a/drivers/net/dsa/sja1105/sja1105.h
> +++ b/drivers/net/dsa/sja1105/sja1105.h
> @@ -1,5 +1,5 @@
> -/* SPDX-License-Identifier: GPL-2.0
> - * Copyright (c) 2018, Sensor-Technik Wiedemann GmbH
> +/* SPDX-License-Identifier: GPL-2.0 */
> +/* Copyright (c) 2018, Sensor-Technik Wiedemann GmbH
> * Copyright (c) 2018-2019, Vladimir Oltean <[email protected]>
> */
> #ifndef _SJA1105_H
> diff --git a/drivers/net/dsa/sja1105/sja1105_dynamic_config.h b/drivers/net/dsa/sja1105/sja1105_dynamic_config.h
> index 740dadf43f01..4f64adb2d26a 100644
> --- a/drivers/net/dsa/sja1105/sja1105_dynamic_config.h
> +++ b/drivers/net/dsa/sja1105/sja1105_dynamic_config.h
> @@ -1,5 +1,5 @@
> -/* SPDX-License-Identifier: GPL-2.0
> - * Copyright (c) 2019, Vladimir Oltean <[email protected]>
> +/* SPDX-License-Identifier: GPL-2.0 */
> +/* Copyright (c) 2019, Vladimir Oltean <[email protected]>
> */
> #ifndef _SJA1105_DYNAMIC_CONFIG_H
> #define _SJA1105_DYNAMIC_CONFIG_H
> diff --git a/drivers/net/dsa/sja1105/sja1105_ptp.h b/drivers/net/dsa/sja1105/sja1105_ptp.h
> index af456b0a4d27..c7e598fd1504 100644
> --- a/drivers/net/dsa/sja1105/sja1105_ptp.h
> +++ b/drivers/net/dsa/sja1105/sja1105_ptp.h
> @@ -1,5 +1,5 @@
> -/* SPDX-License-Identifier: GPL-2.0
> - * Copyright (c) 2019, Vladimir Oltean <[email protected]>
> +/* SPDX-License-Identifier: GPL-2.0 */
> +/* Copyright (c) 2019, Vladimir Oltean <[email protected]>
> */
> #ifndef _SJA1105_PTP_H
> #define _SJA1105_PTP_H
> diff --git a/drivers/net/dsa/sja1105/sja1105_static_config.h b/drivers/net/dsa/sja1105/sja1105_static_config.h
> index 7f87022a2d61..ee66fae6128b 100644
> --- a/drivers/net/dsa/sja1105/sja1105_static_config.h
> +++ b/drivers/net/dsa/sja1105/sja1105_static_config.h
> @@ -1,5 +1,5 @@
> -/* SPDX-License-Identifier: BSD-3-Clause
> - * Copyright (c) 2016-2018, NXP Semiconductors
> +/* SPDX-License-Identifier: BSD-3-Clause */
> +/* Copyright (c) 2016-2018, NXP Semiconductors
> * Copyright (c) 2018-2019, Vladimir Oltean <[email protected]>
> */
> #ifndef _SJA1105_STATIC_CONFIG_H
> diff --git a/drivers/net/dsa/sja1105/sja1105_tas.h b/drivers/net/dsa/sja1105/sja1105_tas.h
> index 0b803c30e640..c3ea7be52b9c 100644
> --- a/drivers/net/dsa/sja1105/sja1105_tas.h
> +++ b/drivers/net/dsa/sja1105/sja1105_tas.h
> @@ -1,5 +1,5 @@
> -/* SPDX-License-Identifier: GPL-2.0
> - * Copyright (c) 2019, Vladimir Oltean <[email protected]>
> +/* SPDX-License-Identifier: GPL-2.0 */
> +/* Copyright (c) 2019, Vladimir Oltean <[email protected]>
> */
> #ifndef _SJA1105_TAS_H
> #define _SJA1105_TAS_H
> --
> 2.17.1
>

2019-10-14 13:07:15

by Andrew Lunn

[permalink] [raw]
Subject: Re: [PATCH] net: dsa: sja1105: Use the correct style for SPDX License Identifier

On Mon, Oct 14, 2019 at 01:46:26PM +0300, Vladimir Oltean wrote:
> Hi Nishad,
>
> On Sat, 12 Oct 2019 at 15:39, Nishad Kamdar <[email protected]> wrote:
> >
> > This patch corrects the SPDX License Identifier style
> > in header files related to Distributed Switch Architecture
> > drivers for NXP SJA1105 series Ethernet switch support.
> > For C header files Documentation/process/license-rules.rst
> > mandates C-like comments (opposed to C source files where
> > C++ style should be used)
> >
> > Changes made by using a script provided by Joe Perches here:
> > https://lkml.org/lkml/2019/2/7/46.
> >
> > Suggested-by: Joe Perches <[email protected]>
> > Signed-off-by: Nishad Kamdar <[email protected]>
> > ---
>
> Your commit message has nothing to do with what you're fixing, but
> whatever. The SPDX identifiers _are_ using C-like comments.

Agreed. Please fix the commit message, and maybe make the script
generating the commit message, so future uses of it will get the
message correct.

Thanks
Andrew

2019-10-14 16:20:54

by Nishad Kamdar

[permalink] [raw]
Subject: Re: [PATCH] net: dsa: sja1105: Use the correct style for SPDX License Identifier

On Mon, Oct 14, 2019 at 03:00:16PM +0200, Andrew Lunn wrote:
> On Mon, Oct 14, 2019 at 01:46:26PM +0300, Vladimir Oltean wrote:
> > Hi Nishad,
> >
> > On Sat, 12 Oct 2019 at 15:39, Nishad Kamdar <[email protected]> wrote:
> > >
> > > This patch corrects the SPDX License Identifier style
> > > in header files related to Distributed Switch Architecture
> > > drivers for NXP SJA1105 series Ethernet switch support.
> > > For C header files Documentation/process/license-rules.rst
> > > mandates C-like comments (opposed to C source files where
> > > C++ style should be used)
> > >
> > > Changes made by using a script provided by Joe Perches here:
> > > https://lkml.org/lkml/2019/2/7/46.
> > >
> > > Suggested-by: Joe Perches <[email protected]>
> > > Signed-off-by: Nishad Kamdar <[email protected]>
> > > ---
> >
> > Your commit message has nothing to do with what you're fixing, but
> > whatever. The SPDX identifiers _are_ using C-like comments.
>
> Agreed. Please fix the commit message, and maybe make the script
> generating the commit message, so future uses of it will get the
> message correct.
>
> Thanks
> Andrew
Hello Andrew and Vladimir,

I understand your comments.
I will change the commit message in the next version of the patch.

Thanks for the review.

Regards,
Nishad