2019-06-17 16:22:13

by Masahiro Yamada

Subject: [PATCH] libfdt: reduce the number of headers included from libfdt_env.h

Currently, libfdt_env.h includes <linux/kernel.h> just for INT_MAX.

<linux/kernel.h> pulls in a lots of broat.

Thanks to commit 54d50897d544 ("linux/kernel.h: split *_MAX and *_MIN
macros into <linux/limits.h>"), <linux/kernel.h> can be replaced with
<linux/limits.h>.

This saves including dozens of headers.

Signed-off-by: Masahiro Yamada <[email protected]>
---

include/linux/libfdt_env.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/libfdt_env.h b/include/linux/libfdt_env.h
index edb0f0c30904..2231eb855e8f 100644
--- a/include/linux/libfdt_env.h
+++ b/include/linux/libfdt_env.h
@@ -2,7 +2,7 @@
#ifndef LIBFDT_ENV_H
#define LIBFDT_ENV_H

-#include <linux/kernel.h> /* For INT_MAX */
+#include <linux/limits.h> /* For INT_MAX */
#include <linux/string.h>

#include <asm/byteorder.h>
--
2.17.1

2019-08-01 02:51:00

by Masahiro Yamada

Subject: Re: [PATCH] libfdt: reduce the number of headers included from libfdt_env.h

On Tue, Jun 18, 2019 at 1:21 AM Masahiro Yamada
<[email protected]> wrote:
>
> Currently, libfdt_env.h includes <linux/kernel.h> just for INT_MAX.
>
> <linux/kernel.h> pulls in a lots of broat.
>
> Thanks to commit 54d50897d544 ("linux/kernel.h: split *_MAX and *_MIN
> macros into <linux/limits.h>"), <linux/kernel.h> can be replaced with
> <linux/limits.h>.
>
> This saves including dozens of headers.
>
> Signed-off-by: Masahiro Yamada <[email protected]>
> ---

ping?


> include/linux/libfdt_env.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/libfdt_env.h b/include/linux/libfdt_env.h
> index edb0f0c30904..2231eb855e8f 100644
> --- a/include/linux/libfdt_env.h
> +++ b/include/linux/libfdt_env.h
> @@ -2,7 +2,7 @@
> #ifndef LIBFDT_ENV_H
> #define LIBFDT_ENV_H
>
> -#include <linux/kernel.h> /* For INT_MAX */
> +#include <linux/limits.h> /* For INT_MAX */
> #include <linux/string.h>
>
> #include <asm/byteorder.h>
> --
> 2.17.1
>


--
Best Regards
Masahiro Yamada

2019-08-19 04:39:15

by Masahiro Yamada

Subject: Re: [PATCH] libfdt: reduce the number of headers included from libfdt_env.h

On Thu, Aug 1, 2019 at 11:30 AM Masahiro Yamada
<[email protected]> wrote:
>
> On Tue, Jun 18, 2019 at 1:21 AM Masahiro Yamada
> <[email protected]> wrote:
> >
> > Currently, libfdt_env.h includes <linux/kernel.h> just for INT_MAX.
> >
> > <linux/kernel.h> pulls in a lots of broat.
> >
> > Thanks to commit 54d50897d544 ("linux/kernel.h: split *_MAX and *_MIN
> > macros into <linux/limits.h>"), <linux/kernel.h> can be replaced with
> > <linux/limits.h>.
> >
> > This saves including dozens of headers.
> >
> > Signed-off-by: Masahiro Yamada <[email protected]>
> > ---
>
> ping?

ping x2.




>
>
> > include/linux/libfdt_env.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/include/linux/libfdt_env.h b/include/linux/libfdt_env.h
> > index edb0f0c30904..2231eb855e8f 100644
> > --- a/include/linux/libfdt_env.h
> > +++ b/include/linux/libfdt_env.h
> > @@ -2,7 +2,7 @@
> > #ifndef LIBFDT_ENV_H
> > #define LIBFDT_ENV_H
> >
> > -#include <linux/kernel.h> /* For INT_MAX */
> > +#include <linux/limits.h> /* For INT_MAX */
> > #include <linux/string.h>
> >
> > #include <asm/byteorder.h>
> > --
> > 2.17.1
> >
>
>
> --
> Best Regards
> Masahiro Yamada



--
Best Regards
Masahiro Yamada

2019-10-16 14:50:13

by Masahiro Yamada

Subject: Re: [PATCH] libfdt: reduce the number of headers included from libfdt_env.h

Hi Andrew,

Could you pick up this to akpm tree?
https://lore.kernel.org/patchwork/patch/1089856/

I believe this is correct, and a good clean-up.

I pinged the DT maintainers, but they did not respond.

Thanks.




On Mon, Aug 19, 2019 at 1:36 PM Masahiro Yamada
<[email protected]> wrote:
>
> On Thu, Aug 1, 2019 at 11:30 AM Masahiro Yamada
> <[email protected]> wrote:
> >
> > On Tue, Jun 18, 2019 at 1:21 AM Masahiro Yamada
> > <[email protected]> wrote:
> > >
> > > Currently, libfdt_env.h includes <linux/kernel.h> just for INT_MAX.
> > >
> > > <linux/kernel.h> pulls in a lots of broat.
> > >
> > > Thanks to commit 54d50897d544 ("linux/kernel.h: split *_MAX and *_MIN
> > > macros into <linux/limits.h>"), <linux/kernel.h> can be replaced with
> > > <linux/limits.h>.
> > >
> > > This saves including dozens of headers.
> > >
> > > Signed-off-by: Masahiro Yamada <[email protected]>
> > > ---
> >
> > ping?
>
> ping x2.
>
>
>
>
> >
> >
> > > include/linux/libfdt_env.h | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/include/linux/libfdt_env.h b/include/linux/libfdt_env.h
> > > index edb0f0c30904..2231eb855e8f 100644
> > > --- a/include/linux/libfdt_env.h
> > > +++ b/include/linux/libfdt_env.h
> > > @@ -2,7 +2,7 @@
> > > #ifndef LIBFDT_ENV_H
> > > #define LIBFDT_ENV_H
> > >
> > > -#include <linux/kernel.h> /* For INT_MAX */
> > > +#include <linux/limits.h> /* For INT_MAX */
> > > #include <linux/string.h>
> > >
> > > #include <asm/byteorder.h>
> > > --
> > > 2.17.1
> > >
> >
> >
> > --
> > Best Regards
> > Masahiro Yamada
>
>
>
> --
> Best Regards
> Masahiro Yamada



--
Best Regards
Masahiro Yamada

2019-10-18 21:02:20

by Rob Herring (Arm)

Subject: Re: [PATCH] libfdt: reduce the number of headers included from libfdt_env.h

On Wed, Oct 16, 2019 at 08:01:46PM +0900, Masahiro Yamada wrote:
> Hi Andrew,
>
> Could you pick up this to akpm tree?
> https://lore.kernel.org/patchwork/patch/1089856/
>
> I believe this is correct, and a good clean-up.
>
> I pinged the DT maintainers, but they did not respond.

Sorry I missed this. Things outside my normal paths fall thru the
cracks.

I'll apply it now.

Rob

2019-10-18 21:40:15

by Frank Rowand

Subject: Re: [PATCH] libfdt: reduce the number of headers included from libfdt_env.h

On 10/16/2019 06:01, Masahiro Yamada wrote:
> Hi Andrew,
>
> Could you pick up this to akpm tree?
> https://lore.kernel.org/patchwork/patch/1089856/
>
> I believe this is correct, and a good clean-up.
>
> I pinged the DT maintainers, but they did not respond.

Sorry for the delay in responding.

libfdt_env.h is imported from an upstream project, using
the script scripts/dtc/update-dtc-source.sh. Inside
that script are some 'sed' commands to modify the
imported files before committing them. Please add
a sed command to make the change that the proposed
patch makes.

Thanks,

Frank

>
> Thanks.
>
>
>
>
> On Mon, Aug 19, 2019 at 1:36 PM Masahiro Yamada
> <[email protected]> wrote:
>>
>> On Thu, Aug 1, 2019 at 11:30 AM Masahiro Yamada
>> <[email protected]> wrote:
>>>
>>> On Tue, Jun 18, 2019 at 1:21 AM Masahiro Yamada
>>> <[email protected]> wrote:
>>>>
>>>> Currently, libfdt_env.h includes <linux/kernel.h> just for INT_MAX.
>>>>
>>>> <linux/kernel.h> pulls in a lots of broat.
>>>>
>>>> Thanks to commit 54d50897d544 ("linux/kernel.h: split *_MAX and *_MIN
>>>> macros into <linux/limits.h>"), <linux/kernel.h> can be replaced with
>>>> <linux/limits.h>.
>>>>
>>>> This saves including dozens of headers.
>>>>
>>>> Signed-off-by: Masahiro Yamada <[email protected]>
>>>> ---
>>>
>>> ping?
>>
>> ping x2.
>>
>>
>>
>>
>>>
>>>
>>>> include/linux/libfdt_env.h | 2 +-
>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/include/linux/libfdt_env.h b/include/linux/libfdt_env.h
>>>> index edb0f0c30904..2231eb855e8f 100644
>>>> --- a/include/linux/libfdt_env.h
>>>> +++ b/include/linux/libfdt_env.h
>>>> @@ -2,7 +2,7 @@
>>>> #ifndef LIBFDT_ENV_H
>>>> #define LIBFDT_ENV_H
>>>>
>>>> -#include <linux/kernel.h> /* For INT_MAX */
>>>> +#include <linux/limits.h> /* For INT_MAX */
>>>> #include <linux/string.h>
>>>>
>>>> #include <asm/byteorder.h>
>>>> --
>>>> 2.17.1
>>>>
>>>
>>>
>>> --
>>> Best Regards
>>> Masahiro Yamada
>>
>>
>>
>> --
>> Best Regards
>> Masahiro Yamada
>
>
>

2019-10-18 21:41:00

by Frank Rowand

Subject: Re: [PATCH] libfdt: reduce the number of headers included from libfdt_env.h

On 10/17/2019 11:34, Rob Herring wrote:
> On Wed, Oct 16, 2019 at 08:01:46PM +0900, Masahiro Yamada wrote:
>> Hi Andrew,
>>
>> Could you pick up this to akpm tree?
>> https://lore.kernel.org/patchwork/patch/1089856/
>>
>> I believe this is correct, and a good clean-up.
>>
>> I pinged the DT maintainers, but they did not respond.
>
> Sorry I missed this. Things outside my normal paths fall thru the
> cracks.
>
> I'll apply it now.
>
> Rob
>

Looks like my reply crossed with Rob's. Rob, shouldn't
scripts/dtc/update-dtc-source.sh make this change?

-Frank

2019-10-18 22:10:29

by Rob Herring (Arm)

Subject: Re: [PATCH] libfdt: reduce the number of headers included from libfdt_env.h

On Thu, Oct 17, 2019 at 12:25 PM Frank Rowand <[email protected]> wrote:
>
> On 10/17/2019 11:34, Rob Herring wrote:
> > On Wed, Oct 16, 2019 at 08:01:46PM +0900, Masahiro Yamada wrote:
> >> Hi Andrew,
> >>
> >> Could you pick up this to akpm tree?
> >> https://lore.kernel.org/patchwork/patch/1089856/
> >>
> >> I believe this is correct, and a good clean-up.
> >>
> >> I pinged the DT maintainers, but they did not respond.
> >
> > Sorry I missed this. Things outside my normal paths fall thru the
> > cracks.
> >
> > I'll apply it now.
> >
> > Rob
> >
>
> Looks like my reply crossed with Rob's. Rob, shouldn't
> scripts/dtc/update-dtc-source.sh make this change?

No, the includes in include/linux are kernel files which wrap/replace
the upstream ones.

Rob

2019-10-18 22:16:52

by Frank Rowand

Subject: Re: [PATCH] libfdt: reduce the number of headers included from libfdt_env.h

On 10/17/2019 12:52, Rob Herring wrote:
> On Thu, Oct 17, 2019 at 12:25 PM Frank Rowand <[email protected]> wrote:
>>
>> On 10/17/2019 11:34, Rob Herring wrote:
>>> On Wed, Oct 16, 2019 at 08:01:46PM +0900, Masahiro Yamada wrote:
>>>> Hi Andrew,
>>>>
>>>> Could you pick up this to akpm tree?
>>>> https://lore.kernel.org/patchwork/patch/1089856/
>>>>
>>>> I believe this is correct, and a good clean-up.
>>>>
>>>> I pinged the DT maintainers, but they did not respond.
>>>
>>> Sorry I missed this. Things outside my normal paths fall thru the
>>> cracks.
>>>
>>> I'll apply it now.
>>>
>>> Rob
>>>
>>
>> Looks like my reply crossed with Rob's. Rob, shouldn't
>> scripts/dtc/update-dtc-source.sh make this change?
>
> No, the includes in include/linux are kernel files which wrap/replace
> the upstream ones.
>
> Rob
>

Right you are, I overlooked the "include/linux" in the file name
instead of "scripts/dtc/libfdt/".

-Frank