2019-10-19 08:51:01

by Måns Rullgård

Subject: [PATCH v2] net: ethernet: dwmac-sun8i: show message only when switching to promisc

Printing the info message every time more than the max number of mac
addresses are requested generates unnecessary log spam. Showing it only
when the hw is not already in promiscous mode is equally informative
without being annoying.

Signed-off-by: Mans Rullgard <[email protected]>
---
Changed in v2:
- test only RXALL bit
---
drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c
index 79c91526f3ec..c186de64e552 100644
--- a/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c
+++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c
@@ -646,7 +646,8 @@ static void sun8i_dwmac_set_filter(struct mac_device_info *hw,
}
}
} else {
- netdev_info(dev, "Too many address, switching to promiscuous\n");
+ if (!(readl(ioaddr + EMAC_RX_FRM_FLT) & EMAC_FRM_FLT_RXALL))
+ netdev_info(dev, "Too many address, switching to promiscuous\n");
v = EMAC_FRM_FLT_RXALL;
}

--
2.23.0

2019-10-19 19:20:19

by David Miller

Subject: Re: [PATCH v2] net: ethernet: dwmac-sun8i: show message only when switching to promisc

From: Mans Rullgard <[email protected]>
Date: Fri, 18 Oct 2019 17:56:58 +0100

> Printing the info message every time more than the max number of mac
> addresses are requested generates unnecessary log spam. Showing it only
> when the hw is not already in promiscous mode is equally informative
> without being annoying.
>
> Signed-off-by: Mans Rullgard <[email protected]>
> ---
> Changed in v2:
> - test only RXALL bit

Applied, thanks.