2019-10-22 23:53:18

by Yazen Ghannam

Subject: [PATCH v2 6/6] EDAC/amd64: Set grain per DIMM

From: Yazen Ghannam <[email protected]>

The following commit introduced a warning on error reports without a
non-zero grain value.

3724ace582d9 ("EDAC/mc: Fix grain_bits calculation")

The amd64_edac_mod module does not provide a value, so the warning will
be given on the first reported memory error.

Set the grain per DIMM to cacheline size (64 bytes). This is the current
recommendation.

Fixes: 3724ace582d9 ("EDAC/mc: Fix grain_bits calculation")
Signed-off-by: Yazen Ghannam <[email protected]>
---
Link:
https://lkml.kernel.org/r/[email protected]

v1 -> v2:
* No change.

rfc -> v1:
* New patch.

drivers/edac/amd64_edac.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/edac/amd64_edac.c b/drivers/edac/amd64_edac.c
index 114e7395daab..4ab7bcdede51 100644
--- a/drivers/edac/amd64_edac.c
+++ b/drivers/edac/amd64_edac.c
@@ -2944,6 +2944,7 @@ static int init_csrows_df(struct mem_ctl_info *mci)
dimm->mtype = pvt->dram_type;
dimm->edac_mode = edac_mode;
dimm->dtype = dev_type;
+ dimm->grain = 64;
}
}

@@ -3020,6 +3021,7 @@ static int init_csrows(struct mem_ctl_info *mci)
dimm = csrow->channels[j]->dimm;
dimm->mtype = pvt->dram_type;
dimm->edac_mode = edac_mode;
+ dimm->grain = 64;
}
}

--
2.17.1

2019-10-25 20:20:45

by Borislav Petkov

Subject: Re: [PATCH v2 6/6] EDAC/amd64: Set grain per DIMM

On Tue, Oct 22, 2019 at 08:35:14PM +0000, Ghannam, Yazen wrote:
> From: Yazen Ghannam <[email protected]>
>
> The following commit introduced a warning on error reports without a
> non-zero grain value.
>
> 3724ace582d9 ("EDAC/mc: Fix grain_bits calculation")
>
> The amd64_edac_mod module does not provide a value, so the warning will
> be given on the first reported memory error.
>
> Set the grain per DIMM to cacheline size (64 bytes). This is the current
> recommendation.
>
> Fixes: 3724ace582d9 ("EDAC/mc: Fix grain_bits calculation")
> Signed-off-by: Yazen Ghannam <[email protected]>
> ---
> Link:
> https://lkml.kernel.org/r/[email protected]
>
> v1 -> v2:
> * No change.
>
> rfc -> v1:
> * New patch.
>
> drivers/edac/amd64_edac.c | 2 ++
> 1 file changed, 2 insertions(+)

This one I can take now. Applied, thanks.

--
Regards/Gruss,
Boris.

https://people.kernel.org/tglx/notes-about-netiquette