2019-10-29 06:50:40

by Saurav Girepunje

Subject: [PATCH] phy: broadcom: phy-brcm-usb-init.c: Fix comparing pointer to 0

Compare pointer-typed values to NULL rather than 0

Signed-off-by: Saurav Girepunje <[email protected]>
---
drivers/phy/broadcom/phy-brcm-usb-init.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/phy/broadcom/phy-brcm-usb-init.c b/drivers/phy/broadcom/phy-brcm-usb-init.c
index 3c53625f8bc2..2ea1e84b544b 100644
--- a/drivers/phy/broadcom/phy-brcm-usb-init.c
+++ b/drivers/phy/broadcom/phy-brcm-usb-init.c
@@ -707,7 +707,7 @@ static void brcmusb_usb3_otp_fix(struct brcm_usb_init_params *params)
void __iomem *xhci_ec_base = params->xhci_ec_regs;
u32 val;

- if (params->family_id != 0x74371000 || xhci_ec_base == 0)
+ if (params->family_id != 0x74371000 || xhci_ec_base == NULL)
return;
brcmusb_writel(0xa20c, USB_XHCI_EC_REG(xhci_ec_base, IRAADR));
val = brcmusb_readl(USB_XHCI_EC_REG(xhci_ec_base, IRADAT));
--
2.20.1

2019-10-30 05:11:09

by Kishon Vijay Abraham I

Subject: Re: [PATCH] phy: broadcom: phy-brcm-usb-init.c: Fix comparing pointer to 0

Hi,

On 29/10/19 1:59 AM, Saurav Girepunje wrote:
> Compare pointer-typed values to NULL rather than 0
>
> Signed-off-by: Saurav Girepunje <[email protected]>

I've already merged a patch by Ben Dooks for fixing this
https://lore.kernel.org/r/[email protected]

Thanks
Kishon

> ---
> drivers/phy/broadcom/phy-brcm-usb-init.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/phy/broadcom/phy-brcm-usb-init.c b/drivers/phy/broadcom/phy-brcm-usb-init.c
> index 3c53625f8bc2..2ea1e84b544b 100644
> --- a/drivers/phy/broadcom/phy-brcm-usb-init.c
> +++ b/drivers/phy/broadcom/phy-brcm-usb-init.c
> @@ -707,7 +707,7 @@ static void brcmusb_usb3_otp_fix(struct brcm_usb_init_params *params)
> void __iomem *xhci_ec_base = params->xhci_ec_regs;
> u32 val;
>
> - if (params->family_id != 0x74371000 || xhci_ec_base == 0)
> + if (params->family_id != 0x74371000 || xhci_ec_base == NULL)
> return;
> brcmusb_writel(0xa20c, USB_XHCI_EC_REG(xhci_ec_base, IRAADR));
> val = brcmusb_readl(USB_XHCI_EC_REG(xhci_ec_base, IRADAT));
>