2019-10-28 16:14:49

by Gustavo A. R. Silva

Subject: [PATCH net-next] net: aquantia: fix error handling in aq_ptp_poll

Fix currenty ignored returned error by properly checking *err* after
calling aq_nic->aq_hw_ops->hw_ring_hwts_rx_fill().

Addresses-Coverity-ID: 1487357 ("Unused value")
Fixes: 04a1839950d9 ("net: aquantia: implement data PTP datapath")
Signed-off-by: Gustavo A. R. Silva <[email protected]>
---
drivers/net/ethernet/aquantia/atlantic/aq_ptp.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/net/ethernet/aquantia/atlantic/aq_ptp.c b/drivers/net/ethernet/aquantia/atlantic/aq_ptp.c
index 3ec08415e53e..92b666f7d242 100644
--- a/drivers/net/ethernet/aquantia/atlantic/aq_ptp.c
+++ b/drivers/net/ethernet/aquantia/atlantic/aq_ptp.c
@@ -678,6 +678,8 @@ static int aq_ptp_poll(struct napi_struct *napi, int budget)

err = aq_nic->aq_hw_ops->hw_ring_hwts_rx_fill(aq_nic->aq_hw,
&aq_ptp->hwts_rx);
+ if (err < 0)
+ goto err_exit;

was_cleaned = true;
}
--
2.23.0

2019-10-29 01:26:36

by Igor Russkikh

Subject: Re: [EXT] [PATCH net-next] net: aquantia: fix error handling in aq_ptp_poll

> Fix currenty ignored returned error by properly checking *err* after
> calling aq_nic->aq_hw_ops->hw_ring_hwts_rx_fill().
>
> Addresses-Coverity-ID: 1487357 ("Unused value")
> Fixes: 04a1839950d9 ("net: aquantia: implement data PTP datapath")
> Signed-off-by: Gustavo A. R. Silva <[email protected]>

Thanks, Gustavo!

Reviewed-by: Igor Russkikh <[email protected]>

Regards,
Igor

2019-10-29 23:43:56

by David Miller

Subject: Re: [PATCH net-next] net: aquantia: fix error handling in aq_ptp_poll

From: "Gustavo A. R. Silva" <[email protected]>
Date: Mon, 28 Oct 2019 02:04:47 -0500

> Fix currenty ignored returned error by properly checking *err* after
> calling aq_nic->aq_hw_ops->hw_ring_hwts_rx_fill().
>
> Addresses-Coverity-ID: 1487357 ("Unused value")
> Fixes: 04a1839950d9 ("net: aquantia: implement data PTP datapath")
> Signed-off-by: Gustavo A. R. Silva <[email protected]>

Applied.