2019-10-29 17:51:54

by Saurav Girepunje

Subject: [PATCH] fs: kernfs: file.c: Drop the condition with no effect.

As the "if" and "else" branch body are identical the condition
has no effect. So drop the if,else condition.

Signed-off-by: Saurav Girepunje <[email protected]>
---
fs/kernfs/file.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/fs/kernfs/file.c b/fs/kernfs/file.c
index e8c792b49616..d8123d8cfdcc 100644
--- a/fs/kernfs/file.c
+++ b/fs/kernfs/file.c
@@ -663,10 +663,7 @@ static int kernfs_fop_open(struct inode *inode, struct file *file)
* Both paths of the branch look the same. They're supposed to
* look that way and give @of->mutex different static lockdep keys.
*/
- if (has_mmap)
- mutex_init(&of->mutex);
- else
- mutex_init(&of->mutex);
+ mutex_init(&of->mutex);

of->kn = kn;
of->file = file;
--
2.20.1

2019-10-29 19:35:11

by Tejun Heo

Subject: Re: [PATCH] fs: kernfs: file.c: Drop the condition with no effect.

On Tue, Oct 29, 2019 at 03:25:52PM +0530, Saurav Girepunje wrote:
> As the "if" and "else" branch body are identical the condition
> has no effect. So drop the if,else condition.
>
> Signed-off-by: Saurav Girepunje <[email protected]>

Nack. Please read the comment right above.

Thanks.

--
tejun