2019-10-31 23:27:56

by Karl Palsson

[permalink] [raw]
Subject: [PATCH 1/3] ARM: dts: sunxi: h3/h5: add missing uart2 rts/cts pins

uart1 and uart3 had existing pin definitions for the rts/cts pairs.
Add definitions for uart2 as well.

Signed-off-by: Karl Palsson <[email protected]>
---
arch/arm/boot/dts/sunxi-h3-h5.dtsi | 5 +++++
1 file changed, 5 insertions(+)

diff --git a/arch/arm/boot/dts/sunxi-h3-h5.dtsi b/arch/arm/boot/dts/sunxi-h3-h5.dtsi
index 84977d4eb97a..2d8637300321 100644
--- a/arch/arm/boot/dts/sunxi-h3-h5.dtsi
+++ b/arch/arm/boot/dts/sunxi-h3-h5.dtsi
@@ -472,6 +472,11 @@
function = "uart2";
};

+ uart2_rts_cts_pins: uart2-rts-cts-pins {
+ pins = "PA2", "PA3";
+ function = "uart2";
+ };
+
uart3_pins: uart3-pins {
pins = "PA13", "PA14";
function = "uart3";
--
2.20.1


2019-11-01 02:53:18

by Chen-Yu Tsai

[permalink] [raw]
Subject: Re: [PATCH 1/3] ARM: dts: sunxi: h3/h5: add missing uart2 rts/cts pins

On Fri, Nov 1, 2019 at 7:16 AM Karl Palsson <[email protected]> wrote:
>
> uart1 and uart3 had existing pin definitions for the rts/cts pairs.
> Add definitions for uart2 as well.
>
> Signed-off-by: Karl Palsson <[email protected]>
> ---
> arch/arm/boot/dts/sunxi-h3-h5.dtsi | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/arch/arm/boot/dts/sunxi-h3-h5.dtsi b/arch/arm/boot/dts/sunxi-h3-h5.dtsi
> index 84977d4eb97a..2d8637300321 100644
> --- a/arch/arm/boot/dts/sunxi-h3-h5.dtsi
> +++ b/arch/arm/boot/dts/sunxi-h3-h5.dtsi
> @@ -472,6 +472,11 @@
> function = "uart2";
> };
>
> + uart2_rts_cts_pins: uart2-rts-cts-pins {

We started adding "/omit-if-no-ref/" for all pin definitions that
aren't selected by default. I think we can do this wholesale for
all the ones in this file after this patch is merged though. So,

Acked-by: Chen-Yu Tsai <[email protected]>

> + pins = "PA2", "PA3";
> + function = "uart2";
> + };
> +
> uart3_pins: uart3-pins {
> pins = "PA13", "PA14";
> function = "uart3";
> --
> 2.20.1
>

2019-11-01 11:22:25

by Maxime Ripard

[permalink] [raw]
Subject: Re: [PATCH 1/3] ARM: dts: sunxi: h3/h5: add missing uart2 rts/cts pins

On Thu, Oct 31, 2019 at 11:11:02PM +0000, Karl Palsson wrote:
> uart1 and uart3 had existing pin definitions for the rts/cts pairs.
> Add definitions for uart2 as well.
>
> Signed-off-by: Karl Palsson <[email protected]>

Applied, thanks!
Maxime


Attachments:
(No filename) (255.00 B)
signature.asc (235.00 B)
Download all attachments