2019-11-07 08:50:51

by Christophe Roullier

[permalink] [raw]
Subject: [PATCH V4 net-next 0/4] net: ethernet: stmmac: cleanup clock and optimization

Some improvements:
- manage syscfg as optional clock,
- update slew rate of ETH_MDIO pin,
- Enable gating of the MAC TX clock during TX low-power mode

V4: Update with Andrew Lunn remark

Christophe Roullier (4):
net: ethernet: stmmac: Add support for syscfg clock
ARM: dts: stm32: remove syscfg clock on stm32mp157c ethernet
ARM: dts: stm32: adjust slew rate for Ethernet
ARM: dts: stm32: Enable gating of the MAC TX clock during TX low-power
mode on stm32mp157c

arch/arm/boot/dts/stm32mp157-pinctrl.dtsi | 9 ++++++--
arch/arm/boot/dts/stm32mp157c.dtsi | 7 +++---
.../net/ethernet/stmicro/stmmac/dwmac-stm32.c | 23 +++++++------------
3 files changed, 18 insertions(+), 21 deletions(-)

--
2.17.1


2019-11-07 08:50:58

by Christophe Roullier

[permalink] [raw]
Subject: [PATCH V4 net-next 2/4] ARM: dts: stm32: remove syscfg clock on stm32mp157c ethernet

Syscfg is now activated automatically when syscfg registers are used

Signed-off-by: Christophe Roullier <[email protected]>
---
arch/arm/boot/dts/stm32mp157c.dtsi | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/arch/arm/boot/dts/stm32mp157c.dtsi b/arch/arm/boot/dts/stm32mp157c.dtsi
index 9b11654a0a39..f13c2348d130 100644
--- a/arch/arm/boot/dts/stm32mp157c.dtsi
+++ b/arch/arm/boot/dts/stm32mp157c.dtsi
@@ -1326,13 +1326,11 @@
clock-names = "stmmaceth",
"mac-clk-tx",
"mac-clk-rx",
- "ethstp",
- "syscfg-clk";
+ "ethstp";
clocks = <&rcc ETHMAC>,
<&rcc ETHTX>,
<&rcc ETHRX>,
- <&rcc ETHSTP>,
- <&rcc SYSCFG>;
+ <&rcc ETHSTP>;
st,syscon = <&syscfg 0x4>;
snps,mixed-burst;
snps,pbl = <2>;
--
2.17.1

2019-11-07 23:29:56

by David Miller

[permalink] [raw]
Subject: Re: [PATCH V4 net-next 0/4] net: ethernet: stmmac: cleanup clock and optimization

From: Christophe Roullier <[email protected]>
Date: Thu, 7 Nov 2019 09:47:53 +0100

> Some improvements:
> - manage syscfg as optional clock,
> - update slew rate of ETH_MDIO pin,
> - Enable gating of the MAC TX clock during TX low-power mode
>
> V4: Update with Andrew Lunn remark

This is mostly ARM DT updates, which tree should this go through?

I don't want to step on toes this time :-)

2019-11-08 10:36:52

by Alexandre Torgue

[permalink] [raw]
Subject: Re: [PATCH V4 net-next 0/4] net: ethernet: stmmac: cleanup clock and optimization

Hi David

On 11/8/19 12:26 AM, David Miller wrote:
> From: Christophe Roullier <[email protected]>
> Date: Thu, 7 Nov 2019 09:47:53 +0100
>
>> Some improvements:
>> - manage syscfg as optional clock,
>> - update slew rate of ETH_MDIO pin,
>> - Enable gating of the MAC TX clock during TX low-power mode
>>
>> V4: Update with Andrew Lunn remark
>
> This is mostly ARM DT updates, which tree should this go through?
>
> I don't want to step on toes this time :-)
>

I'll take DT patches in my STM32 tree.

Thanks
Alex

2019-11-08 19:24:38

by David Miller

[permalink] [raw]
Subject: Re: [PATCH V4 net-next 0/4] net: ethernet: stmmac: cleanup clock and optimization

From: Alexandre Torgue <[email protected]>
Date: Fri, 8 Nov 2019 11:35:23 +0100

> Hi David
>
> On 11/8/19 12:26 AM, David Miller wrote:
>> From: Christophe Roullier <[email protected]>
>> Date: Thu, 7 Nov 2019 09:47:53 +0100
>>
>>> Some improvements:
>>> - manage syscfg as optional clock,
>>> - update slew rate of ETH_MDIO pin,
>>> - Enable gating of the MAC TX clock during TX low-power mode
>>>
>>> V4: Update with Andrew Lunn remark
>> This is mostly ARM DT updates, which tree should this go through?
>> I don't want to step on toes this time :-)
>>
>
> I'll take DT patches in my STM32 tree.

Ok, I took patch #1 into net-next.

2019-12-09 14:03:32

by Alexandre Torgue

[permalink] [raw]
Subject: Re: [PATCH V4 net-next 0/4] net: ethernet: stmmac: cleanup clock and optimization

Hi Christophe

On 11/7/19 9:47 AM, Christophe Roullier wrote:
> Some improvements:
> - manage syscfg as optional clock,
> - update slew rate of ETH_MDIO pin,
> - Enable gating of the MAC TX clock during TX low-power mode
>
> V4: Update with Andrew Lunn remark
>
> Christophe Roullier (4):
> net: ethernet: stmmac: Add support for syscfg clock
> ARM: dts: stm32: remove syscfg clock on stm32mp157c ethernet
> ARM: dts: stm32: adjust slew rate for Ethernet
> ARM: dts: stm32: Enable gating of the MAC TX clock during TX low-power
> mode on stm32mp157c
>
> arch/arm/boot/dts/stm32mp157-pinctrl.dtsi | 9 ++++++--
> arch/arm/boot/dts/stm32mp157c.dtsi | 7 +++---
> .../net/ethernet/stmicro/stmmac/dwmac-stm32.c | 23 +++++++------------
> 3 files changed, 18 insertions(+), 21 deletions(-)
>

For DT patches:

Applied on stm32-next.

Thanks.
Alex