2019-11-08 14:15:05

by Eric Dumazet

Subject: [PATCH] powerpc: add const qual to local_read() parameter

A patch in net-next triggered a compile error on powerpc.

This seems reasonable to relax powerpc local_read() requirements.

Fixes: 316580b69d0a ("u64_stats: provide u64_stats_t type")
Signed-off-by: Eric Dumazet <[email protected]>
Reported-by: kbuild test robot <[email protected]>
Cc: Benjamin Herrenschmidt <[email protected]>
Cc: Paul Mackerras <[email protected]>
Cc: Michael Ellerman <[email protected]>
Cc: [email protected]
---
arch/powerpc/include/asm/local.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/powerpc/include/asm/local.h b/arch/powerpc/include/asm/local.h
index fdd00939270bf08113b537a090d6a6e34a048361..bc4bd19b7fc235b80ec1132f44409b6fe1057975 100644
--- a/arch/powerpc/include/asm/local.h
+++ b/arch/powerpc/include/asm/local.h
@@ -17,7 +17,7 @@ typedef struct

#define LOCAL_INIT(i) { (i) }

-static __inline__ long local_read(local_t *l)
+static __inline__ long local_read(const local_t *l)
{
return READ_ONCE(l->v);
}
--
2.24.0.432.g9d3f5f5b63-goog

2019-11-11 23:40:41

by Michael Ellerman

Subject: Re: [PATCH] powerpc: add const qual to local_read() parameter

Eric Dumazet <[email protected]> writes:
> A patch in net-next triggered a compile error on powerpc.

Would be nice to mention the compiler error, I haven't seen the report.

> This seems reasonable to relax powerpc local_read() requirements.

Seems fine.

Acked-by: Michael Ellerman <[email protected]>

Dave can you please put this in net-next to limit the window of
breakage.

cheers

> Fixes: 316580b69d0a ("u64_stats: provide u64_stats_t type")
> Signed-off-by: Eric Dumazet <[email protected]>
> Reported-by: kbuild test robot <[email protected]>
> Cc: Benjamin Herrenschmidt <[email protected]>
> Cc: Paul Mackerras <[email protected]>
> Cc: Michael Ellerman <[email protected]>
> Cc: [email protected]

Seems it didn't actually get cc'ed to linuxppc-dev for some reason.

> ---
> arch/powerpc/include/asm/local.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/include/asm/local.h b/arch/powerpc/include/asm/local.h
> index fdd00939270bf08113b537a090d6a6e34a048361..bc4bd19b7fc235b80ec1132f44409b6fe1057975 100644
> --- a/arch/powerpc/include/asm/local.h
> +++ b/arch/powerpc/include/asm/local.h
> @@ -17,7 +17,7 @@ typedef struct
>
> #define LOCAL_INIT(i) { (i) }
>
> -static __inline__ long local_read(local_t *l)
> +static __inline__ long local_read(const local_t *l)
> {
> return READ_ONCE(l->v);
> }
> --
> 2.24.0.432.g9d3f5f5b63-goog