2019-11-18 11:43:32

by Chuhong Yuan

Subject: [PATCH] phy: mdio-sun4i: add missed regulator_disable in remove

The driver forgets to disable the regulator in remove like what is done
in probe failure.
Add the missed call to fix it.

Signed-off-by: Chuhong Yuan <[email protected]>
---
drivers/net/phy/mdio-sun4i.c | 3 +++
1 file changed, 3 insertions(+)

diff --git a/drivers/net/phy/mdio-sun4i.c b/drivers/net/phy/mdio-sun4i.c
index 58d6504495e0..f798de3276dc 100644
--- a/drivers/net/phy/mdio-sun4i.c
+++ b/drivers/net/phy/mdio-sun4i.c
@@ -145,8 +145,11 @@ static int sun4i_mdio_probe(struct platform_device *pdev)
static int sun4i_mdio_remove(struct platform_device *pdev)
{
struct mii_bus *bus = platform_get_drvdata(pdev);
+ struct sun4i_mdio_data *data = bus->priv;

mdiobus_unregister(bus);
+ if (data->regulator)
+ regulator_disable(data->regulator);
mdiobus_free(bus);

return 0;
--
2.24.0

2019-11-19 01:25:08

by David Miller

Subject: Re: [PATCH] phy: mdio-sun4i: add missed regulator_disable in remove

From: Chuhong Yuan <[email protected]>
Date: Mon, 18 Nov 2019 19:41:15 +0800

> The driver forgets to disable the regulator in remove like what is done
> in probe failure.
> Add the missed call to fix it.
>
> Signed-off-by: Chuhong Yuan <[email protected]>

Applied, thanks.