2019-11-20 15:29:16

by Mihail Atanassov

Subject: [PATCH] drm/komeda: Remove unnecessary komeda_wb_connector_detect

The func is optional and the connector will report as always connected,
i.e. no change in behaviour.

Signed-off-by: Mihail Atanassov <[email protected]>
---
drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c | 7 -------
1 file changed, 7 deletions(-)

diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c b/drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c
index e465cc4879c9..c89ecdba8c28 100644
--- a/drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c
+++ b/drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c
@@ -107,12 +107,6 @@ static const struct drm_connector_helper_funcs komeda_wb_conn_helper_funcs = {
.mode_valid = komeda_wb_connector_mode_valid,
};

-static enum drm_connector_status
-komeda_wb_connector_detect(struct drm_connector *connector, bool force)
-{
- return connector_status_connected;
-}
-
static int
komeda_wb_connector_fill_modes(struct drm_connector *connector,
uint32_t maxX, uint32_t maxY)
@@ -128,7 +122,6 @@ static void komeda_wb_connector_destroy(struct drm_connector *connector)

static const struct drm_connector_funcs komeda_wb_connector_funcs = {
.reset = drm_atomic_helper_connector_reset,
- .detect = komeda_wb_connector_detect,
.fill_modes = komeda_wb_connector_fill_modes,
.destroy = komeda_wb_connector_destroy,
.atomic_duplicate_state = drm_atomic_helper_connector_duplicate_state,
--
2.23.0

2019-11-21 06:36:18

by James Qian Wang

Subject: Re: drm/komeda: Remove unnecessary komeda_wb_connector_detect

On Wed, Nov 20, 2019 at 12:03:55PM +0000, Mihail Atanassov wrote:
> The func is optional and the connector will report as always connected,
> i.e. no change in behaviour.
>
> Signed-off-by: Mihail Atanassov <[email protected]>
> ---
> drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c | 7 -------
> 1 file changed, 7 deletions(-)
>
> diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c b/drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c
> index e465cc4879c9..c89ecdba8c28 100644
> --- a/drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c
> +++ b/drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c
> @@ -107,12 +107,6 @@ static const struct drm_connector_helper_funcs komeda_wb_conn_helper_funcs = {
> .mode_valid = komeda_wb_connector_mode_valid,
> };
>
> -static enum drm_connector_status
> -komeda_wb_connector_detect(struct drm_connector *connector, bool force)
> -{
> - return connector_status_connected;
> -}
> -
> static int
> komeda_wb_connector_fill_modes(struct drm_connector *connector,
> uint32_t maxX, uint32_t maxY)
> @@ -128,7 +122,6 @@ static void komeda_wb_connector_destroy(struct drm_connector *connector)
>
> static const struct drm_connector_funcs komeda_wb_connector_funcs = {
> .reset = drm_atomic_helper_connector_reset,
> - .detect = komeda_wb_connector_detect,
> .fill_modes = komeda_wb_connector_fill_modes,
> .destroy = komeda_wb_connector_destroy,
> .atomic_duplicate_state = drm_atomic_helper_connector_duplicate_state,

Looks good to me.

Reviewed-by: James Qian Wang (Arm Technology China) <[email protected]>