2019-11-04 10:12:50

by Peng Fan

Subject: [PATCH 1/2] clk: imx: clk-divider-gate: typo fix

From: Peng Fan <[email protected]>

resue->reuse

Signed-off-by: Peng Fan <[email protected]>
---
drivers/clk/imx/clk-divider-gate.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clk/imx/clk-divider-gate.c b/drivers/clk/imx/clk-divider-gate.c
index 2a8352a316c7..214e18eb2b22 100644
--- a/drivers/clk/imx/clk-divider-gate.c
+++ b/drivers/clk/imx/clk-divider-gate.c
@@ -167,7 +167,7 @@ static const struct clk_ops clk_divider_gate_ops = {
};

/*
- * NOTE: In order to resue the most code from the common divider,
+ * NOTE: In order to reuse the most code from the common divider,
* we also design our divider following the way that provids an extra
* clk_divider_flags, however it's fixed to CLK_DIVIDER_ONE_BASED by
* default as our HW is. Besides that it supports only CLK_DIVIDER_READ_ONLY
--
2.16.4

2019-11-04 10:14:36

by Peng Fan

Subject: [PATCH 2/2] clk: imx: clk-divider-gate: drop redundant initialization

From: Peng Fan <[email protected]>

There is no need to initialize flags as 0.

Signed-off-by: Peng Fan <[email protected]>
---
drivers/clk/imx/clk-divider-gate.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/clk/imx/clk-divider-gate.c b/drivers/clk/imx/clk-divider-gate.c
index 214e18eb2b22..4145594af53b 100644
--- a/drivers/clk/imx/clk-divider-gate.c
+++ b/drivers/clk/imx/clk-divider-gate.c
@@ -43,7 +43,7 @@ static unsigned long clk_divider_gate_recalc_rate(struct clk_hw *hw,
{
struct clk_divider_gate *div_gate = to_clk_divider_gate(hw);
struct clk_divider *div = to_clk_divider(hw);
- unsigned long flags = 0;
+ unsigned long flags;
unsigned int val;

spin_lock_irqsave(div->lock, flags);
@@ -75,7 +75,7 @@ static int clk_divider_gate_set_rate(struct clk_hw *hw, unsigned long rate,
{
struct clk_divider_gate *div_gate = to_clk_divider_gate(hw);
struct clk_divider *div = to_clk_divider(hw);
- unsigned long flags = 0;
+ unsigned long flags;
int value;
u32 val;

@@ -104,7 +104,7 @@ static int clk_divider_enable(struct clk_hw *hw)
{
struct clk_divider_gate *div_gate = to_clk_divider_gate(hw);
struct clk_divider *div = to_clk_divider(hw);
- unsigned long flags = 0;
+ unsigned long flags;
u32 val;

if (!div_gate->cached_val) {
@@ -127,7 +127,7 @@ static void clk_divider_disable(struct clk_hw *hw)
{
struct clk_divider_gate *div_gate = to_clk_divider_gate(hw);
struct clk_divider *div = to_clk_divider(hw);
- unsigned long flags = 0;
+ unsigned long flags;
u32 val;

spin_lock_irqsave(div->lock, flags);
--
2.16.4

2019-11-05 11:38:58

by Abel Vesa

Subject: Re: [PATCH 2/2] clk: imx: clk-divider-gate: drop redundant initialization

On 19-11-04 10:11:37, Peng Fan wrote:
> From: Peng Fan <[email protected]>
>
> There is no need to initialize flags as 0.
>
> Signed-off-by: Peng Fan <[email protected]>

Reviewed-by: Abel Vesa <[email protected]>

> ---
> drivers/clk/imx/clk-divider-gate.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/clk/imx/clk-divider-gate.c b/drivers/clk/imx/clk-divider-gate.c
> index 214e18eb2b22..4145594af53b 100644
> --- a/drivers/clk/imx/clk-divider-gate.c
> +++ b/drivers/clk/imx/clk-divider-gate.c
> @@ -43,7 +43,7 @@ static unsigned long clk_divider_gate_recalc_rate(struct clk_hw *hw,
> {
> struct clk_divider_gate *div_gate = to_clk_divider_gate(hw);
> struct clk_divider *div = to_clk_divider(hw);
> - unsigned long flags = 0;
> + unsigned long flags;
> unsigned int val;
>
> spin_lock_irqsave(div->lock, flags);
> @@ -75,7 +75,7 @@ static int clk_divider_gate_set_rate(struct clk_hw *hw, unsigned long rate,
> {
> struct clk_divider_gate *div_gate = to_clk_divider_gate(hw);
> struct clk_divider *div = to_clk_divider(hw);
> - unsigned long flags = 0;
> + unsigned long flags;
> int value;
> u32 val;
>
> @@ -104,7 +104,7 @@ static int clk_divider_enable(struct clk_hw *hw)
> {
> struct clk_divider_gate *div_gate = to_clk_divider_gate(hw);
> struct clk_divider *div = to_clk_divider(hw);
> - unsigned long flags = 0;
> + unsigned long flags;
> u32 val;
>
> if (!div_gate->cached_val) {
> @@ -127,7 +127,7 @@ static void clk_divider_disable(struct clk_hw *hw)
> {
> struct clk_divider_gate *div_gate = to_clk_divider_gate(hw);
> struct clk_divider *div = to_clk_divider(hw);
> - unsigned long flags = 0;
> + unsigned long flags;
> u32 val;
>
> spin_lock_irqsave(div->lock, flags);
> --
> 2.16.4
>

2019-12-02 09:02:29

by Shawn Guo

Subject: Re: [PATCH 1/2] clk: imx: clk-divider-gate: typo fix

On Mon, Nov 04, 2019 at 10:11:33AM +0000, Peng Fan wrote:
> From: Peng Fan <[email protected]>
>
> resue->reuse
>
> Signed-off-by: Peng Fan <[email protected]>

Applied it after updating the subject and commit log as below.

clk: imx: clk-divider-gate: fix a typo in comment

Fix a typo in comment: resue -> reuse.

Shawn

> ---
> drivers/clk/imx/clk-divider-gate.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clk/imx/clk-divider-gate.c b/drivers/clk/imx/clk-divider-gate.c
> index 2a8352a316c7..214e18eb2b22 100644
> --- a/drivers/clk/imx/clk-divider-gate.c
> +++ b/drivers/clk/imx/clk-divider-gate.c
> @@ -167,7 +167,7 @@ static const struct clk_ops clk_divider_gate_ops = {
> };
>
> /*
> - * NOTE: In order to resue the most code from the common divider,
> + * NOTE: In order to reuse the most code from the common divider,
> * we also design our divider following the way that provids an extra
> * clk_divider_flags, however it's fixed to CLK_DIVIDER_ONE_BASED by
> * default as our HW is. Besides that it supports only CLK_DIVIDER_READ_ONLY
> --
> 2.16.4
>

2019-12-02 09:05:13

by Shawn Guo

Subject: Re: [PATCH 2/2] clk: imx: clk-divider-gate: drop redundant initialization

On Mon, Nov 04, 2019 at 10:11:37AM +0000, Peng Fan wrote:
> From: Peng Fan <[email protected]>
>
> There is no need to initialize flags as 0.
>
> Signed-off-by: Peng Fan <[email protected]>

Applied, thanks.