2019-12-05 23:06:30

by Aditya Pakki

Subject: [PATCH] pppoe: remove redundant BUG_ON() check in pppoe_pernet

Passing NULL to pppoe_pernet causes a crash via BUG_ON.
Dereferencing net in net_generici() also has the same effect. This patch
removes the redundant BUG_ON check on the same parameter.

Signed-off-by: Aditya Pakki <[email protected]>
---
drivers/net/ppp/pppoe.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/net/ppp/pppoe.c b/drivers/net/ppp/pppoe.c
index a44dd3c8af63..d760a36db28c 100644
--- a/drivers/net/ppp/pppoe.c
+++ b/drivers/net/ppp/pppoe.c
@@ -119,8 +119,6 @@ static inline bool stage_session(__be16 sid)

static inline struct pppoe_net *pppoe_pernet(struct net *net)
{
- BUG_ON(!net);
-
return net_generic(net, pppoe_net_id);
}

--
2.17.1

2019-12-07 19:53:20

by David Miller

Subject: Re: [PATCH] pppoe: remove redundant BUG_ON() check in pppoe_pernet

From: Aditya Pakki <[email protected]>
Date: Thu, 5 Dec 2019 17:04:49 -0600

> Passing NULL to pppoe_pernet causes a crash via BUG_ON.
> Dereferencing net in net_generici() also has the same effect. This patch
> removes the redundant BUG_ON check on the same parameter.
>
> Signed-off-by: Aditya Pakki <[email protected]>

Applied.