2019-12-06 10:13:42

by Kamil Konieczny

Subject: [PATCH] devfreq: move declaration of DEVICE_ATTR_RW(min_freq)

Declaration of DEVICE_ATTR_RW(min_freq) is placed after function
max_freq_store. Move it to the correct place after min_freq_show.

Signed-off-by: Kamil Konieczny <[email protected]>
---
drivers/devfreq/devfreq.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c
index 1786a86b1779..46a7ff7c2994 100644
--- a/drivers/devfreq/devfreq.c
+++ b/drivers/devfreq/devfreq.c
@@ -1368,6 +1368,7 @@ static ssize_t min_freq_show(struct device *dev, struct device_attribute *attr,

return sprintf(buf, "%lu\n", min_freq);
}
+static DEVICE_ATTR_RW(min_freq);

static ssize_t max_freq_store(struct device *dev, struct device_attribute *attr,
const char *buf, size_t count)
@@ -1391,7 +1392,6 @@ static ssize_t max_freq_store(struct device *dev, struct device_attribute *attr,

return count;
}
-static DEVICE_ATTR_RW(min_freq);

static ssize_t max_freq_show(struct device *dev, struct device_attribute *attr,
char *buf)
--
2.24.0

2019-12-09 03:20:29

by Chanwoo Choi

Subject: Re: [PATCH] devfreq: move declaration of DEVICE_ATTR_RW(min_freq)

Hi Kamil,

Looks good to me. Applied it.

On later, better to add 'PM / ' prefix for patch title
and use capital char for first word as following:

devfreq: move declaration of DEVICE_ATTR_RW(min_freq)
-> PM / devfreq: Move declaration of DEVICE_ATTR_RW(min_freq)

On 12/6/19 7:11 PM, Kamil Konieczny wrote:
> Declaration of DEVICE_ATTR_RW(min_freq) is placed after function
> max_freq_store. Move it to the correct place after min_freq_show.
>
> Signed-off-by: Kamil Konieczny <[email protected]>
> ---
> drivers/devfreq/devfreq.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c
> index 1786a86b1779..46a7ff7c2994 100644
> --- a/drivers/devfreq/devfreq.c
> +++ b/drivers/devfreq/devfreq.c
> @@ -1368,6 +1368,7 @@ static ssize_t min_freq_show(struct device *dev, struct device_attribute *attr,
>
> return sprintf(buf, "%lu\n", min_freq);
> }
> +static DEVICE_ATTR_RW(min_freq);
>
> static ssize_t max_freq_store(struct device *dev, struct device_attribute *attr,
> const char *buf, size_t count)
> @@ -1391,7 +1392,6 @@ static ssize_t max_freq_store(struct device *dev, struct device_attribute *attr,
>
> return count;
> }
> -static DEVICE_ATTR_RW(min_freq);
>
> static ssize_t max_freq_show(struct device *dev, struct device_attribute *attr,
> char *buf)
>


--
Best Regards,
Chanwoo Choi
Samsung Electronics