2019-12-10 14:58:46

by Oleksandr Natalenko

Subject: [PATCH RFC] init/Kconfig: enable -O3 for all arches

Building a kernel with -O3 may help in hunting bugs like [1] and thus
using this switch should not be restricted to one specific arch only.

Thus lets expose it. If for some reasone we have to hide it, lets hide
it under EXPERT.

The commit is made against next-20191210 tag.

[1] https://lore.kernel.org/lkml/[email protected]/

Signed-off-by: Oleksandr Natalenko <[email protected]>
---
init/Kconfig | 1 -
1 file changed, 1 deletion(-)

diff --git a/init/Kconfig b/init/Kconfig
index a34064a031a5..b41b18edb10e 100644
--- a/init/Kconfig
+++ b/init/Kconfig
@@ -1228,7 +1228,6 @@ config CC_OPTIMIZE_FOR_PERFORMANCE

config CC_OPTIMIZE_FOR_PERFORMANCE_O3
bool "Optimize more for performance (-O3)"
- depends on ARC
imply CC_DISABLE_WARN_MAYBE_UNINITIALIZED # avoid false positives
help
Choosing this option will pass "-O3" to your compiler to optimize
--
2.24.0

2019-12-10 15:38:15

by Krzysztof Kozlowski

Subject: Re: [PATCH RFC] init/Kconfig: enable -O3 for all arches

On Tue, 10 Dec 2019 at 15:57, Oleksandr Natalenko <[email protected]> wrote:
>
> Building a kernel with -O3 may help in hunting bugs like [1] and thus
> using this switch should not be restricted to one specific arch only.
>
> Thus lets expose it. If for some reasone we have to hide it, lets hide
> it under EXPERT.

You are not hiding it under EXPERT so no need to document in commit
log theoretical future decisions.

> The commit is made against next-20191210 tag.

This does not belong to commit message. You can put such under the ---
separator.

Best regards,
Krzysztof

>
> [1] https://lore.kernel.org/lkml/[email protected]/
>
> Signed-off-by: Oleksandr Natalenko <[email protected]>
> ---
> init/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/init/Kconfig b/init/Kconfig
> index a34064a031a5..b41b18edb10e 100644
> --- a/init/Kconfig
> +++ b/init/Kconfig
> @@ -1228,7 +1228,6 @@ config CC_OPTIMIZE_FOR_PERFORMANCE
>
> config CC_OPTIMIZE_FOR_PERFORMANCE_O3
> bool "Optimize more for performance (-O3)"
> - depends on ARC
> imply CC_DISABLE_WARN_MAYBE_UNINITIALIZED # avoid false positives
> help
> Choosing this option will pass "-O3" to your compiler to optimize
> --
> 2.24.0
>