Add numbered labels to the i2c nodes of the Tegra20 SoC so we just need
to alias it from derived boards.
Signed-off-by: Richard Leitner <[email protected]>
---
arch/arm/boot/dts/tegra20.dtsi | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/arm/boot/dts/tegra20.dtsi b/arch/arm/boot/dts/tegra20.dtsi
index 9c58e7fcf5c0..e02f75757a7e 100644
--- a/arch/arm/boot/dts/tegra20.dtsi
+++ b/arch/arm/boot/dts/tegra20.dtsi
@@ -464,7 +464,7 @@
clocks = <&tegra_car TEGRA20_CLK_RTC>;
};
- i2c@7000c000 {
+ i2c1: i2c@7000c000 {
compatible = "nvidia,tegra20-i2c";
reg = <0x7000c000 0x100>;
interrupts = <GIC_SPI 38 IRQ_TYPE_LEVEL_HIGH>;
@@ -494,7 +494,7 @@
status = "disabled";
};
- i2c@7000c400 {
+ i2c2: i2c@7000c400 {
compatible = "nvidia,tegra20-i2c";
reg = <0x7000c400 0x100>;
interrupts = <GIC_SPI 84 IRQ_TYPE_LEVEL_HIGH>;
@@ -510,7 +510,7 @@
status = "disabled";
};
- i2c@7000c500 {
+ i2c3: i2c@7000c500 {
compatible = "nvidia,tegra20-i2c";
reg = <0x7000c500 0x100>;
interrupts = <GIC_SPI 92 IRQ_TYPE_LEVEL_HIGH>;
--
2.21.0
Add labels to the host1x, dc and hdmi nodes of the Tegra20 SoC so we
just need to alias it from derived boards.
Signed-off-by: Richard Leitner <[email protected]>
---
arch/arm/boot/dts/tegra20.dtsi | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/arm/boot/dts/tegra20.dtsi b/arch/arm/boot/dts/tegra20.dtsi
index e02f75757a7e..c569bd87550f 100644
--- a/arch/arm/boot/dts/tegra20.dtsi
+++ b/arch/arm/boot/dts/tegra20.dtsi
@@ -29,7 +29,7 @@
};
};
- host1x@50000000 {
+ host1x: host1x@50000000 {
compatible = "nvidia,tegra20-host1x", "simple-bus";
reg = <0x50000000 0x00024000>;
interrupts = <GIC_SPI 65 IRQ_TYPE_LEVEL_HIGH>, /* syncpt */
@@ -96,7 +96,7 @@
reset-names = "3d";
};
- dc@54200000 {
+ dc1: dc@54200000 {
compatible = "nvidia,tegra20-dc";
reg = <0x54200000 0x00040000>;
interrupts = <GIC_SPI 73 IRQ_TYPE_LEVEL_HIGH>;
@@ -113,7 +113,7 @@
};
};
- dc@54240000 {
+ dc2: dc@54240000 {
compatible = "nvidia,tegra20-dc";
reg = <0x54240000 0x00040000>;
interrupts = <GIC_SPI 74 IRQ_TYPE_LEVEL_HIGH>;
@@ -130,7 +130,7 @@
};
};
- hdmi@54280000 {
+ hdmi: hdmi@54280000 {
compatible = "nvidia,tegra20-hdmi";
reg = <0x54280000 0x00040000>;
interrupts = <GIC_SPI 75 IRQ_TYPE_LEVEL_HIGH>;
--
2.21.0
19.12.2019 16:04, Richard Leitner пишет:
> Add numbered labels to the i2c nodes of the Tegra20 SoC so we just need
> to alias it from derived boards.
>
> Signed-off-by: Richard Leitner <[email protected]>
> ---
> arch/arm/boot/dts/tegra20.dtsi | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/boot/dts/tegra20.dtsi b/arch/arm/boot/dts/tegra20.dtsi
> index 9c58e7fcf5c0..e02f75757a7e 100644
> --- a/arch/arm/boot/dts/tegra20.dtsi
> +++ b/arch/arm/boot/dts/tegra20.dtsi
> @@ -464,7 +464,7 @@
> clocks = <&tegra_car TEGRA20_CLK_RTC>;
> };
>
> - i2c@7000c000 {
> + i2c1: i2c@7000c000 {
> compatible = "nvidia,tegra20-i2c";
> reg = <0x7000c000 0x100>;
> interrupts = <GIC_SPI 38 IRQ_TYPE_LEVEL_HIGH>;
> @@ -494,7 +494,7 @@
> status = "disabled";
> };
>
> - i2c@7000c400 {
> + i2c2: i2c@7000c400 {
> compatible = "nvidia,tegra20-i2c";
> reg = <0x7000c400 0x100>;
> interrupts = <GIC_SPI 84 IRQ_TYPE_LEVEL_HIGH>;
> @@ -510,7 +510,7 @@
> status = "disabled";
> };
>
> - i2c@7000c500 {
> + i2c3: i2c@7000c500 {
> compatible = "nvidia,tegra20-i2c";
> reg = <0x7000c500 0x100>;
> interrupts = <GIC_SPI 92 IRQ_TYPE_LEVEL_HIGH>;
>
Hello Richard,
Why derived boards couldn't label nodes by themselves? That's what all
derived boards are doing already.
BTW, upstream should benefit from the submitted changes. This is not a
very useful change for upstream if you're not updating the actual DTs of
any of the boards in arch/arm/boot/dts/*.
Hi,
thanks for the reply.
On 20/12/2019 15:00, Dmitry Osipenko wrote:
> 19.12.2019 16:04, Richard Leitner пишет:
>> Add numbered labels to the i2c nodes of the Tegra20 SoC so we just need
>> to alias it from derived boards.
>>
>> Signed-off-by: Richard Leitner <[email protected]>
>> ---
>> arch/arm/boot/dts/tegra20.dtsi | 6 +++---
>> 1 file changed, 3 insertions(+), 3 deletions(-)
...
>
> Hello Richard,
>
> Why derived boards couldn't label nodes by themselves? That's what all
> derived boards are doing already.
Of course they can, but IMHO its more useful to have the same labels for
all derived boards.
>
> BTW, upstream should benefit from the submitted changes. This is not a
> very useful change for upstream if you're not updating the actual DTs of
> any of the boards in arch/arm/boot/dts/*.
That's true. I thought of also patching the actual DTs but wasn't sure
if that should be in the same series...
Based on your answer I guess it should be.
Therefore I'll send a v2 soon.
Thanks again & regards;richard.l
23.12.2019 10:46, Richard Leitner пишет:
> Hi,
> thanks for the reply.
>
> On 20/12/2019 15:00, Dmitry Osipenko wrote:
>> 19.12.2019 16:04, Richard Leitner пишет:
>>> Add numbered labels to the i2c nodes of the Tegra20 SoC so we just need
>>> to alias it from derived boards.
>>>
>>> Signed-off-by: Richard Leitner <[email protected]>
>>> ---
>>> arch/arm/boot/dts/tegra20.dtsi | 6 +++---
>>> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> ...
>
>>
>> Hello Richard,
>>
>> Why derived boards couldn't label nodes by themselves? That's what all
>> derived boards are doing already.
>
> Of course they can, but IMHO its more useful to have the same labels for
> all derived boards.
>
>>
>> BTW, upstream should benefit from the submitted changes. This is not a
>> very useful change for upstream if you're not updating the actual DTs of
>> any of the boards in arch/arm/boot/dts/*.
>
> That's true. I thought of also patching the actual DTs but wasn't sure
> if that should be in the same series...
> Based on your answer I guess it should be.
>
> Therefore I'll send a v2 soon.
>
> Thanks again & regards;richard.l
Seeing the full picture will be very helpful, thanks.