2019-12-20 16:39:41

by Georgi Djakov

Subject: [PATCH] interconnect: Print the tag in the debugfs summary

Now we can have a tag associated with the path. Add this information
to the interconnect_summary file, as the current information in debugfs
is incomplete.

Signed-off-by: Georgi Djakov <[email protected]>
---
drivers/interconnect/core.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/interconnect/core.c b/drivers/interconnect/core.c
index 1867fad56c0f..ae80fbea5d2d 100644
--- a/drivers/interconnect/core.c
+++ b/drivers/interconnect/core.c
@@ -34,7 +34,7 @@ static void icc_summary_show_one(struct seq_file *s, struct icc_node *n)
if (!n)
return;

- seq_printf(s, "%-30s %12u %12u\n",
+ seq_printf(s, "%-42s %12u %12u\n",
n->name, n->avg_bw, n->peak_bw);
}

@@ -42,8 +42,8 @@ static int icc_summary_show(struct seq_file *s, void *data)
{
struct icc_provider *provider;

- seq_puts(s, " node avg peak\n");
- seq_puts(s, "--------------------------------------------------------\n");
+ seq_puts(s, " node tag avg peak\n");
+ seq_puts(s, "--------------------------------------------------------------------\n");

mutex_lock(&icc_lock);

@@ -58,8 +58,8 @@ static int icc_summary_show(struct seq_file *s, void *data)
if (!r->dev)
continue;

- seq_printf(s, " %-26s %12u %12u\n",
- dev_name(r->dev), r->avg_bw,
+ seq_printf(s, " %-27s %12u %12u %12u\n",
+ dev_name(r->dev), r->tag, r->avg_bw,
r->peak_bw);
}
}

2019-12-20 16:52:37

by Bjorn Andersson

Subject: Re: [PATCH] interconnect: Print the tag in the debugfs summary

On Fri 20 Dec 08:38 PST 2019, Georgi Djakov wrote:

> Now we can have a tag associated with the path. Add this information
> to the interconnect_summary file, as the current information in debugfs
> is incomplete.
>
> Signed-off-by: Georgi Djakov <[email protected]>

Reviewed-by: Bjorn Andersson <[email protected]>

> ---
> drivers/interconnect/core.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/interconnect/core.c b/drivers/interconnect/core.c
> index 1867fad56c0f..ae80fbea5d2d 100644
> --- a/drivers/interconnect/core.c
> +++ b/drivers/interconnect/core.c
> @@ -34,7 +34,7 @@ static void icc_summary_show_one(struct seq_file *s, struct icc_node *n)
> if (!n)
> return;
>
> - seq_printf(s, "%-30s %12u %12u\n",
> + seq_printf(s, "%-42s %12u %12u\n",
> n->name, n->avg_bw, n->peak_bw);
> }
>
> @@ -42,8 +42,8 @@ static int icc_summary_show(struct seq_file *s, void *data)
> {
> struct icc_provider *provider;
>
> - seq_puts(s, " node avg peak\n");
> - seq_puts(s, "--------------------------------------------------------\n");
> + seq_puts(s, " node tag avg peak\n");
> + seq_puts(s, "--------------------------------------------------------------------\n");
>
> mutex_lock(&icc_lock);
>
> @@ -58,8 +58,8 @@ static int icc_summary_show(struct seq_file *s, void *data)
> if (!r->dev)
> continue;
>
> - seq_printf(s, " %-26s %12u %12u\n",
> - dev_name(r->dev), r->avg_bw,
> + seq_printf(s, " %-27s %12u %12u %12u\n",
> + dev_name(r->dev), r->tag, r->avg_bw,
> r->peak_bw);
> }
> }