2020-01-07 09:39:10

by chenzhou

Subject: [PATCH next] drivers: net: cisco_hdlc: use __func__ in debug message

Use __func__ to print the function name instead of hard coded string.
BTW, replace printk(KERN_DEBUG, ...) with netdev_dbg.

Signed-off-by: Chen Zhou <[email protected]>
---
drivers/net/wan/hdlc_cisco.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/wan/hdlc_cisco.c b/drivers/net/wan/hdlc_cisco.c
index a030f5a..d8cba36 100644
--- a/drivers/net/wan/hdlc_cisco.c
+++ b/drivers/net/wan/hdlc_cisco.c
@@ -75,7 +75,7 @@ static int cisco_hard_header(struct sk_buff *skb, struct net_device *dev,
{
struct hdlc_header *data;
#ifdef DEBUG_HARD_HEADER
- printk(KERN_DEBUG "%s: cisco_hard_header called\n", dev->name);
+ netdev_dbg(dev, "%s called\n", __func__);
#endif

skb_push(skb, sizeof(struct hdlc_header));
@@ -101,7 +101,7 @@ static void cisco_keepalive_send(struct net_device *dev, u32 type,
skb = dev_alloc_skb(sizeof(struct hdlc_header) +
sizeof(struct cisco_packet));
if (!skb) {
- netdev_warn(dev, "Memory squeeze on cisco_keepalive_send()\n");
+ netdev_warn(dev, "Memory squeeze on %s()\n", __func__);
return;
}
skb_reserve(skb, 4);
--
2.7.4

2020-01-07 21:35:32

by David Miller

Subject: Re: [PATCH next] drivers: net: cisco_hdlc: use __func__ in debug message

From: Chen Zhou <[email protected]>
Date: Tue, 7 Jan 2020 17:33:46 +0800

> Use __func__ to print the function name instead of hard coded string.
> BTW, replace printk(KERN_DEBUG, ...) with netdev_dbg.
>
> Signed-off-by: Chen Zhou <[email protected]>

Applied, thanks.