Hi,
Commit 54ff4a1d1732 ("MIPS: Alchemy: pata_platform for DB1200")
from year 2014 converted the only user of au1xxx-ide IDE host
driver (MIPS Alchemy DB1200 platform) to use pata_platform libata
host driver instead. This patch series removes dead au1xxx-ide
driver code & co.
Since patch #2 depends on patch #1 (and it is also the best to
apply patch #3 after driver code removal) it would be probably
easiest to merge everything through MIPS tree (after getting
necessary ACKs, from David for the first patch and Jonathan for
the third one).
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
Bartlomiej Zolnierkiewicz (3):
ide: remove no longer used au1xxx-ide driver
MIPS: Alchemy: remove no longer used au1xxx_ide.h header
docs: mips: remove no longer needed au1xxx_ide.rst documentation
Documentation/mips/au1xxx_ide.rst | 130 ----
Documentation/mips/index.rst | 2 -
.../mips/include/asm/mach-au1x00/au1xxx_ide.h | 178 ------
drivers/ide/Kconfig | 17 -
drivers/ide/Makefile | 2 -
drivers/ide/au1xxx-ide.c | 597 ------------------
6 files changed, 926 deletions(-)
delete mode 100644 Documentation/mips/au1xxx_ide.rst
delete mode 100644 arch/mips/include/asm/mach-au1x00/au1xxx_ide.h
delete mode 100644 drivers/ide/au1xxx-ide.c
--
2.24.1
Since the au1xxx-ide IDE host driver is no longer needed its documentation
can be removed.
Signed-off-by: Bartlomiej Zolnierkiewicz <[email protected]>
---
Documentation/mips/au1xxx_ide.rst | 130 ------------------------------
Documentation/mips/index.rst | 2 -
2 files changed, 132 deletions(-)
delete mode 100644 Documentation/mips/au1xxx_ide.rst
diff --git a/Documentation/mips/au1xxx_ide.rst b/Documentation/mips/au1xxx_ide.rst
deleted file mode 100644
index 2f9c2cff6738..000000000000
--- a/Documentation/mips/au1xxx_ide.rst
+++ /dev/null
@@ -1,130 +0,0 @@
-.. include:: <isonum.txt>
-
-======================
-MIPS AU1XXX IDE driver
-======================
-
-Released 2005-07-15
-
-About
-=====
-
-This file describes the 'drivers/ide/au1xxx-ide.c', related files and the
-services they provide.
-
-If you are short in patience and just want to know how to add your hard disc to
-the white or black list, go to the 'ADD NEW HARD DISC TO WHITE OR BLACK LIST'
-section.
-
-
-License
-=======
-
-:Copyright: |copy| 2003-2005 AMD, Personal Connectivity Solutions
-
-This program is free software; you can redistribute it and/or modify it under
-the terms of the GNU General Public License as published by the Free Software
-Foundation; either version 2 of the License, or (at your option) any later
-version.
-
-THIS SOFTWARE IS PROVIDED ``AS IS`` AND ANY EXPRESS OR IMPLIED WARRANTIES,
-INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND
-FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE AUTHOR
-BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
-CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
-SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
-INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
-CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
-ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
-POSSIBILITY OF SUCH DAMAGE.
-
-You should have received a copy of the GNU General Public License along with
-this program; if not, write to the Free Software Foundation, Inc.,
-675 Mass Ave, Cambridge, MA 02139, USA.
-
-Note:
- for more information, please refer "AMD Alchemy Au1200/Au1550 IDE
- Interface and Linux Device Driver" Application Note.
-
-
-Files, Configs and Compatibility
-================================
-
-Two files are introduced:
-
- a) 'arch/mips/include/asm/mach-au1x00/au1xxx_ide.h'
- contains : struct _auide_hwif
-
- - timing parameters for PIO mode 0/1/2/3/4
- - timing parameters for MWDMA 0/1/2
-
- b) 'drivers/ide/mips/au1xxx-ide.c'
- contains the functionality of the AU1XXX IDE driver
-
-Following extra configs variables are introduced:
-
- CONFIG_BLK_DEV_IDE_AU1XXX_PIO_DBDMA
- - enable the PIO+DBDMA mode
- CONFIG_BLK_DEV_IDE_AU1XXX_MDMA2_DBDMA
- - enable the MWDMA mode
-
-
-Supported IDE Modes
-===================
-
-The AU1XXX IDE driver supported all PIO modes - PIO mode 0/1/2/3/4 - and all
-MWDMA modes - MWDMA 0/1/2 -. There is no support for SWDMA and UDMA mode.
-
-To change the PIO mode use the program hdparm with option -p, e.g.
-'hdparm -p0 [device]' for PIO mode 0. To enable the MWDMA mode use the option
--X, e.g. 'hdparm -X32 [device]' for MWDMA mode 0.
-
-
-Performance Configurations
-==========================
-
-If the used system doesn't need USB support enable the following kernel
-configs::
-
- CONFIG_IDE=y
- CONFIG_BLK_DEV_IDE=y
- CONFIG_IDE_GENERIC=y
- CONFIG_BLK_DEV_IDEPCI=y
- CONFIG_BLK_DEV_GENERIC=y
- CONFIG_BLK_DEV_IDEDMA_PCI=y
- CONFIG_BLK_DEV_IDE_AU1XXX=y
- CONFIG_BLK_DEV_IDE_AU1XXX_MDMA2_DBDMA=y
- CONFIG_BLK_DEV_IDEDMA=y
-
-Also define 'IDE_AU1XXX_BURSTMODE' in 'drivers/ide/mips/au1xxx-ide.c' to enable
-the burst support on DBDMA controller.
-
-If the used system need the USB support enable the following kernel configs for
-high IDE to USB throughput.
-
-::
-
- CONFIG_IDE_GENERIC=y
- CONFIG_BLK_DEV_IDEPCI=y
- CONFIG_BLK_DEV_GENERIC=y
- CONFIG_BLK_DEV_IDEDMA_PCI=y
- CONFIG_BLK_DEV_IDE_AU1XXX=y
- CONFIG_BLK_DEV_IDE_AU1XXX_MDMA2_DBDMA=y
- CONFIG_BLK_DEV_IDEDMA=y
-
-Also undefine 'IDE_AU1XXX_BURSTMODE' in 'drivers/ide/mips/au1xxx-ide.c' to
-disable the burst support on DBDMA controller.
-
-
-Acknowledgments
-===============
-
-These drivers wouldn't have been done without the base of kernel 2.4.x AU1XXX
-IDE driver from AMD.
-
-Additional input also from:
-Matthias Lenk <[email protected]>
-
-Happy hacking!
-
-Enrico Walther <[email protected]>
diff --git a/Documentation/mips/index.rst b/Documentation/mips/index.rst
index a93c2f65884c..d5ad8c00f0bd 100644
--- a/Documentation/mips/index.rst
+++ b/Documentation/mips/index.rst
@@ -10,8 +10,6 @@ MIPS-specific Documentation
ingenic-tcu
- au1xxx_ide
-
.. only:: subproject and html
Indices
--
2.24.1
On Thu, Jan 16, 2020 at 1:30 PM Bartlomiej Zolnierkiewicz
<[email protected]> wrote:
> Commit 54ff4a1d1732 ("MIPS: Alchemy: pata_platform for DB1200")
> from year 2014 converted the only user of au1xxx-ide IDE host
> driver (MIPS Alchemy DB1200 platform) to use pata_platform libata
> host driver instead. This patch series removes dead au1xxx-ide
> driver code & co.
For the whole series:
Acked-By: Manuel Lauss <[email protected]>
Good riddance. This driver really only worked well with the db1200
board set to a specific
cpu clock speed.
Best regards,
Manuel
Always great to kill off another legacy ide driver:
Acked-by: Christoph Hellwig <[email protected]>
Hi David & Jonathan,
On Thu, Jan 16, 2020 at 01:29:35PM +0100, Bartlomiej Zolnierkiewicz wrote:
> Since patch #2 depends on patch #1 (and it is also the best to
> apply patch #3 after driver code removal) it would be probably
> easiest to merge everything through MIPS tree (after getting
> necessary ACKs, from David for the first patch and Jonathan for
> the third one).
Does that sound good to you? If so could you ack the patches as
appropriate?
Alternatively I have no problem if you'd rather take this through the
IDE tree David, in which case for patch 2:
Acked-by: Paul Burton <[email protected]>
Thanks,
Paul
Hi Jonathan,
Gentle ping.
Can we get your ACK to merge this patch through MIPS (or IDE) tree?
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
On 1/16/20 1:29 PM, Bartlomiej Zolnierkiewicz wrote:
> Since the au1xxx-ide IDE host driver is no longer needed its documentation
> can be removed.
>
> Signed-off-by: Bartlomiej Zolnierkiewicz <[email protected]>
> ---
> Documentation/mips/au1xxx_ide.rst | 130 ------------------------------
> Documentation/mips/index.rst | 2 -
> 2 files changed, 132 deletions(-)
> delete mode 100644 Documentation/mips/au1xxx_ide.rst
>
> diff --git a/Documentation/mips/au1xxx_ide.rst b/Documentation/mips/au1xxx_ide.rst
> deleted file mode 100644
> index 2f9c2cff6738..000000000000
> --- a/Documentation/mips/au1xxx_ide.rst
> +++ /dev/null
> @@ -1,130 +0,0 @@
> -.. include:: <isonum.txt>
> -
> -======================
> -MIPS AU1XXX IDE driver
> -======================
> -
> -Released 2005-07-15
> -
> -About
> -=====
> -
> -This file describes the 'drivers/ide/au1xxx-ide.c', related files and the
> -services they provide.
> -
> -If you are short in patience and just want to know how to add your hard disc to
> -the white or black list, go to the 'ADD NEW HARD DISC TO WHITE OR BLACK LIST'
> -section.
> -
> -
> -License
> -=======
> -
> -:Copyright: |copy| 2003-2005 AMD, Personal Connectivity Solutions
> -
> -This program is free software; you can redistribute it and/or modify it under
> -the terms of the GNU General Public License as published by the Free Software
> -Foundation; either version 2 of the License, or (at your option) any later
> -version.
> -
> -THIS SOFTWARE IS PROVIDED ``AS IS`` AND ANY EXPRESS OR IMPLIED WARRANTIES,
> -INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND
> -FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE AUTHOR
> -BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
> -CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
> -SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
> -INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
> -CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
> -ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
> -POSSIBILITY OF SUCH DAMAGE.
> -
> -You should have received a copy of the GNU General Public License along with
> -this program; if not, write to the Free Software Foundation, Inc.,
> -675 Mass Ave, Cambridge, MA 02139, USA.
> -
> -Note:
> - for more information, please refer "AMD Alchemy Au1200/Au1550 IDE
> - Interface and Linux Device Driver" Application Note.
> -
> -
> -Files, Configs and Compatibility
> -================================
> -
> -Two files are introduced:
> -
> - a) 'arch/mips/include/asm/mach-au1x00/au1xxx_ide.h'
> - contains : struct _auide_hwif
> -
> - - timing parameters for PIO mode 0/1/2/3/4
> - - timing parameters for MWDMA 0/1/2
> -
> - b) 'drivers/ide/mips/au1xxx-ide.c'
> - contains the functionality of the AU1XXX IDE driver
> -
> -Following extra configs variables are introduced:
> -
> - CONFIG_BLK_DEV_IDE_AU1XXX_PIO_DBDMA
> - - enable the PIO+DBDMA mode
> - CONFIG_BLK_DEV_IDE_AU1XXX_MDMA2_DBDMA
> - - enable the MWDMA mode
> -
> -
> -Supported IDE Modes
> -===================
> -
> -The AU1XXX IDE driver supported all PIO modes - PIO mode 0/1/2/3/4 - and all
> -MWDMA modes - MWDMA 0/1/2 -. There is no support for SWDMA and UDMA mode.
> -
> -To change the PIO mode use the program hdparm with option -p, e.g.
> -'hdparm -p0 [device]' for PIO mode 0. To enable the MWDMA mode use the option
> --X, e.g. 'hdparm -X32 [device]' for MWDMA mode 0.
> -
> -
> -Performance Configurations
> -==========================
> -
> -If the used system doesn't need USB support enable the following kernel
> -configs::
> -
> - CONFIG_IDE=y
> - CONFIG_BLK_DEV_IDE=y
> - CONFIG_IDE_GENERIC=y
> - CONFIG_BLK_DEV_IDEPCI=y
> - CONFIG_BLK_DEV_GENERIC=y
> - CONFIG_BLK_DEV_IDEDMA_PCI=y
> - CONFIG_BLK_DEV_IDE_AU1XXX=y
> - CONFIG_BLK_DEV_IDE_AU1XXX_MDMA2_DBDMA=y
> - CONFIG_BLK_DEV_IDEDMA=y
> -
> -Also define 'IDE_AU1XXX_BURSTMODE' in 'drivers/ide/mips/au1xxx-ide.c' to enable
> -the burst support on DBDMA controller.
> -
> -If the used system need the USB support enable the following kernel configs for
> -high IDE to USB throughput.
> -
> -::
> -
> - CONFIG_IDE_GENERIC=y
> - CONFIG_BLK_DEV_IDEPCI=y
> - CONFIG_BLK_DEV_GENERIC=y
> - CONFIG_BLK_DEV_IDEDMA_PCI=y
> - CONFIG_BLK_DEV_IDE_AU1XXX=y
> - CONFIG_BLK_DEV_IDE_AU1XXX_MDMA2_DBDMA=y
> - CONFIG_BLK_DEV_IDEDMA=y
> -
> -Also undefine 'IDE_AU1XXX_BURSTMODE' in 'drivers/ide/mips/au1xxx-ide.c' to
> -disable the burst support on DBDMA controller.
> -
> -
> -Acknowledgments
> -===============
> -
> -These drivers wouldn't have been done without the base of kernel 2.4.x AU1XXX
> -IDE driver from AMD.
> -
> -Additional input also from:
> -Matthias Lenk <[email protected]>
> -
> -Happy hacking!
> -
> -Enrico Walther <[email protected]>
> diff --git a/Documentation/mips/index.rst b/Documentation/mips/index.rst
> index a93c2f65884c..d5ad8c00f0bd 100644
> --- a/Documentation/mips/index.rst
> +++ b/Documentation/mips/index.rst
> @@ -10,8 +10,6 @@ MIPS-specific Documentation
>
> ingenic-tcu
>
> - au1xxx_ide
> -
> .. only:: subproject and html
>
> Indices
>