2020-01-19 09:08:07

by Zenghui Yu

Subject: [PATCH] KVM: arm/arm64: vgic: Drop the kvm_vgic_register_mmio_region()

kvm_vgic_register_mmio_region() was introduced in commit 4493b1c4866a
("KVM: arm/arm64: vgic-new: Add MMIO handling framework") but never
used, and even never implemented. Remove it to avoid confusing readers.

Reported-by: Haibin Wang <[email protected]>
Signed-off-by: Zenghui Yu <[email protected]>
---
virt/kvm/arm/vgic/vgic-mmio.h | 5 -----
1 file changed, 5 deletions(-)

diff --git a/virt/kvm/arm/vgic/vgic-mmio.h b/virt/kvm/arm/vgic/vgic-mmio.h
index 836f418f1ee8..5af2aefad435 100644
--- a/virt/kvm/arm/vgic/vgic-mmio.h
+++ b/virt/kvm/arm/vgic/vgic-mmio.h
@@ -98,11 +98,6 @@ extern struct kvm_io_device_ops kvm_io_gic_ops;
.uaccess_write = uwr, \
}

-int kvm_vgic_register_mmio_region(struct kvm *kvm, struct kvm_vcpu *vcpu,
- struct vgic_register_region *reg_desc,
- struct vgic_io_device *region,
- int nr_irqs, bool offset_private);
-
unsigned long vgic_data_mmio_bus_to_host(const void *val, unsigned int len);

void vgic_data_host_to_mmio_bus(void *buf, unsigned int len,
--
2.19.1

2020-01-19 22:49:10

by Gavin Shan

Subject: Re: [PATCH] KVM: arm/arm64: vgic: Drop the kvm_vgic_register_mmio_region()

On 1/19/20 8:06 PM, Zenghui Yu wrote:
> kvm_vgic_register_mmio_region() was introduced in commit 4493b1c4866a
> ("KVM: arm/arm64: vgic-new: Add MMIO handling framework") but never
> used, and even never implemented. Remove it to avoid confusing readers.
>
> Reported-by: Haibin Wang <[email protected]>
> Signed-off-by: Zenghui Yu <[email protected]>
> ---

Reviewed-by: Gavin Shan <[email protected]>

> virt/kvm/arm/vgic/vgic-mmio.h | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/virt/kvm/arm/vgic/vgic-mmio.h b/virt/kvm/arm/vgic/vgic-mmio.h
> index 836f418f1ee8..5af2aefad435 100644
> --- a/virt/kvm/arm/vgic/vgic-mmio.h
> +++ b/virt/kvm/arm/vgic/vgic-mmio.h
> @@ -98,11 +98,6 @@ extern struct kvm_io_device_ops kvm_io_gic_ops;
> .uaccess_write = uwr, \
> }
>
> -int kvm_vgic_register_mmio_region(struct kvm *kvm, struct kvm_vcpu *vcpu,
> - struct vgic_register_region *reg_desc,
> - struct vgic_io_device *region,
> - int nr_irqs, bool offset_private);
> -
> unsigned long vgic_data_mmio_bus_to_host(const void *val, unsigned int len);
>
> void vgic_data_host_to_mmio_bus(void *buf, unsigned int len,
>