2020-01-21 11:00:54

by Masahiro Yamada

Subject: [PATCH] mmc: sdhci-cadence: remove unneeded 'inline' marker

'static inline' in .c files does not make much sense because
functions may or may not be inlined irrespective of the 'inline'
marker. It is just a hint.

This function is quite small, so very likely to be inlined by the
compiler's optimization (-O2 or -Os), but it is up to the compiler
after all.

Signed-off-by: Masahiro Yamada <[email protected]>
---

drivers/mmc/host/sdhci-cadence.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mmc/host/sdhci-cadence.c b/drivers/mmc/host/sdhci-cadence.c
index ae0ec27dd7cc..5827d3751b81 100644
--- a/drivers/mmc/host/sdhci-cadence.c
+++ b/drivers/mmc/host/sdhci-cadence.c
@@ -158,7 +158,7 @@ static int sdhci_cdns_phy_init(struct sdhci_cdns_priv *priv)
return 0;
}

-static inline void *sdhci_cdns_priv(struct sdhci_host *host)
+static void *sdhci_cdns_priv(struct sdhci_host *host)
{
struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host);

--
2.17.1

2020-01-21 11:13:05

by Adrian Hunter

Subject: Re: [PATCH] mmc: sdhci-cadence: remove unneeded 'inline' marker

On 21/01/20 12:58 pm, Masahiro Yamada wrote:
> 'static inline' in .c files does not make much sense because
> functions may or may not be inlined irrespective of the 'inline'
> marker. It is just a hint.
>
> This function is quite small, so very likely to be inlined by the
> compiler's optimization (-O2 or -Os), but it is up to the compiler
> after all.
>
> Signed-off-by: Masahiro Yamada <[email protected]>

Acked-by: Adrian Hunter <[email protected]>

> ---
>
> drivers/mmc/host/sdhci-cadence.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci-cadence.c b/drivers/mmc/host/sdhci-cadence.c
> index ae0ec27dd7cc..5827d3751b81 100644
> --- a/drivers/mmc/host/sdhci-cadence.c
> +++ b/drivers/mmc/host/sdhci-cadence.c
> @@ -158,7 +158,7 @@ static int sdhci_cdns_phy_init(struct sdhci_cdns_priv *priv)
> return 0;
> }
>
> -static inline void *sdhci_cdns_priv(struct sdhci_host *host)
> +static void *sdhci_cdns_priv(struct sdhci_host *host)
> {
> struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host);
>
>

2020-01-24 11:40:35

by Ulf Hansson

Subject: Re: [PATCH] mmc: sdhci-cadence: remove unneeded 'inline' marker

On Tue, 21 Jan 2020 at 11:59, Masahiro Yamada
<[email protected]> wrote:
>
> 'static inline' in .c files does not make much sense because
> functions may or may not be inlined irrespective of the 'inline'
> marker. It is just a hint.
>
> This function is quite small, so very likely to be inlined by the
> compiler's optimization (-O2 or -Os), but it is up to the compiler
> after all.
>
> Signed-off-by: Masahiro Yamada <[email protected]>

Applied for next, thanks!

Kind regards
Uffe


> ---
>
> drivers/mmc/host/sdhci-cadence.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci-cadence.c b/drivers/mmc/host/sdhci-cadence.c
> index ae0ec27dd7cc..5827d3751b81 100644
> --- a/drivers/mmc/host/sdhci-cadence.c
> +++ b/drivers/mmc/host/sdhci-cadence.c
> @@ -158,7 +158,7 @@ static int sdhci_cdns_phy_init(struct sdhci_cdns_priv *priv)
> return 0;
> }
>
> -static inline void *sdhci_cdns_priv(struct sdhci_host *host)
> +static void *sdhci_cdns_priv(struct sdhci_host *host)
> {
> struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host);
>
> --
> 2.17.1
>