This patch series remove unnecessary conversion to bool in dir
drivers/gpu/drm/amd/amdgpu/, which is detected by coccicheck.
Chen Zhou (14):
drm/amdgpu: remove unnecessary conversion to bool in mmhub_v1_0.c
drm/amdgpu: remove unnecessary conversion to bool in vega10_ih.c
drm/amdgpu: remove unnecessary conversion to bool in navi10_ih.c
drm/amdgpu: remove unnecessary conversion to bool in gfx_v10_0.c
drm/amdgpu: remove unnecessary conversion to bool in sdma_v5_0.c
drm/amdgpu: remove unnecessary conversion to bool in athub_v1_0.c
drm/amdgpu: remove unnecessary conversion to bool in amdgpu_acp.c
drm/amdgpu: remove unnecessary conversion to bool in soc15.c
drm/amdgpu: remove unnecessary conversion to bool in nv.c
drm/amdgpu: remove unnecessary conversion to bool in mmhub_v9_4.c
drm/amdgpu: remove unnecessary conversion to bool in amdgpu_device.c
drm/amdgpu: remove unnecessary conversion to bool in athub_v2_0.c
drm/amdgpu: remove unnecessary conversion to bool in sdma_v4_0.c
drm/amdgpu: remove unnecessary conversion to bool in gfx_v9_0.c
drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c | 2 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 8 +++-----
drivers/gpu/drm/amd/amdgpu/athub_v1_0.c | 4 ++--
drivers/gpu/drm/amd/amdgpu/athub_v2_0.c | 4 ++--
drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 4 ++--
drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 4 ++--
drivers/gpu/drm/amd/amdgpu/mmhub_v1_0.c | 4 ++--
drivers/gpu/drm/amd/amdgpu/mmhub_v2_0.c | 4 ++--
drivers/gpu/drm/amd/amdgpu/mmhub_v9_4.c | 4 ++--
drivers/gpu/drm/amd/amdgpu/navi10_ih.c | 2 +-
drivers/gpu/drm/amd/amdgpu/nv.c | 8 ++++----
drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c | 6 +++---
drivers/gpu/drm/amd/amdgpu/sdma_v5_0.c | 4 ++--
drivers/gpu/drm/amd/amdgpu/soc15.c | 28 ++++++++++++++--------------
drivers/gpu/drm/amd/amdgpu/vega10_ih.c | 2 +-
15 files changed, 43 insertions(+), 45 deletions(-)
--
2.7.4
Fixes coccicheck warning:
./drivers/gpu/drm/amd/amdgpu/vega10_ih.c:720:40-45: WARNING:
conversion to bool not needed here
Signed-off-by: Chen Zhou <[email protected]>
---
drivers/gpu/drm/amd/amdgpu/vega10_ih.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/vega10_ih.c b/drivers/gpu/drm/amd/amdgpu/vega10_ih.c
index d9e3310..407c609 100644
--- a/drivers/gpu/drm/amd/amdgpu/vega10_ih.c
+++ b/drivers/gpu/drm/amd/amdgpu/vega10_ih.c
@@ -717,7 +717,7 @@ static int vega10_ih_set_clockgating_state(void *handle,
struct amdgpu_device *adev = (struct amdgpu_device *)handle;
vega10_ih_update_clockgating_state(adev,
- state == AMD_CG_STATE_GATE ? true : false);
+ state == AMD_CG_STATE_GATE);
return 0;
}
--
2.7.4
Fixes coccicheck warning:
./drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c:530:51-56: WARNING:
conversion to bool not needed here
Signed-off-by: Chen Zhou <[email protected]>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c
index 82155ac..8008b67 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c
@@ -527,7 +527,7 @@ static int acp_set_powergating_state(void *handle,
enum amd_powergating_state state)
{
struct amdgpu_device *adev = (struct amdgpu_device *)handle;
- bool enable = state == AMD_PG_STATE_GATE ? true : false;
+ bool enable = state == AMD_PG_STATE_GATE;
if (adev->powerplay.pp_funcs &&
adev->powerplay.pp_funcs->set_powergating_by_smu)
--
2.7.4
Fixes coccicheck warning:
./drivers/gpu/drm/amd/amdgpu/nv.c:953:40-45: WARNING:
conversion to bool not needed here
and many more similar messages.
Signed-off-by: Chen Zhou <[email protected]>
---
drivers/gpu/drm/amd/amdgpu/nv.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/nv.c b/drivers/gpu/drm/amd/amdgpu/nv.c
index 2e0f893..2d1bebdf 100644
--- a/drivers/gpu/drm/amd/amdgpu/nv.c
+++ b/drivers/gpu/drm/amd/amdgpu/nv.c
@@ -950,13 +950,13 @@ static int nv_common_set_clockgating_state(void *handle,
case CHIP_NAVI14:
case CHIP_NAVI12:
adev->nbio.funcs->update_medium_grain_clock_gating(adev,
- state == AMD_CG_STATE_GATE ? true : false);
+ state == AMD_CG_STATE_GATE);
adev->nbio.funcs->update_medium_grain_light_sleep(adev,
- state == AMD_CG_STATE_GATE ? true : false);
+ state == AMD_CG_STATE_GATE);
nv_update_hdp_mem_power_gating(adev,
- state == AMD_CG_STATE_GATE ? true : false);
+ state == AMD_CG_STATE_GATE);
nv_update_hdp_clock_gating(adev,
- state == AMD_CG_STATE_GATE ? true : false);
+ state == AMD_CG_STATE_GATE);
break;
default:
break;
--
2.7.4
Fixes coccicheck warning:
./drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c:2180:40-45: WARNING
conversion to bool not needed here
and many more similar messages.
Signed-off-by: Chen Zhou <[email protected]>
---
drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c b/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c
index 01898d2..9d479a0 100644
--- a/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c
@@ -2177,9 +2177,9 @@ static int sdma_v4_0_set_clockgating_state(void *handle,
case CHIP_ARCTURUS:
case CHIP_RENOIR:
sdma_v4_0_update_medium_grain_clock_gating(adev,
- state == AMD_CG_STATE_GATE ? true : false);
+ state == AMD_CG_STATE_GATE);
sdma_v4_0_update_medium_grain_light_sleep(adev,
- state == AMD_CG_STATE_GATE ? true : false);
+ state == AMD_CG_STATE_GATE);
break;
default:
break;
@@ -2195,7 +2195,7 @@ static int sdma_v4_0_set_powergating_state(void *handle,
switch (adev->asic_type) {
case CHIP_RAVEN:
sdma_v4_1_update_power_gating(adev,
- state == AMD_PG_STATE_GATE ? true : false);
+ state == AMD_PG_STATE_GATE);
break;
default:
break;
--
2.7.4
Fixes coccicheck warning:
./drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c:4737:43-48: WARNING:
conversion to bool not needed here
Signed-off-by: Chen Zhou <[email protected]>
---
drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c
index 2f782c3..e4744ae 100644
--- a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c
@@ -4672,7 +4672,7 @@ static int gfx_v9_0_set_powergating_state(void *handle,
enum amd_powergating_state state)
{
struct amdgpu_device *adev = (struct amdgpu_device *)handle;
- bool enable = (state == AMD_PG_STATE_GATE) ? true : false;
+ bool enable = state == AMD_PG_STATE_GATE;
switch (adev->asic_type) {
case CHIP_RAVEN:
@@ -4734,7 +4734,7 @@ static int gfx_v9_0_set_clockgating_state(void *handle,
case CHIP_ARCTURUS:
case CHIP_RENOIR:
gfx_v9_0_update_gfx_clock_gating(adev,
- state == AMD_CG_STATE_GATE ? true : false);
+ state == AMD_CG_STATE_GATE);
break;
default:
break;
--
2.7.4
Fixes coccicheck warning:
./drivers/gpu/drm/amd/amdgpu/soc15.c:1474:40-45: WARNING:
conversion to bool not needed here
and many more similar messages.
Signed-off-by: Chen Zhou <[email protected]>
---
drivers/gpu/drm/amd/amdgpu/soc15.c | 28 ++++++++++++++--------------
1 file changed, 14 insertions(+), 14 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/soc15.c b/drivers/gpu/drm/amd/amdgpu/soc15.c
index a672c10..15f3424 100644
--- a/drivers/gpu/drm/amd/amdgpu/soc15.c
+++ b/drivers/gpu/drm/amd/amdgpu/soc15.c
@@ -1471,38 +1471,38 @@ static int soc15_common_set_clockgating_state(void *handle,
case CHIP_VEGA12:
case CHIP_VEGA20:
adev->nbio.funcs->update_medium_grain_clock_gating(adev,
- state == AMD_CG_STATE_GATE ? true : false);
+ state == AMD_CG_STATE_GATE);
adev->nbio.funcs->update_medium_grain_light_sleep(adev,
- state == AMD_CG_STATE_GATE ? true : false);
+ state == AMD_CG_STATE_GATE);
soc15_update_hdp_light_sleep(adev,
- state == AMD_CG_STATE_GATE ? true : false);
+ state == AMD_CG_STATE_GATE);
soc15_update_drm_clock_gating(adev,
- state == AMD_CG_STATE_GATE ? true : false);
+ state == AMD_CG_STATE_GATE);
soc15_update_drm_light_sleep(adev,
- state == AMD_CG_STATE_GATE ? true : false);
+ state == AMD_CG_STATE_GATE);
soc15_update_rom_medium_grain_clock_gating(adev,
- state == AMD_CG_STATE_GATE ? true : false);
+ state == AMD_CG_STATE_GATE);
adev->df.funcs->update_medium_grain_clock_gating(adev,
- state == AMD_CG_STATE_GATE ? true : false);
+ state == AMD_CG_STATE_GATE);
break;
case CHIP_RAVEN:
case CHIP_RENOIR:
adev->nbio.funcs->update_medium_grain_clock_gating(adev,
- state == AMD_CG_STATE_GATE ? true : false);
+ state == AMD_CG_STATE_GATE);
adev->nbio.funcs->update_medium_grain_light_sleep(adev,
- state == AMD_CG_STATE_GATE ? true : false);
+ state == AMD_CG_STATE_GATE);
soc15_update_hdp_light_sleep(adev,
- state == AMD_CG_STATE_GATE ? true : false);
+ state == AMD_CG_STATE_GATE);
soc15_update_drm_clock_gating(adev,
- state == AMD_CG_STATE_GATE ? true : false);
+ state == AMD_CG_STATE_GATE);
soc15_update_drm_light_sleep(adev,
- state == AMD_CG_STATE_GATE ? true : false);
+ state == AMD_CG_STATE_GATE);
soc15_update_rom_medium_grain_clock_gating(adev,
- state == AMD_CG_STATE_GATE ? true : false);
+ state == AMD_CG_STATE_GATE);
break;
case CHIP_ARCTURUS:
soc15_update_hdp_light_sleep(adev,
- state == AMD_CG_STATE_GATE ? true : false);
+ state == AMD_CG_STATE_GATE);
break;
default:
break;
--
2.7.4
Fixes coccicheck warning:
./drivers/gpu/drm/amd/amdgpu/athub_v2_0.c:80:40-45: WARNING:
conversion to bool not needed here
./drivers/gpu/drm/amd/amdgpu/athub_v2_0.c:82:40-45: WARNING:
conversion to bool not needed here
Signed-off-by: Chen Zhou <[email protected]>
---
drivers/gpu/drm/amd/amdgpu/athub_v2_0.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/athub_v2_0.c b/drivers/gpu/drm/amd/amdgpu/athub_v2_0.c
index ceb9aa4..921a69a 100644
--- a/drivers/gpu/drm/amd/amdgpu/athub_v2_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/athub_v2_0.c
@@ -77,9 +77,9 @@ int athub_v2_0_set_clockgating(struct amdgpu_device *adev,
case CHIP_NAVI14:
case CHIP_NAVI12:
athub_v2_0_update_medium_grain_clock_gating(adev,
- state == AMD_CG_STATE_GATE ? true : false);
+ state == AMD_CG_STATE_GATE);
athub_v2_0_update_medium_grain_light_sleep(adev,
- state == AMD_CG_STATE_GATE ? true : false);
+ state == AMD_CG_STATE_GATE);
break;
default:
break;
--
2.7.4
Fixes coccicheck warning:
./drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:2883:68-73: WARNING:
conversion to bool not needed here
and many more similar messages.
Signed-off-by: Chen Zhou <[email protected]>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
index 1f0e6b9..29b54d4 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
@@ -986,7 +986,7 @@ static void amdgpu_device_check_vm_size(struct amdgpu_device *adev)
static void amdgpu_device_check_smu_prv_buffer_size(struct amdgpu_device *adev)
{
struct sysinfo si;
- bool is_os_64 = (sizeof(void *) == 8) ? true : false;
+ bool is_os_64 = sizeof(void *) == 8;
uint64_t total_memory;
uint64_t dram_size_seven_GB = 0x1B8000000;
uint64_t dram_size_three_GB = 0xB8000000;
@@ -2881,7 +2881,7 @@ int amdgpu_device_init(struct amdgpu_device *adev,
INIT_WORK(&adev->xgmi_reset_work, amdgpu_device_xgmi_reset_func);
adev->gfx.gfx_off_req_count = 1;
- adev->pm.ac_power = power_supply_is_system_supplied() > 0 ? true : false;
+ adev->pm.ac_power = power_supply_is_system_supplied() > 0;
/* Registers mapping */
/* TODO: block userspace mapping of io register */
@@ -3999,9 +3999,7 @@ int amdgpu_device_gpu_recover(struct amdgpu_device *adev,
struct amdgpu_device *tmp_adev = NULL;
int i, r = 0;
bool in_ras_intr = amdgpu_ras_intr_triggered();
- bool use_baco =
- (amdgpu_asic_reset_method(adev) == AMD_RESET_METHOD_BACO) ?
- true : false;
+ bool use_baco = amdgpu_asic_reset_method(adev) == AMD_RESET_METHOD_BACO;
/*
* Flush RAM to disk so that after reboot
--
2.7.4
Fixes coccicheck warning:
./drivers/gpu/drm/amd/amdgpu/athub_v1_0.c:77:40-45: WARNING:
conversion to bool not needed here
./drivers/gpu/drm/amd/amdgpu/athub_v1_0.c:79:40-45: WARNING:
conversion to bool not needed here
Signed-off-by: Chen Zhou <[email protected]>
---
drivers/gpu/drm/amd/amdgpu/athub_v1_0.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/athub_v1_0.c b/drivers/gpu/drm/amd/amdgpu/athub_v1_0.c
index d9cc746..847ca9b 100644
--- a/drivers/gpu/drm/amd/amdgpu/athub_v1_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/athub_v1_0.c
@@ -74,9 +74,9 @@ int athub_v1_0_set_clockgating(struct amdgpu_device *adev,
case CHIP_VEGA20:
case CHIP_RAVEN:
athub_update_medium_grain_clock_gating(adev,
- state == AMD_CG_STATE_GATE ? true : false);
+ state == AMD_CG_STATE_GATE);
athub_update_medium_grain_light_sleep(adev,
- state == AMD_CG_STATE_GATE ? true : false);
+ state == AMD_CG_STATE_GATE);
break;
default:
break;
--
2.7.4
Fixes coccicheck warning:
./drivers/gpu/drm/amd/amdgpu/navi10_ih.c:429:40-45: WARNING:
conversion to bool not needed here
Signed-off-by: Chen Zhou <[email protected]>
---
drivers/gpu/drm/amd/amdgpu/navi10_ih.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/navi10_ih.c b/drivers/gpu/drm/amd/amdgpu/navi10_ih.c
index f737ce4..cf557a42 100644
--- a/drivers/gpu/drm/amd/amdgpu/navi10_ih.c
+++ b/drivers/gpu/drm/amd/amdgpu/navi10_ih.c
@@ -426,7 +426,7 @@ static int navi10_ih_set_clockgating_state(void *handle,
struct amdgpu_device *adev = (struct amdgpu_device *)handle;
navi10_ih_update_clockgating_state(adev,
- state == AMD_CG_STATE_GATE ? true : false);
+ state == AMD_CG_STATE_GATE);
return 0;
}
--
2.7.4
Fixes coccicheck warning:
./drivers/gpu/drm/amd/amdgpu/mmhub_v9_4.c:628:40-45: WARNING:
conversion to bool not needed here
./drivers/gpu/drm/amd/amdgpu/mmhub_v9_4.c:630:40-45: WARNING:
conversion to bool not needed here
Signed-off-by: Chen Zhou <[email protected]>
---
drivers/gpu/drm/amd/amdgpu/mmhub_v9_4.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/mmhub_v9_4.c b/drivers/gpu/drm/amd/amdgpu/mmhub_v9_4.c
index 5c42387..b1f30d6 100644
--- a/drivers/gpu/drm/amd/amdgpu/mmhub_v9_4.c
+++ b/drivers/gpu/drm/amd/amdgpu/mmhub_v9_4.c
@@ -625,9 +625,9 @@ int mmhub_v9_4_set_clockgating(struct amdgpu_device *adev,
switch (adev->asic_type) {
case CHIP_ARCTURUS:
mmhub_v9_4_update_medium_grain_clock_gating(adev,
- state == AMD_CG_STATE_GATE ? true : false);
+ state == AMD_CG_STATE_GATE);
mmhub_v9_4_update_medium_grain_light_sleep(adev,
- state == AMD_CG_STATE_GATE ? true : false);
+ state == AMD_CG_STATE_GATE);
break;
default:
break;
--
2.7.4
Fixes coccicheck warning:
./drivers/gpu/drm/amd/amdgpu/mmhub_v1_0.c:526:40-45: WARNING:
conversion to bool not needed here
./drivers/gpu/drm/amd/amdgpu/mmhub_v1_0.c:528:40-45: WARNING:
conversion to bool not needed here
Signed-off-by: Chen Zhou <[email protected]>
---
drivers/gpu/drm/amd/amdgpu/mmhub_v1_0.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/mmhub_v1_0.c b/drivers/gpu/drm/amd/amdgpu/mmhub_v1_0.c
index adfd8a6..49a3a56 100644
--- a/drivers/gpu/drm/amd/amdgpu/mmhub_v1_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/mmhub_v1_0.c
@@ -523,9 +523,9 @@ int mmhub_v1_0_set_clockgating(struct amdgpu_device *adev,
case CHIP_RAVEN:
case CHIP_RENOIR:
mmhub_v1_0_update_medium_grain_clock_gating(adev,
- state == AMD_CG_STATE_GATE ? true : false);
+ state == AMD_CG_STATE_GATE);
mmhub_v1_0_update_medium_grain_light_sleep(adev,
- state == AMD_CG_STATE_GATE ? true : false);
+ state == AMD_CG_STATE_GATE);
break;
default:
break;
--
2.7.4
Fixes coccicheck warning:
./drivers/gpu/drm/amd/amdgpu/sdma_v5_0.c:1528:40-45: WARNING:
conversion to bool not needed here
./drivers/gpu/drm/amd/amdgpu/sdma_v5_0.c:1530:40-45: WARNING:
conversion to bool not needed here
Signed-off-by: Chen Zhou <[email protected]>
---
drivers/gpu/drm/amd/amdgpu/sdma_v5_0.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/sdma_v5_0.c b/drivers/gpu/drm/amd/amdgpu/sdma_v5_0.c
index 3912937..7ee603d 100644
--- a/drivers/gpu/drm/amd/amdgpu/sdma_v5_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/sdma_v5_0.c
@@ -1525,9 +1525,9 @@ static int sdma_v5_0_set_clockgating_state(void *handle,
case CHIP_NAVI14:
case CHIP_NAVI12:
sdma_v5_0_update_medium_grain_clock_gating(adev,
- state == AMD_CG_STATE_GATE ? true : false);
+ state == AMD_CG_STATE_GATE);
sdma_v5_0_update_medium_grain_light_sleep(adev,
- state == AMD_CG_STATE_GATE ? true : false);
+ state == AMD_CG_STATE_GATE);
break;
default:
break;
--
2.7.4
Fixes coccicheck warning:
./drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c:4259:43-48: WARNING:
conversion to bool not needed here
and many more similar messages.
Signed-off-by: Chen Zhou <[email protected]>
---
drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 4 ++--
drivers/gpu/drm/amd/amdgpu/mmhub_v2_0.c | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c
index 1cfc508..3da9d79 100644
--- a/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c
@@ -4230,7 +4230,7 @@ static int gfx_v10_0_set_powergating_state(void *handle,
enum amd_powergating_state state)
{
struct amdgpu_device *adev = (struct amdgpu_device *)handle;
- bool enable = (state == AMD_PG_STATE_GATE) ? true : false;
+ bool enable = state == AMD_PG_STATE_GATE;
switch (adev->asic_type) {
case CHIP_NAVI10:
case CHIP_NAVI14:
@@ -4256,7 +4256,7 @@ static int gfx_v10_0_set_clockgating_state(void *handle,
case CHIP_NAVI14:
case CHIP_NAVI12:
gfx_v10_0_update_gfx_clock_gating(adev,
- state == AMD_CG_STATE_GATE ? true : false);
+ state == AMD_CG_STATE_GATE);
break;
default:
break;
diff --git a/drivers/gpu/drm/amd/amdgpu/mmhub_v2_0.c b/drivers/gpu/drm/amd/amdgpu/mmhub_v2_0.c
index a7cb185..bde1896 100644
--- a/drivers/gpu/drm/amd/amdgpu/mmhub_v2_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/mmhub_v2_0.c
@@ -427,9 +427,9 @@ int mmhub_v2_0_set_clockgating(struct amdgpu_device *adev,
case CHIP_NAVI14:
case CHIP_NAVI12:
mmhub_v2_0_update_medium_grain_clock_gating(adev,
- state == AMD_CG_STATE_GATE ? true : false);
+ state == AMD_CG_STATE_GATE);
mmhub_v2_0_update_medium_grain_light_sleep(adev,
- state == AMD_CG_STATE_GATE ? true : false);
+ state == AMD_CG_STATE_GATE);
break;
default:
break;
--
2.7.4
On Tue, Jan 21, 2020 at 11:08 AM Chen Zhou <[email protected]> wrote:
>
> This patch series remove unnecessary conversion to bool in dir
> drivers/gpu/drm/amd/amdgpu/, which is detected by coccicheck.
Thanks for the patches. Already applied this patch:
https://patchwork.freedesktop.org/series/72281/#rev2
which covers these.
Alex
>
> Chen Zhou (14):
> drm/amdgpu: remove unnecessary conversion to bool in mmhub_v1_0.c
> drm/amdgpu: remove unnecessary conversion to bool in vega10_ih.c
> drm/amdgpu: remove unnecessary conversion to bool in navi10_ih.c
> drm/amdgpu: remove unnecessary conversion to bool in gfx_v10_0.c
> drm/amdgpu: remove unnecessary conversion to bool in sdma_v5_0.c
> drm/amdgpu: remove unnecessary conversion to bool in athub_v1_0.c
> drm/amdgpu: remove unnecessary conversion to bool in amdgpu_acp.c
> drm/amdgpu: remove unnecessary conversion to bool in soc15.c
> drm/amdgpu: remove unnecessary conversion to bool in nv.c
> drm/amdgpu: remove unnecessary conversion to bool in mmhub_v9_4.c
> drm/amdgpu: remove unnecessary conversion to bool in amdgpu_device.c
> drm/amdgpu: remove unnecessary conversion to bool in athub_v2_0.c
> drm/amdgpu: remove unnecessary conversion to bool in sdma_v4_0.c
> drm/amdgpu: remove unnecessary conversion to bool in gfx_v9_0.c
>
> drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c | 2 +-
> drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 8 +++-----
> drivers/gpu/drm/amd/amdgpu/athub_v1_0.c | 4 ++--
> drivers/gpu/drm/amd/amdgpu/athub_v2_0.c | 4 ++--
> drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 4 ++--
> drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 4 ++--
> drivers/gpu/drm/amd/amdgpu/mmhub_v1_0.c | 4 ++--
> drivers/gpu/drm/amd/amdgpu/mmhub_v2_0.c | 4 ++--
> drivers/gpu/drm/amd/amdgpu/mmhub_v9_4.c | 4 ++--
> drivers/gpu/drm/amd/amdgpu/navi10_ih.c | 2 +-
> drivers/gpu/drm/amd/amdgpu/nv.c | 8 ++++----
> drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c | 6 +++---
> drivers/gpu/drm/amd/amdgpu/sdma_v5_0.c | 4 ++--
> drivers/gpu/drm/amd/amdgpu/soc15.c | 28 ++++++++++++++--------------
> drivers/gpu/drm/amd/amdgpu/vega10_ih.c | 2 +-
> 15 files changed, 43 insertions(+), 45 deletions(-)
>
> --
> 2.7.4
>
> _______________________________________________
> amd-gfx mailing list
> [email protected]
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx