2020-01-22 07:22:59

by Hongbo Yao

Subject: [PATCH -next] tee: amdtee: amdtee depends on CRYPTO_DEV_CCP_DD

If CRYPTO_DEV_CCP_DD=m and AMDTEE=y, the following error is seen
while building call.c or core.c

drivers/tee/amdtee/call.o: In function `handle_unload_ta':
call.c:(.text+0x35f): undefined reference to `psp_tee_process_cmd'
drivers/tee/amdtee/core.o: In function `amdtee_driver_init':
core.c:(.init.text+0xf): undefined reference to `psp_check_tee_status

Fix the config dependency for AMDTEE here.

Reported-by: Hulk Robot <[email protected]>
Fixes: 757cc3e9ff ("tee: add AMD-TEE driver")
Signed-off-by: Hongbo Yao <[email protected]>
---
drivers/tee/amdtee/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/tee/amdtee/Kconfig b/drivers/tee/amdtee/Kconfig
index 4e32b6413b41..191f9715fa9a 100644
--- a/drivers/tee/amdtee/Kconfig
+++ b/drivers/tee/amdtee/Kconfig
@@ -3,6 +3,6 @@
config AMDTEE
tristate "AMD-TEE"
default m
- depends on CRYPTO_DEV_SP_PSP
+ depends on CRYPTO_DEV_SP_PSP && CRYPTO_DEV_CCP_DD
help
This implements AMD's Trusted Execution Environment (TEE) driver.
--
2.20.1

2020-01-22 09:05:59

by Rijo Thomas

Subject: Re: [PATCH -next] tee: amdtee: amdtee depends on CRYPTO_DEV_CCP_DD

+Deva, Herbert

Hi Hongbo,

On 22/01/20 12:46 pm, Hongbo Yao wrote:
> If CRYPTO_DEV_CCP_DD=m and AMDTEE=y, the following error is seen
> while building call.c or core.c
>
> drivers/tee/amdtee/call.o: In function `handle_unload_ta':
> call.c:(.text+0x35f): undefined reference to `psp_tee_process_cmd'
> drivers/tee/amdtee/core.o: In function `amdtee_driver_init':
> core.c:(.init.text+0xf): undefined reference to `psp_check_tee_status
>
> Fix the config dependency for AMDTEE here.
>
> Reported-by: Hulk Robot <[email protected]>
> Fixes: 757cc3e9ff ("tee: add AMD-TEE driver")
> Signed-off-by: Hongbo Yao <[email protected]>

Reviewed-by: Rijo Thomas <[email protected]>

You may have to resubmit this patch to linux-crypto list, so that it shows
up in patchwork and applied to cryptodev-2.6 tree

Thanks,
Rijo

> ---
> drivers/tee/amdtee/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/tee/amdtee/Kconfig b/drivers/tee/amdtee/Kconfig
> index 4e32b6413b41..191f9715fa9a 100644
> --- a/drivers/tee/amdtee/Kconfig
> +++ b/drivers/tee/amdtee/Kconfig
> @@ -3,6 +3,6 @@
> config AMDTEE
> tristate "AMD-TEE"
> default m
> - depends on CRYPTO_DEV_SP_PSP
> + depends on CRYPTO_DEV_SP_PSP && CRYPTO_DEV_CCP_DD
> help
> This implements AMD's Trusted Execution Environment (TEE) driver.
>