In the flowtable documentation there is a missing semicolon, the command
as is would give this error:
nftables.conf:5:27-33: Error: syntax error, unexpected devices, expecting newline or semicolon
hook ingress priority 0 devices = { br0, pppoe-data };
^^^^^^^
nftables.conf:4:12-13: Error: invalid hook (null)
flowtable ft {
^^
Fixes: 19b351f16fd9 ("netfilter: add flowtable documentation")
Signed-off-by: Matteo Croce <[email protected]>
---
Documentation/networking/nf_flowtable.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/networking/nf_flowtable.txt b/Documentation/networking/nf_flowtable.txt
index ca2136c76042..0bf32d1121be 100644
--- a/Documentation/networking/nf_flowtable.txt
+++ b/Documentation/networking/nf_flowtable.txt
@@ -76,7 +76,7 @@ flowtable and add one rule to your forward chain.
table inet x {
flowtable f {
- hook ingress priority 0 devices = { eth0, eth1 };
+ hook ingress priority 0; devices = { eth0, eth1 };
}
chain y {
type filter hook forward priority 0; policy accept;
--
2.24.1
On Thu, 30 Jan 2020 20:10:19 +0100, Matteo Croce wrote:
> In the flowtable documentation there is a missing semicolon, the command
> as is would give this error:
>
> nftables.conf:5:27-33: Error: syntax error, unexpected devices, expecting newline or semicolon
> hook ingress priority 0 devices = { br0, pppoe-data };
> ^^^^^^^
> nftables.conf:4:12-13: Error: invalid hook (null)
> flowtable ft {
> ^^
>
> Fixes: 19b351f16fd9 ("netfilter: add flowtable documentation")
> Signed-off-by: Matteo Croce <[email protected]>
This is netfilter so even though it's tagged as net, I'm expecting
Pablo (or Jon) to take it. Please LMK if I'm wrong.
On Thu, Jan 30, 2020 at 11:14 PM Jakub Kicinski <[email protected]> wrote:
>
> On Thu, 30 Jan 2020 20:10:19 +0100, Matteo Croce wrote:
> > In the flowtable documentation there is a missing semicolon, the command
> > as is would give this error:
> >
> > nftables.conf:5:27-33: Error: syntax error, unexpected devices, expecting newline or semicolon
> > hook ingress priority 0 devices = { br0, pppoe-data };
> > ^^^^^^^
> > nftables.conf:4:12-13: Error: invalid hook (null)
> > flowtable ft {
> > ^^
> >
> > Fixes: 19b351f16fd9 ("netfilter: add flowtable documentation")
> > Signed-off-by: Matteo Croce <[email protected]>
>
> This is netfilter so even though it's tagged as net, I'm expecting
> Pablo (or Jon) to take it. Please LMK if I'm wrong.
>
You're right.
As get_maintainers.pl didn't list [email protected] I missed it.
--
Matteo Croce
per aspera ad upstream
On Thu, Jan 30, 2020 at 08:10:19PM +0100, Matteo Croce wrote:
> In the flowtable documentation there is a missing semicolon, the command
> as is would give this error:
>
> nftables.conf:5:27-33: Error: syntax error, unexpected devices, expecting newline or semicolon
> hook ingress priority 0 devices = { br0, pppoe-data };
> ^^^^^^^
> nftables.conf:4:12-13: Error: invalid hook (null)
> flowtable ft {
> ^^
Applied, thanks.