2020-02-07 07:23:55

by youling 257

[permalink] [raw]
Subject: Re: [PATCH v2 20/27] compat_ioctl: simplify the implementation

This patch cause a problem on 64bit kernel 32bit userspace.
My 32bit Androidx86 userspace run on 64bit mainline kernel, this patch caused some app not detect root permission.


2020-02-07 17:09:29

by Arnd Bergmann

[permalink] [raw]
Subject: Re: [PATCH v2 20/27] compat_ioctl: simplify the implementation

On Fri, Feb 7, 2020 at 8:22 AM youling257 <[email protected]> wrote:
>
> This patch cause a problem on 64bit kernel 32bit userspace.
> My 32bit Androidx86 userspace run on 64bit mainline kernel, this patch caused some app not detect root permission.

Thanks for you work in bisecting the issue to my patch, sorry to have
caused you trouble. After Christian Zigotzky
also reported a problem in this file, I have been able to find a
specific bug and just submitted a patch for it.

Please have a look if that fix addresses your problem, as it's
possible that there was more than one bug introduced
by the original patch.

Arnd

2020-02-07 20:03:46

by youling 257

[permalink] [raw]
Subject: Re: [PATCH v2 20/27] compat_ioctl: simplify the implementation

Test [PATCH] compat_ioctl: fix FIONREAD on devices, fixed my problem.

2020-02-08 1:06 GMT+08:00, Arnd Bergmann <[email protected]>:
> On Fri, Feb 7, 2020 at 8:22 AM youling257 <[email protected]> wrote:
>>
>> This patch cause a problem on 64bit kernel 32bit userspace.
>> My 32bit Androidx86 userspace run on 64bit mainline kernel, this patch
>> caused some app not detect root permission.
>
> Thanks for you work in bisecting the issue to my patch, sorry to have
> caused you trouble. After Christian Zigotzky
> also reported a problem in this file, I have been able to find a
> specific bug and just submitted a patch for it.
>
> Please have a look if that fix addresses your problem, as it's
> possible that there was more than one bug introduced
> by the original patch.
>
> Arnd
>