2020-02-11 12:45:08

by Balakrishna Godavarthi

Subject: [PATCH v1] arm64: dts: qcom: sc7180: Add node for bluetooth soc wcn3990

Add node for bluetooth soc wcn3990.

Signed-off-by: Balakrishna Godavarthi <[email protected]>
---
arch/arm64/boot/dts/qcom/sc7180-idp.dts | 11 +++++++++++
1 file changed, 11 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/sc7180-idp.dts b/arch/arm64/boot/dts/qcom/sc7180-idp.dts
index 388f50ad4fde..19f82ddc1f09 100644
--- a/arch/arm64/boot/dts/qcom/sc7180-idp.dts
+++ b/arch/arm64/boot/dts/qcom/sc7180-idp.dts
@@ -19,6 +19,7 @@
aliases {
hsuart0 = &uart3;
serial0 = &uart8;
+ bluetooth0 = &bluetooth;
};

chosen {
@@ -256,6 +257,16 @@

&uart3 {
status = "okay";
+ bluetooth: wcn3990-bt {
+ compatible = "qcom,wcn3990-bt";
+ vddio-supply = <&vreg_l10a_1p8>;
+ vddxo-supply = <&vreg_l1c_1p8>;
+ vddrf-supply = <&vreg_l2c_1p3>;
+ vddch0-supply = <&vreg_l10c_3p3>;
+ max-speed = <3200000>;
+ clocks = <&rpmhcc RPMH_RF_CLK2>;
+ status = "okay";
+ };
};

&uart8 {
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

2020-02-11 21:03:37

by Matthias Kaehlcke

Subject: Re: [PATCH v1] arm64: dts: qcom: sc7180: Add node for bluetooth soc wcn3990

On Tue, Feb 11, 2020 at 05:46:12PM +0530, Balakrishna Godavarthi wrote:

> subject: arm64: dts: qcom: sc7180: Add node for bluetooth soc wcn3990

Preferably say in the subjct that the node is added for the IDP board.

> Add node for bluetooth soc wcn3990.
>
> Signed-off-by: Balakrishna Godavarthi <[email protected]>
> ---
> arch/arm64/boot/dts/qcom/sc7180-idp.dts | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc7180-idp.dts b/arch/arm64/boot/dts/qcom/sc7180-idp.dts
> index 388f50ad4fde..19f82ddc1f09 100644
> --- a/arch/arm64/boot/dts/qcom/sc7180-idp.dts
> +++ b/arch/arm64/boot/dts/qcom/sc7180-idp.dts
> @@ -19,6 +19,7 @@
> aliases {
> hsuart0 = &uart3;
> serial0 = &uart8;
> + bluetooth0 = &bluetooth;
> };
>
> chosen {
> @@ -256,6 +257,16 @@
>
> &uart3 {
> status = "okay";

nit: add a blank line

> + bluetooth: wcn3990-bt {
> + compatible = "qcom,wcn3990-bt";
> + vddio-supply = <&vreg_l10a_1p8>;
> + vddxo-supply = <&vreg_l1c_1p8>;
> + vddrf-supply = <&vreg_l2c_1p3>;
> + vddch0-supply = <&vreg_l10c_3p3>;
> + max-speed = <3200000>;
> + clocks = <&rpmhcc RPMH_RF_CLK2>;
> + status = "okay";

status is not needed here AFAIK.

2020-02-12 06:26:06

by Balakrishna Godavarthi

Subject: Re: [PATCH v1] arm64: dts: qcom: sc7180: Add node for bluetooth soc wcn3990

Hi Matthias,


On 2020-02-11 23:03, Matthias Kaehlcke wrote:
> On Tue, Feb 11, 2020 at 05:46:12PM +0530, Balakrishna Godavarthi wrote:
>
>> subject: arm64: dts: qcom: sc7180: Add node for bluetooth soc wcn3990
>
> Preferably say in the subjct that the node is added for the IDP board.
>
[Bala]: will update

>> Add node for bluetooth soc wcn3990.
>>
>> Signed-off-by: Balakrishna Godavarthi <[email protected]>
>> ---
>> arch/arm64/boot/dts/qcom/sc7180-idp.dts | 11 +++++++++++
>> 1 file changed, 11 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sc7180-idp.dts
>> b/arch/arm64/boot/dts/qcom/sc7180-idp.dts
>> index 388f50ad4fde..19f82ddc1f09 100644
>> --- a/arch/arm64/boot/dts/qcom/sc7180-idp.dts
>> +++ b/arch/arm64/boot/dts/qcom/sc7180-idp.dts
>> @@ -19,6 +19,7 @@
>> aliases {
>> hsuart0 = &uart3;
>> serial0 = &uart8;
>> + bluetooth0 = &bluetooth;
>> };
>>
>> chosen {
>> @@ -256,6 +257,16 @@
>>
>> &uart3 {
>> status = "okay";
>
> nit: add a blank line
>

[Bala]: will update

>> + bluetooth: wcn3990-bt {
>> + compatible = "qcom,wcn3990-bt";
>> + vddio-supply = <&vreg_l10a_1p8>;
>> + vddxo-supply = <&vreg_l1c_1p8>;
>> + vddrf-supply = <&vreg_l2c_1p3>;
>> + vddch0-supply = <&vreg_l10c_3p3>;
>> + max-speed = <3200000>;
>> + clocks = <&rpmhcc RPMH_RF_CLK2>;
>> + status = "okay";
>
> status is not needed here AFAIK.
[Bala]: true, will update