2020-02-22 23:33:39

by Ondřej Jirman

Subject: [PATCH] Support Castles Vega5000 PoS terminal USB

This terminal's USB port needs NO_UNION_NORMAL quirk to work with
cdc-acm driver.

Signed-off-by: Ondrej Jirman <[email protected]>
---
drivers/usb/class/cdc-acm.c | 3 +++
1 file changed, 3 insertions(+)

diff --git a/drivers/usb/class/cdc-acm.c b/drivers/usb/class/cdc-acm.c
index 62f4fb9b362f1..8577441c81a4d 100644
--- a/drivers/usb/class/cdc-acm.c
+++ b/drivers/usb/class/cdc-acm.c
@@ -1739,6 +1739,9 @@ static const struct usb_device_id acm_ids[] = {
{ USB_DEVICE(0x22b8, 0x2d9a), /* modem + AT port + diagnostics + NMEA */
.driver_info = NO_UNION_NORMAL, /* handle only modem interface */
},
+ { USB_DEVICE(0x0ca6, 0xa050), /* Castles Technology VEGA 5000 */
+ .driver_info = NO_UNION_NORMAL, /* reports zero length descriptor */
+ },

{ USB_DEVICE(0x0572, 0x1329), /* Hummingbird huc56s (Conexant) */
.driver_info = NO_UNION_NORMAL, /* union descriptor misplaced on
--
2.25.1

2020-02-23 03:09:07

by Lars Melin

Subject: Re: [PATCH] Support Castles Vega5000 PoS terminal USB

On 2/23/2020 06:32, Ondrej Jirman wrote:
> This terminal's USB port needs NO_UNION_NORMAL quirk to work with
> cdc-acm driver.
>
> Signed-off-by: Ondrej Jirman <[email protected]>
> ---
> drivers/usb/class/cdc-acm.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/usb/class/cdc-acm.c b/drivers/usb/class/cdc-acm.c
> index 62f4fb9b362f1..8577441c81a4d 100644
> --- a/drivers/usb/class/cdc-acm.c
> +++ b/drivers/usb/class/cdc-acm.c
> @@ -1739,6 +1739,9 @@ static const struct usb_device_id acm_ids[] = {
> { USB_DEVICE(0x22b8, 0x2d9a), /* modem + AT port + diagnostics + NMEA */
> .driver_info = NO_UNION_NORMAL, /* handle only modem interface */
> },
> + { USB_DEVICE(0x0ca6, 0xa050), /* Castles Technology VEGA 5000 */
> + .driver_info = NO_UNION_NORMAL, /* reports zero length descriptor */
> + },
>
> { USB_DEVICE(0x0572, 0x1329), /* Hummingbird huc56s (Conexant) */
> .driver_info = NO_UNION_NORMAL, /* union de

This quirk is in the driver since almost a year ago.

br
/Lars

2020-02-23 10:21:04

by Ondřej Jirman

Subject: Re: [PATCH] Support Castles Vega5000 PoS terminal USB

Hello,

On Sun, Feb 23, 2020 at 10:08:04AM +0700, Lars Melin wrote:
> On 2/23/2020 06:32, Ondrej Jirman wrote:
> > This terminal's USB port needs NO_UNION_NORMAL quirk to work with
> > cdc-acm driver.
> >
> > Signed-off-by: Ondrej Jirman <[email protected]>
> > ---
> > drivers/usb/class/cdc-acm.c | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/drivers/usb/class/cdc-acm.c b/drivers/usb/class/cdc-acm.c
> > index 62f4fb9b362f1..8577441c81a4d 100644
> > --- a/drivers/usb/class/cdc-acm.c
> > +++ b/drivers/usb/class/cdc-acm.c
> > @@ -1739,6 +1739,9 @@ static const struct usb_device_id acm_ids[] = {
> > { USB_DEVICE(0x22b8, 0x2d9a), /* modem + AT port + diagnostics + NMEA */
> > .driver_info = NO_UNION_NORMAL, /* handle only modem interface */
> > },
> > + { USB_DEVICE(0x0ca6, 0xa050), /* Castles Technology VEGA 5000 */
> > + .driver_info = NO_UNION_NORMAL, /* reports zero length descriptor */
> > + },
> > { USB_DEVICE(0x0572, 0x1329), /* Hummingbird huc56s (Conexant) */
> > .driver_info = NO_UNION_NORMAL, /* union de
>
> This quirk is in the driver since almost a year ago.

You're right. Thank you.

I held to the patch for way too long, and didn't notice someone else patched
it in the meantime.

regards,
o.

> br
> /Lars
>