match next line with open parentheses by giving appropriate tabs.
Signed-off-by: Kaaira Gupta <[email protected]>
---
drivers/staging/wfx/data_tx.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/wfx/data_tx.c b/drivers/staging/wfx/data_tx.c
index 20f4740734f2..815fde0913f5 100644
--- a/drivers/staging/wfx/data_tx.c
+++ b/drivers/staging/wfx/data_tx.c
@@ -300,8 +300,8 @@ static void wfx_tx_manage_pm(struct wfx_vif *wvif, struct ieee80211_hdr *hdr,
}
static u8 wfx_tx_get_raw_link_id(struct wfx_vif *wvif,
- struct ieee80211_sta *sta,
- struct ieee80211_hdr *hdr)
+ struct ieee80211_sta *sta,
+ struct ieee80211_hdr *hdr)
{
struct wfx_sta_priv *sta_priv =
sta ? (struct wfx_sta_priv *) &sta->drv_priv : NULL;
@@ -368,7 +368,7 @@ static void wfx_tx_fixup_rates(struct ieee80211_tx_rate *rates)
}
static u8 wfx_tx_get_rate_id(struct wfx_vif *wvif,
- struct ieee80211_tx_info *tx_info)
+ struct ieee80211_tx_info *tx_info)
{
bool tx_policy_renew = false;
u8 rate_id;
--
2.17.1
On Sunday 23 February 2020 20:32:01 CET Kaaira Gupta wrote:
>
> match next line with open parentheses by giving appropriate tabs.
Maybe the body of the commit message should start with a capital letter,
else:
Reviewed-by: J?r?me Pouiller <[email protected]>
>
> Signed-off-by: Kaaira Gupta <[email protected]>
> ---
> drivers/staging/wfx/data_tx.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/wfx/data_tx.c b/drivers/staging/wfx/data_tx.c
> index 20f4740734f2..815fde0913f5 100644
> --- a/drivers/staging/wfx/data_tx.c
> +++ b/drivers/staging/wfx/data_tx.c
> @@ -300,8 +300,8 @@ static void wfx_tx_manage_pm(struct wfx_vif *wvif, struct ieee80211_hdr *hdr,
> }
>
> static u8 wfx_tx_get_raw_link_id(struct wfx_vif *wvif,
> - struct ieee80211_sta *sta,
> - struct ieee80211_hdr *hdr)
> + struct ieee80211_sta *sta,
> + struct ieee80211_hdr *hdr)
> {
> struct wfx_sta_priv *sta_priv =
> sta ? (struct wfx_sta_priv *) &sta->drv_priv : NULL;
> @@ -368,7 +368,7 @@ static void wfx_tx_fixup_rates(struct ieee80211_tx_rate *rates)
> }
>
> static u8 wfx_tx_get_rate_id(struct wfx_vif *wvif,
> - struct ieee80211_tx_info *tx_info)
> + struct ieee80211_tx_info *tx_info)
> {
> bool tx_policy_renew = false;
> u8 rate_id;
--
J?r?me Pouiller
On Mon, 2020-02-24 at 01:02 +0530, Kaaira Gupta wrote:
> match next line with open parentheses by giving appropriate tabs.
This patch is only for data_tx.c
There are many more parentheses that are not aligned
in staging/wfx in other files.
Realistically, either change the subject to show
that it's only for data_tx or do them all.
(but not traces.h, those use a different style)
$ ./scripts/checkpatch.pl -f --terse --nosummary --types=parenthesis_alignment drivers/staging/wfx/*.[ch]
drivers/staging/wfx/data_tx.c:303: CHECK: Alignment should match open parenthesis
drivers/staging/wfx/data_tx.c:371: CHECK: Alignment should match open parenthesis
drivers/staging/wfx/debug.c:35: CHECK: Alignment should match open parenthesis
drivers/staging/wfx/key.c:35: CHECK: Alignment should match open parenthesis
drivers/staging/wfx/key.c:45: CHECK: Alignment should match open parenthesis
drivers/staging/wfx/key.c:55: CHECK: Alignment should match open parenthesis
drivers/staging/wfx/key.c:72: CHECK: Alignment should match open parenthesis
drivers/staging/wfx/key.c:97: CHECK: Alignment should match open parenthesis
drivers/staging/wfx/key.c:106: CHECK: Alignment should match open parenthesis
drivers/staging/wfx/key.c:118: CHECK: Alignment should match open parenthesis
drivers/staging/wfx/key.c:133: CHECK: Alignment should match open parenthesis
drivers/staging/wfx/key.c:147: CHECK: Alignment should match open parenthesis
drivers/staging/wfx/queue.c:393: CHECK: Alignment should match open parenthesis
drivers/staging/wfx/queue.c:408: CHECK: Alignment should match open parenthesis
drivers/staging/wfx/queue.c:433: CHECK: Alignment should match open parenthesis
drivers/staging/wfx/sta.c:123: CHECK: Alignment should match open parenthesis
drivers/staging/wfx/sta.c:235: CHECK: Alignment should match open parenthesis
drivers/staging/wfx/sta.c:291: CHECK: Alignment should match open parenthesis
drivers/staging/wfx/sta.c:340: CHECK: Alignment should match open parenthesis
drivers/staging/wfx/sta.c:717: CHECK: Alignment should match open parenthesis
drivers/staging/wfx/traces.h:156: CHECK: Alignment should match open parenthesis
drivers/staging/wfx/traces.h:194: CHECK: Alignment should match open parenthesis
drivers/staging/wfx/traces.h:206: CHECK: Alignment should match open parenthesis
drivers/staging/wfx/traces.h:211: CHECK: Alignment should match open parenthesis
drivers/staging/wfx/traces.h:234: CHECK: Alignment should match open parenthesis
drivers/staging/wfx/traces.h:257: CHECK: Alignment should match open parenthesis
drivers/staging/wfx/traces.h:265: CHECK: Alignment should match open parenthesis
drivers/staging/wfx/traces.h:271: CHECK: Alignment should match open parenthesis
drivers/staging/wfx/traces.h:278: CHECK: Alignment should match open parenthesis
drivers/staging/wfx/traces.h:296: CHECK: Alignment should match open parenthesis
drivers/staging/wfx/traces.h:302: CHECK: Alignment should match open parenthesis
drivers/staging/wfx/traces.h:307: CHECK: Alignment should match open parenthesis
drivers/staging/wfx/traces.h:313: CHECK: Alignment should match open parenthesis
drivers/staging/wfx/traces.h:324: CHECK: Alignment should match open parenthesis
drivers/staging/wfx/traces.h:329: CHECK: Alignment should match open parenthesis
drivers/staging/wfx/traces.h:334: CHECK: Alignment should match open parenthesis
drivers/staging/wfx/traces.h:351: CHECK: Alignment should match open parenthesis
drivers/staging/wfx/traces.h:362: CHECK: Alignment should match open parenthesis
drivers/staging/wfx/traces.h:416: CHECK: Alignment should match open parenthesis
drivers/staging/wfx/traces.h:418: CHECK: Alignment should match open parenthesis
On Mon, Feb 24, 2020 at 06:13:32AM -0800, Joe Perches wrote:
> On Mon, 2020-02-24 at 01:02 +0530, Kaaira Gupta wrote:
> > Match next line with open parentheses by giving appropriate tabs.
Changed the first word to caps. Will keep this in mind from now on.
Thanks!
>
> This patch is only for data_tx.c
>
> There are many more parentheses that are not aligned
> in staging/wfx in other files.
>
> Realistically, either change the subject to show
> that it's only for data_tx or do them all.
I have made the changes in the subject line and will submit a separate
patch with clean-ups in all the other files
>
> (but not traces.h, those use a different style)
>
> $ ./scripts/checkpatch.pl -f --terse --nosummary --types=parenthesis_alignment drivers/staging/wfx/*.[ch]
> drivers/staging/wfx/data_tx.c:303: CHECK: Alignment should match open parenthesis
> drivers/staging/wfx/data_tx.c:371: CHECK: Alignment should match open parenthesis
> drivers/staging/wfx/debug.c:35: CHECK: Alignment should match open parenthesis
> drivers/staging/wfx/key.c:35: CHECK: Alignment should match open parenthesis
> drivers/staging/wfx/key.c:45: CHECK: Alignment should match open parenthesis
> drivers/staging/wfx/key.c:55: CHECK: Alignment should match open parenthesis
> drivers/staging/wfx/key.c:72: CHECK: Alignment should match open parenthesis
> drivers/staging/wfx/key.c:97: CHECK: Alignment should match open parenthesis
> drivers/staging/wfx/key.c:106: CHECK: Alignment should match open parenthesis
> drivers/staging/wfx/key.c:118: CHECK: Alignment should match open parenthesis
> drivers/staging/wfx/key.c:133: CHECK: Alignment should match open parenthesis
> drivers/staging/wfx/key.c:147: CHECK: Alignment should match open parenthesis
> drivers/staging/wfx/queue.c:393: CHECK: Alignment should match open parenthesis
> drivers/staging/wfx/queue.c:408: CHECK: Alignment should match open parenthesis
> drivers/staging/wfx/queue.c:433: CHECK: Alignment should match open parenthesis
> drivers/staging/wfx/sta.c:123: CHECK: Alignment should match open parenthesis
> drivers/staging/wfx/sta.c:235: CHECK: Alignment should match open parenthesis
> drivers/staging/wfx/sta.c:291: CHECK: Alignment should match open parenthesis
> drivers/staging/wfx/sta.c:340: CHECK: Alignment should match open parenthesis
> drivers/staging/wfx/sta.c:717: CHECK: Alignment should match open parenthesis
> drivers/staging/wfx/traces.h:156: CHECK: Alignment should match open parenthesis
> drivers/staging/wfx/traces.h:194: CHECK: Alignment should match open parenthesis
> drivers/staging/wfx/traces.h:206: CHECK: Alignment should match open parenthesis
> drivers/staging/wfx/traces.h:211: CHECK: Alignment should match open parenthesis
> drivers/staging/wfx/traces.h:234: CHECK: Alignment should match open parenthesis
> drivers/staging/wfx/traces.h:257: CHECK: Alignment should match open parenthesis
> drivers/staging/wfx/traces.h:265: CHECK: Alignment should match open parenthesis
> drivers/staging/wfx/traces.h:271: CHECK: Alignment should match open parenthesis
> drivers/staging/wfx/traces.h:278: CHECK: Alignment should match open parenthesis
> drivers/staging/wfx/traces.h:296: CHECK: Alignment should match open parenthesis
> drivers/staging/wfx/traces.h:302: CHECK: Alignment should match open parenthesis
> drivers/staging/wfx/traces.h:307: CHECK: Alignment should match open parenthesis
> drivers/staging/wfx/traces.h:313: CHECK: Alignment should match open parenthesis
> drivers/staging/wfx/traces.h:324: CHECK: Alignment should match open parenthesis
> drivers/staging/wfx/traces.h:329: CHECK: Alignment should match open parenthesis
> drivers/staging/wfx/traces.h:334: CHECK: Alignment should match open parenthesis
> drivers/staging/wfx/traces.h:351: CHECK: Alignment should match open parenthesis
> drivers/staging/wfx/traces.h:362: CHECK: Alignment should match open parenthesis
> drivers/staging/wfx/traces.h:416: CHECK: Alignment should match open parenthesis
> drivers/staging/wfx/traces.h:418: CHECK: Alignment should match open parenthesis
>
>
>
>
On Mon, Feb 24, 2020 at 09:56:21PM +0530, Kaaira Gupta wrote:
> On Mon, Feb 24, 2020 at 06:13:32AM -0800, Joe Perches wrote:
> > On Mon, 2020-02-24 at 01:02 +0530, Kaaira Gupta wrote:
> > > Match next line with open parentheses by giving appropriate tabs.
>
> Changed the first word to caps. Will keep this in mind from now on.
> Thanks!
>
There was no "v2" patch in this email, what happened to it?
I've dropped this thread now, please resend the patch if you have an
updated version.
thanks,
greg k-h