2020-02-26 18:34:18

by Måns Rullgård

Subject: [PATCH] ARM: dts: sunxi: h3/h5: add r_pwm node

There is a second PWM unit available in the PL I/O block.
Add a node and pinmux definition for it.

Signed-off-by: Mans Rullgard <[email protected]>
---
arch/arm/boot/dts/sunxi-h3-h5.dtsi | 13 +++++++++++++
1 file changed, 13 insertions(+)

diff --git a/arch/arm/boot/dts/sunxi-h3-h5.dtsi b/arch/arm/boot/dts/sunxi-h3-h5.dtsi
index 107eeafad20a..1842c9f12c36 100644
--- a/arch/arm/boot/dts/sunxi-h3-h5.dtsi
+++ b/arch/arm/boot/dts/sunxi-h3-h5.dtsi
@@ -871,6 +871,19 @@
pins = "PL0", "PL1";
function = "s_i2c";
};
+
+ r_pwm_pins: r-pwm-pins {
+ pins = "PL10";
+ function = "s_pwm";
+ };
+ };
+
+ r_pwm: pwm@1f03800 {
+ compatible = "allwinner,sun8i-h3-pwm";
+ reg = <0x01f03800 0x8>;
+ clocks = <&osc24M>;
+ #pwm-cells = <3>;
+ status = "disabled";
};
};
};
--
2.25.0

2020-02-27 03:06:28

by Chen-Yu Tsai

Subject: Re: [PATCH] ARM: dts: sunxi: h3/h5: add r_pwm node

On Thu, Feb 27, 2020 at 2:33 AM Mans Rullgard <[email protected]> wrote:
>
> There is a second PWM unit available in the PL I/O block.
> Add a node and pinmux definition for it.
>
> Signed-off-by: Mans Rullgard <[email protected]>
> ---
> arch/arm/boot/dts/sunxi-h3-h5.dtsi | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/arch/arm/boot/dts/sunxi-h3-h5.dtsi b/arch/arm/boot/dts/sunxi-h3-h5.dtsi
> index 107eeafad20a..1842c9f12c36 100644
> --- a/arch/arm/boot/dts/sunxi-h3-h5.dtsi
> +++ b/arch/arm/boot/dts/sunxi-h3-h5.dtsi
> @@ -871,6 +871,19 @@
> pins = "PL0", "PL1";
> function = "s_i2c";
> };
> +
> + r_pwm_pins: r-pwm-pins {

Since it's just one pin, you could use the singular form instead.
And also set it as the default.

With that,

Reviewed-by: Chen-Yu Tsai <[email protected]>

> + pins = "PL10";
> + function = "s_pwm";
> + };
> + };
> +
> + r_pwm: pwm@1f03800 {
> + compatible = "allwinner,sun8i-h3-pwm";
> + reg = <0x01f03800 0x8>;
> + clocks = <&osc24M>;
> + #pwm-cells = <3>;
> + status = "disabled";
> };
> };
> };
> --
> 2.25.0
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> [email protected]
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel