2020-03-06 19:22:54

by Remi Pommarel

Subject: [PATCH] net: stmmac: dwmac1000: Disable ACS if enhanced descs are not used

ACS (auto PAD/FCS stripping) removes FCS off 802.3 packets (LLC) so that
there is no need to manually strip it for such packets. The enhanced DMA
descriptors allow to flag LLC packets so that the receiving callback can
use that to strip FCS manually or not. On the other hand, normal
descriptors do not support that.

Thus in order to not truncate LLC packet ACS should be disabled when
using normal DMA descriptors.

Signed-off-by: Remi Pommarel <[email protected]>
---
drivers/net/ethernet/stmicro/stmmac/dwmac1000_core.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac1000_core.c b/drivers/net/ethernet/stmicro/stmmac/dwmac1000_core.c
index d0356fbd1e43..b468acf03b00 100644
--- a/drivers/net/ethernet/stmicro/stmmac/dwmac1000_core.c
+++ b/drivers/net/ethernet/stmicro/stmmac/dwmac1000_core.c
@@ -25,6 +25,7 @@ static void dwmac1000_core_init(struct mac_device_info *hw,
struct net_device *dev)
{
void __iomem *ioaddr = hw->pcsr;
+ struct stmmac_priv *priv = netdev_priv(dev);
u32 value = readl(ioaddr + GMAC_CONTROL);
int mtu = dev->mtu;

@@ -35,7 +36,7 @@ static void dwmac1000_core_init(struct mac_device_info *hw,
* Broadcom tags can look like invalid LLC/SNAP packets and cause the
* hardware to truncate packets on reception.
*/
- if (netdev_uses_dsa(dev))
+ if (netdev_uses_dsa(dev) || !priv->plat->enh_desc)
value &= ~GMAC_CONTROL_ACS;

if (mtu > 1500)
--
2.25.0

2020-03-07 17:35:47

by Jose Abreu

Subject: RE: [PATCH] net: stmmac: dwmac1000: Disable ACS if enhanced descs are not used

From: Remi Pommarel <[email protected]>
Date: Mar/06/2020, 19:30:36 (UTC+00:00)

> void __iomem *ioaddr = hw->pcsr;
> + struct stmmac_priv *priv = netdev_priv(dev);
> u32 value = readl(ioaddr + GMAC_CONTROL);
> int mtu = dev->mtu;

Please use reverse Christmas tree order and also provide a Fixes tag.

---
Thanks,
Jose Miguel Abreu

2020-03-08 09:18:38

by Remi Pommarel

Subject: Re: [PATCH] net: stmmac: dwmac1000: Disable ACS if enhanced descs are not used

On Sat, Mar 07, 2020 at 05:34:28PM +0000, Jose Abreu wrote:
> From: Remi Pommarel <[email protected]>
> Date: Mar/06/2020, 19:30:36 (UTC+00:00)
>
> > void __iomem *ioaddr = hw->pcsr;
> > + struct stmmac_priv *priv = netdev_priv(dev);
> > u32 value = readl(ioaddr + GMAC_CONTROL);
> > int mtu = dev->mtu;
>
> Please use reverse Christmas tree order and also provide a Fixes tag.

Done in v2.

Thanks,
--
Remi